14/6d8370673b94a33b5fe09229672c2eadb7c717

   1 Return-Path: <wking@tremily.us>\r
   2 X-Original-To: notmuch@notmuchmail.org\r
   3 Delivered-To: notmuch@notmuchmail.org\r
   4 Received: from localhost (localhost [127.0.0.1])\r
   5         by olra.theworths.org (Postfix) with ESMTP id 141C6431FC0\r
   6         for <notmuch@notmuchmail.org>; Wed, 24 Sep 2014 14:39:21 -0700 (PDT)\r
   7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
   8 X-Spam-Flag: NO\r
   9 X-Spam-Score: -0.1\r
  10 X-Spam-Level: \r
  11 X-Spam-Status: No, score=-0.1 tagged_above=-999 required=5\r
  12         tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1,\r
  13         RCVD_IN_DNSWL_NONE=-0.0001] autolearn=disabled\r
  14 Received: from olra.theworths.org ([127.0.0.1])\r
  15         by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
  16         with ESMTP id WGCKgjYx6aXG for <notmuch@notmuchmail.org>;\r
  17         Wed, 24 Sep 2014 14:39:13 -0700 (PDT)\r
  18 Received: from resqmta-po-01v.sys.comcast.net (resqmta-po-01v.sys.comcast.net\r
  19         [96.114.154.160])\r
  20         (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits))\r
  21         (No client certificate requested)\r
  22         by olra.theworths.org (Postfix) with ESMTPS id 58914431FBD\r
  23         for <notmuch@notmuchmail.org>; Wed, 24 Sep 2014 14:39:13 -0700 (PDT)\r
  24 Received: from resomta-po-08v.sys.comcast.net ([96.114.154.232])\r
  25         by resqmta-po-01v.sys.comcast.net with comcast\r
  26         id v9cq1o00F516pyw019fCrL; Wed, 24 Sep 2014 21:39:12 +0000\r
  27 Received: from odin.tremily.us ([24.18.63.50])\r
  28         by resomta-po-08v.sys.comcast.net with comcast\r
  29         id v9fB1o00F152l3L019fBrW; Wed, 24 Sep 2014 21:39:12 +0000\r
  30 Received: by odin.tremily.us (Postfix, from userid 1000)\r
  31         id 2363413BF318; Wed, 24 Sep 2014 14:39:11 -0700 (PDT)\r
  32 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tremily.us; s=odin;\r
  33         t=1411594751; bh=29xaQ83nIobJVVFWBjPYb704ixo/48owUqP7Ai1sSY8=;\r
  34         h=Date:From:To:Cc:Subject:References:In-Reply-To;\r
  35         b=LUe/f5wXQm6FJuVyo/Lz857N1XKqRYSwagcpgxRuOnPYCqIhNhulyYpUq0Uq8lyMl\r
  36         td9udCIy3Qs5oIkQmycYUZpseHZhQezs0dzPTpk5n09Sh0j1dPxCH9Ow9U2jUgqIHl\r
  37         Sg24mfkMuTyJBABK39wPLiJ+0/LL7c7SvpXgPneU=\r
  38 Date: Wed, 24 Sep 2014 14:39:10 -0700\r
  39 From: "W. Trevor King" <wking@tremily.us>\r
  40 To: Austin Clements <aclements@csail.mit.edu>\r
  41 Subject: Re: [PATCH v3] lib: Simplify close and codify aborting atomic section\r
  42 Message-ID: <20140924213910.GF20130@odin.tremily.us>\r
  43 References: <20140924212839.GE20130@odin.tremily.us>\r
  44         <1411594370-9794-1-git-send-email-aclements@csail.mit.edu>\r
  45 MIME-Version: 1.0\r
  46 Content-Type: multipart/signed; micalg=pgp-sha1;\r
  47         protocol="application/pgp-signature"; boundary="/aVve/J9H4Wl5yVO"\r
  48 Content-Disposition: inline\r
  49 In-Reply-To: <1411594370-9794-1-git-send-email-aclements@csail.mit.edu>\r
  50 OpenPGP: id=39A2F3FA2AB17E5D8764F388FC29BDCDF15F5BE8;\r
  51         url=http://tremily.us/pubkey.txt\r
  52 User-Agent: Mutt/1.5.23 (2014-03-12)\r
  53 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=comcast.net;\r
  54         s=q20140121; t=1411594752;\r
  55         bh=eYRnpNHm1iV1mw9zTioOAa0EC+gQm3Hz9kEszYhumnM=;\r
  56         h=Received:Received:Received:Date:From:To:Subject:Message-ID:\r
  57         MIME-Version:Content-Type;\r
  58         b=IVy8EBUrxx/MDo+kR3COBt/AUXbtou65GBH8PIb2GxMdmeWBQfCIq5ky3c2/svD+o\r
  59         V1EFyvo3eOSqEGT+xEAtc94HkcBRT48QRfaWq18IwCpjx7yHczzce/6FWK+6iJ5/qx\r
  60         3heNHsOjVVHocFrobgISiCMwViycfvk/nrIPo5tv/jACyKcyL4ZdlGHjy//m/hpsSq\r
  61         QLa4NGhuKslKnG/ZO28NpZsIpNN2sMfbP8KZeNwD2C4RIMC883e2x75nQhP8E4CMNI\r
  62         wruICUxrTNk84PghrXI68R+CvVP7fId1rvhmeA4dvV2GdYgkqY3XxF62TNMb/S+Tar\r
  63         NbQcqaszrShoA==\r
  64 Cc: notmuch@notmuchmail.org\r
  65 X-BeenThere: notmuch@notmuchmail.org\r
  66 X-Mailman-Version: 2.1.13\r
  67 Precedence: list\r
  68 List-Id: "Use and development of the notmuch mail system."\r
  69         <notmuch.notmuchmail.org>\r
  70 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
  71         <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
  72 List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
  73 List-Post: <mailto:notmuch@notmuchmail.org>\r
  74 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
  75 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
  76         <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
  77 X-List-Received-Date: Wed, 24 Sep 2014 21:39:21 -0000\r
  78 \r
  79 \r
  80 --/aVve/J9H4Wl5yVO\r
  81 Content-Type: text/plain; charset=us-ascii\r
  82 Content-Disposition: inline\r
  83 Content-Transfer-Encoding: quoted-printable\r
  84 \r
  85 On Wed, Sep 24, 2014 at 05:32:50PM -0400, Austin Clements wrote:\r
  86 > + * If the caller is currently in an atomic section (there was a\r
  87 > + * notmuch_database_begin_atomic without a matching\r
  88 > + * notmuch_database_end_atomic), this will abort the atomic section,\r
  89 > + * discarding any modifications made in the atomic section.  All\r
  90 > + * changes up to this will be committed.\r
  91 \r
  92 I still think Xapian's wording is more readable [1]:\r
  93 \r
  94   For a WritableDatabase, if a transaction is active it will be\r
  95   aborted, while if no transaction is active commit() will be\r
  96   implicitly called.\r
  97 \r
  98 How about:\r
  99 \r
 100   For a writable database, if a transaction is active (there was a\r
 101   notmuch_database_begin_atomic without a matching\r
 102   notmuch_database_end_atomic) it will be aborted, while if no\r
 103   transaction is active any pending changes will be committed.\r
 104 \r
 105 Cheers,\r
 106 Trevor\r
 107 \r
 108 [1]: http://xapian.org/docs/apidoc/html/classXapian_1_1Database.html#a59f5f=\r
 109 8b137723dcaaabdbdccbc0cf1eb\r
 110 \r
 111 --=20\r
 112 This email may be signed or encrypted with GnuPG (http://www.gnupg.org).\r
 113 For more information, see http://en.wikipedia.org/wiki/Pretty_Good_Privacy\r
 114 \r
 115 --/aVve/J9H4Wl5yVO\r
 116 Content-Type: application/pgp-signature; name="signature.asc"\r
 117 Content-Description: OpenPGP digital signature\r
 118 \r
 119 -----BEGIN PGP SIGNATURE-----\r
 120 Version: GnuPG v2\r
 121 \r
 122 iQIbBAEBAgAGBQJUIzn8AAoJEG8/JgBt8ol8SQYP9ihcFBhpSiczMQM0iTuPKBrV\r
 123 cc6qh6KnQLf9U6BZDbFEO5Jf1jfk+y1j96229gwMYf7PXYPLXTyRX7tl4/8qNAQr\r
 124 9FDB/ChBUJNgSAONEVDdVMEAmkxKXf0XUoATrduhKT1gljlGLxcobqrp2/deCxny\r
 125 BHcGXLOqo2U8vtBlqRfqxE+4pm0y6bINQ6U5JXhiw5IYZMyyE3d7WgsPSFn0clFc\r
 126 /+BagDpqd+TGYvlT/A7htXBaUrqjCEOfX31JfblrmM50YXiHFPpEHSF/aFCUchT8\r
 127 FTLHuFXZemvHNeBbdTTR8PhdZJsDXM1ghDn4/CyMltwjNuKhnxlQ2YVWpiXhgfX6\r
 128 p180/p20WdJtr5O96c/SoYRbfqVhmuBegv+s59EcS4t3zbjDxJQ4LR+BaVyip1TZ\r
 129 UEwVc2MLYTF8nqlJcn5elbe7Xmh50q8mwh098cYbVh03DNlPJUvSRmBkYrjf2opN\r
 130 sTVnW4WwA7YcNdChsxami2bCr1umRPNDEwuEs937+MtWTVAtyM2TUIXRqqxxAu6v\r
 131 4uME+xIZgPdEljktlwk7KvBGSf4ABD1uZdFr7wVONiFsvFsg1pP91JJ+bDDgOXBv\r
 132 HRzxqqq9wosDxbHXtKNQVIMvGYZUfiWikzGwvMTYyRGH5I7c3FcVS2+Tbrmkwe8s\r
 133 +DSeIXNIk6nxvyC51c4=\r
 134 =foFN\r
 135 -----END PGP SIGNATURE-----\r
 136 \r
 137 --/aVve/J9H4Wl5yVO--\r