1 Return-Path: <dmitry.kurochkin@gmail.com>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 5344B431FBD
\r
6 for <notmuch@notmuchmail.org>; Thu, 2 Feb 2012 16:19:27 -0800 (PST)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=1.7 tagged_above=-999 required=5
\r
12 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1,
\r
13 FREEMAIL_FROM=0.001, FREEMAIL_REPLY=2.499, RCVD_IN_DNSWL_LOW=-0.7]
\r
15 Received: from olra.theworths.org ([127.0.0.1])
\r
16 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
17 with ESMTP id S6CQWrfGaWNC for <notmuch@notmuchmail.org>;
\r
18 Thu, 2 Feb 2012 16:19:26 -0800 (PST)
\r
19 Received: from mail-bk0-f53.google.com (mail-bk0-f53.google.com
\r
20 [209.85.214.53]) (using TLSv1 with cipher RC4-SHA (128/128 bits))
\r
21 (No client certificate requested)
\r
22 by olra.theworths.org (Postfix) with ESMTPS id 8FDAB431FAF
\r
23 for <notmuch@notmuchmail.org>; Thu, 2 Feb 2012 16:19:26 -0800 (PST)
\r
24 Received: by bke11 with SMTP id 11so2968923bke.26
\r
25 for <notmuch@notmuchmail.org>; Thu, 02 Feb 2012 16:19:25 -0800 (PST)
\r
26 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma;
\r
27 h=from:to:subject:in-reply-to:references:user-agent:date:message-id
\r
28 :mime-version:content-type;
\r
29 bh=a7rSI/9bbAsJBRi0zzXmehXh14TPgMngJRA0gKpRE5Y=;
\r
30 b=TTfvAWdBewD3Es3fm5Jc7GAaacNODIxcqY1sZwTbDRpgDjCKlYs6mEcHI46yqaQBKb
\r
31 JjztniKIGMn+0E4UhAPUtWTFarjj6+3o0xl6qqfwgxkSH8UrGMLM0XyM/XKUVR6auJST
\r
32 7ubyD2kJSG2oIrRa9ybl/s7UYUOt5YA9mlkOc=
\r
33 Received: by 10.204.133.201 with SMTP id g9mr2406841bkt.137.1328228364959;
\r
34 Thu, 02 Feb 2012 16:19:24 -0800 (PST)
\r
35 Received: from localhost ([91.144.186.21])
\r
36 by mx.google.com with ESMTPS id 20sm11666300bkr.0.2012.02.02.16.19.23
\r
37 (version=TLSv1/SSLv3 cipher=OTHER);
\r
38 Thu, 02 Feb 2012 16:19:23 -0800 (PST)
\r
39 From: Dmitry Kurochkin <dmitry.kurochkin@gmail.com>
\r
40 To: Jameson Graef Rollins <jrollins@finestructure.net>,
\r
41 notmuch@notmuchmail.org
\r
42 Subject: Re: [PATCH 1/2] test: add check for <expected> filename argument for
\r
43 test_expect_equal_file
\r
44 In-Reply-To: <87zkd1p12c.fsf@servo.finestructure.net>
\r
45 References: <1328141050-30356-1-git-send-email-dmitry.kurochkin@gmail.com>
\r
46 <1328141050-30356-2-git-send-email-dmitry.kurochkin@gmail.com>
\r
47 <87zkd1p12c.fsf@servo.finestructure.net>
\r
48 User-Agent: Notmuch/0.11+139~gd9b7cab (http://notmuchmail.org) Emacs/23.3.1
\r
49 (x86_64-pc-linux-gnu)
\r
50 Date: Fri, 03 Feb 2012 04:18:09 +0400
\r
51 Message-ID: <87zkd0ixby.fsf@gmail.com>
\r
53 Content-Type: text/plain; charset=us-ascii
\r
54 X-BeenThere: notmuch@notmuchmail.org
\r
55 X-Mailman-Version: 2.1.13
\r
57 List-Id: "Use and development of the notmuch mail system."
\r
58 <notmuch.notmuchmail.org>
\r
59 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
60 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
61 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
62 List-Post: <mailto:notmuch@notmuchmail.org>
\r
63 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
64 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
65 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
66 X-List-Received-Date: Fri, 03 Feb 2012 00:19:27 -0000
\r
70 On Thu, 02 Feb 2012 10:00:59 -0800, Jameson Graef Rollins <jrollins@finestructure.net> wrote:
\r
71 > Hey, Dmitry. I'm so sorry I sent my last email on your original patch
\r
72 > before I saw this new series.
\r
76 > I do now like your original proposal
\r
77 > better, since it shows the diff based the names the caller provides,
\r
78 > which I now agree is probably the clearest and most robust solution.
\r
79 > The second patch in this series could still go through, though, no
\r
80 > matter what version of the change to test_expect_equal_file we go with.
\r
83 Ok. I am going to wait for some time (e.g. 2 days) for more opinions.
\r
84 Though, I doubt I would get any :) (And the problem is really minor, so
\r
85 it probably does not deserve much attention.)
\r
87 Currently, it seems that the original approach [1] wins.
\r
92 [1] id:"1328080794-24670-1-git-send-email-dmitry.kurochkin@gmail.com"
\r