1 Return-Path: <m.walters@qmul.ac.uk>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 410B0431FAF
\r
6 for <notmuch@notmuchmail.org>; Wed, 25 Jul 2012 14:12:30 -0700 (PDT)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=-1.098 tagged_above=-999 required=5
\r
12 tests=[DKIM_ADSP_CUSTOM_MED=0.001, FREEMAIL_FROM=0.001,
\r
13 NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled
\r
14 Received: from olra.theworths.org ([127.0.0.1])
\r
15 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
16 with ESMTP id 1xCyWNCxVx8T for <notmuch@notmuchmail.org>;
\r
17 Wed, 25 Jul 2012 14:12:29 -0700 (PDT)
\r
18 Received: from mail2.qmul.ac.uk (mail2.qmul.ac.uk [138.37.6.6])
\r
19 (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
\r
20 (No client certificate requested)
\r
21 by olra.theworths.org (Postfix) with ESMTPS id E371D431FAE
\r
22 for <notmuch@notmuchmail.org>; Wed, 25 Jul 2012 14:12:28 -0700 (PDT)
\r
23 Received: from smtp.qmul.ac.uk ([138.37.6.40])
\r
24 by mail2.qmul.ac.uk with esmtp (Exim 4.71)
\r
25 (envelope-from <m.walters@qmul.ac.uk>)
\r
26 id 1Su8sc-00019z-T0; Wed, 25 Jul 2012 22:12:27 +0100
\r
27 Received: from 94-192-233-223.zone6.bethere.co.uk ([94.192.233.223]
\r
29 by smtp.qmul.ac.uk with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.69)
\r
30 (envelope-from <m.walters@qmul.ac.uk>)
\r
31 id 1Su8sc-0000mJ-GL; Wed, 25 Jul 2012 22:12:26 +0100
\r
32 From: Mark Walters <markwalters1009@gmail.com>
\r
33 To: Tomi Ollila <tomi.ollila@iki.fi>, notmuch@notmuchmail.org
\r
34 Subject: Re: [PATCH 1/5] emacs: compile and load notmuch-pick.el if present.
\r
35 In-Reply-To: <m2ipdcqjwj.fsf@guru.guru-group.fi>
\r
36 References: <1343164911-31589-1-git-send-email-markwalters1009@gmail.com>
\r
37 <1343164911-31589-2-git-send-email-markwalters1009@gmail.com>
\r
38 <m2ipdcqjwj.fsf@guru.guru-group.fi>
\r
39 User-Agent: Notmuch/0.13.2+93~gf33b188 (http://notmuchmail.org) Emacs/23.4.1
\r
40 (x86_64-pc-linux-gnu)
\r
41 Date: Wed, 25 Jul 2012 22:12:27 +0100
\r
42 Message-ID: <87fw8fsfyc.fsf@qmul.ac.uk>
\r
44 Content-Type: text/plain; charset=us-ascii
\r
45 X-Sender-Host-Address: 94.192.233.223
\r
46 X-QM-SPAM-Info: Sender has good ham record. :)
\r
47 X-QM-Body-MD5: 87ad75fb37111fc9889f7383785aea23 (of first 20000 bytes)
\r
48 X-SpamAssassin-Score: -1.8
\r
49 X-SpamAssassin-SpamBar: -
\r
50 X-SpamAssassin-Report: The QM spam filters have analysed this message to
\r
52 spam. We require at least 5.0 points to mark a message as spam.
\r
53 This message scored -1.8 points.
\r
54 Summary of the scoring:
\r
55 * -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at http://www.dnswl.org/,
\r
57 * [138.37.6.40 listed in list.dnswl.org]
\r
58 * 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail
\r
59 provider * (markwalters1009[at]gmail.com)
\r
60 * -0.0 T_RP_MATCHES_RCVD Envelope sender domain matches handover relay
\r
62 * 0.5 AWL AWL: From: address is in the auto white-list
\r
63 X-QM-Scan-Virus: ClamAV says the message is clean
\r
64 X-BeenThere: notmuch@notmuchmail.org
\r
65 X-Mailman-Version: 2.1.13
\r
67 List-Id: "Use and development of the notmuch mail system."
\r
68 <notmuch.notmuchmail.org>
\r
69 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
70 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
71 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
72 List-Post: <mailto:notmuch@notmuchmail.org>
\r
73 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
74 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
75 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
76 X-List-Received-Date: Wed, 25 Jul 2012 21:12:30 -0000
\r
78 On Wed, 25 Jul 2012, Tomi Ollila <tomi.ollila@iki.fi> wrote:
\r
79 > On Wed, Jul 25 2012, Mark Walters <markwalters1009@gmail.com> wrote:
\r
81 >> Compile and load notmuch-pick.el if present.
\r
83 >> All the actual setup of pick is done in the function notmuch-pick-init
\r
84 >> so we call that in the notmuch init function if it is bound. This
\r
85 >> function will setup all extra keybinding etc.
\r
87 > Great stuff! See a few thoughts below...
\r
89 Thanks for these: I think they are all clear improvements.
\r
93 >> emacs/Makefile.local | 3 ++-
\r
94 >> emacs/notmuch.el | 5 +++++
\r
95 >> 2 files changed, 7 insertions(+), 1 deletions(-)
\r
97 >> diff --git a/emacs/Makefile.local b/emacs/Makefile.local
\r
98 >> index fb82247..9f4dba6 100644
\r
99 >> --- a/emacs/Makefile.local
\r
100 >> +++ b/emacs/Makefile.local
\r
101 >> @@ -15,7 +15,8 @@ emacs_sources := \
\r
102 >> $(dir)/notmuch-crypto.el \
\r
103 >> $(dir)/notmuch-tag.el \
\r
104 >> $(dir)/coolj.el \
\r
105 >> - $(dir)/notmuch-print.el
\r
106 >> + $(dir)/notmuch-print.el \
\r
107 >> + $(wildcard $(dir)/notmuch-pick.el)
\r
109 > I wonder whether having this conditional is good idea. What if
\r
110 > someone copies (or (sym)links) notmuch-pick.el there and then
\r
111 > compiles and takes to use. Next time he takes clean tree and
\r
112 > forgets to do this copying and installs to the same destination.
\r
113 > Now there is old notmuch-pick.elc which might be out of sync.
\r
115 > I think it would be better to provide a shell script in
\r
116 > notmuch-pick directory which byte-compiles and installs notmuch-pick
\r
117 > in case user wants to install/update notmuch-pick. Whenever notmuch-pick
\r
118 > is good enough to be shipped inside $(dir) above then the aboce conditional
\r
119 > is not needed (at all).
\r
122 I have now done this: I actually use a Makefile so that I can pick up
\r
123 the config from notmuch: in particular the install directory
\r
124 for the notmuch-pick.elc file. Does that seem reasonable?
\r
127 >> emacs_images := \
\r
128 >> $(srcdir)/$(dir)/notmuch-logo.png
\r
129 >> diff --git a/emacs/notmuch.el b/emacs/notmuch.el
\r
130 >> index fd1836f..4f3da4f 100644
\r
131 >> --- a/emacs/notmuch.el
\r
132 >> +++ b/emacs/notmuch.el
\r
133 >> @@ -59,6 +59,9 @@
\r
134 >> (require 'notmuch-maildir-fcc)
\r
135 >> (require 'notmuch-message)
\r
137 >> +;; Load notmuch-pick if available (but do not error if not present).
\r
138 >> +(load "notmuch-pick" t)
\r
140 >> (defcustom notmuch-search-result-format
\r
141 >> `(("date" . "%12s ")
\r
142 >> ("count" . "%-7s ")
\r
143 >> @@ -1088,6 +1091,8 @@ current search results AND that are tagged with the given tag."
\r
144 >> (defun notmuch ()
\r
145 >> "Run notmuch and display saved searches, known tags, etc."
\r
147 >> + (when (fboundp 'notmuch-pick-init)
\r
148 >> + (notmuch-pick-init))
\r
149 >> (notmuch-hello))
\r
151 > Instead of this could notmuch-pick.el contain:
\r
153 > In the beginning:
\r
155 > (require 'notmuch-hello)
\r
156 > (require 'notmuch-show)
\r
157 > (require 'notmuch) ;; XXX ATM, as notmuch-search-mode-map is defined here
\r
159 > And, at the end, before (provide 'notmuch-pick), execute the lines
\r
160 > what currenty are contained in (notmuch-pick-init).
\r
162 > Then, those who want to start using notmuch-pick at this time
\r
163 > can (just) write the following in their .emacs:
\r
165 > (require 'notmuch)
\r
166 > (require 'notmuch-pick)
\r
168 This works very nicely. And if we want a transitional period the
\r
169 notmuch-pick could be in (dir) but not loaded automatically.
\r
171 Many thanks for the excellent suggestions.
\r