1 Return-Path: <cworth@cworth.org>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 503594196F0
\r
6 for <notmuch@notmuchmail.org>; Thu, 3 Jun 2010 17:22:58 -0700 (PDT)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=-2.89 tagged_above=-999 required=5
\r
12 tests=[ALL_TRUSTED=-1, BAYES_00=-1.9, T_MIME_NO_TEXT=0.01]
\r
14 Received: from olra.theworths.org ([127.0.0.1])
\r
15 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
16 with ESMTP id I09o0UGE-tQ4; Thu, 3 Jun 2010 17:22:48 -0700 (PDT)
\r
17 Received: from yoom.home.cworth.org (localhost [127.0.0.1])
\r
18 by olra.theworths.org (Postfix) with ESMTP id 01607431FC1;
\r
19 Thu, 3 Jun 2010 17:22:48 -0700 (PDT)
\r
20 Received: by yoom.home.cworth.org (Postfix, from userid 1000)
\r
21 id A0D73568F2D; Thu, 3 Jun 2010 17:22:47 -0700 (PDT)
\r
22 From: Carl Worth <cworth@cworth.org>
\r
23 To: Tomas Carnecky <tom@dbservice.com>, notmuch@notmuchmail.org
\r
24 Subject: Re: [RFC] Add support for the Solaris platform
\r
25 In-Reply-To: <1272654024-5254-1-git-send-email-tom@dbservice.com>
\r
26 References: <1272654024-5254-1-git-send-email-tom@dbservice.com>
\r
27 User-Agent: Notmuch/0.3.1-22-g1d528f8 (http://notmuchmail.org) Emacs/23.1.1
\r
29 Date: Thu, 03 Jun 2010 17:22:47 -0700
\r
30 Message-ID: <87ocfreje0.fsf@yoom.home.cworth.org>
\r
32 Content-Type: multipart/signed; boundary="=-=-=";
\r
33 micalg=pgp-sha1; protocol="application/pgp-signature"
\r
34 X-BeenThere: notmuch@notmuchmail.org
\r
35 X-Mailman-Version: 2.1.13
\r
37 List-Id: "Use and development of the notmuch mail system."
\r
38 <notmuch.notmuchmail.org>
\r
39 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
40 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
41 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
42 List-Post: <mailto:notmuch@notmuchmail.org>
\r
43 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
44 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
45 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
46 X-List-Received-Date: Fri, 04 Jun 2010 00:22:58 -0000
\r
49 Content-Transfer-Encoding: quoted-printable
\r
51 On Fri, 30 Apr 2010 21:00:24 +0200, Tomas Carnecky <tom@dbservice.com> wrot=
\r
53 > Like on Mac OS X, the linker doesn't automatically resolve
\r
56 Thanks for this fix, Tomas!
\r
58 I like the fix described above, but you seem to have sent a patch with
\r
59 three independent changes, only one of which was described. See below
\r
60 for what I've done...
\r
62 > notmuch: $(notmuch_client_modules) lib/libnotmuch.a
\r
63 > - $(call quiet,CXX $(CFLAGS)) $^ $(FINAL_LIBNOTMUCH_LDFLAGS) -o $@
\r
64 > + $(call quiet,CXX $(CFLAGS)) $^ $(FINAL_NOTMUCH_LDFLAGS) -o $@
\r
66 That seems to be correct. Could you describe what problem you ran into
\r
67 that motivated you to find this fix? I have not committed this piece.
\r
69 > -printf "Checking for Mac OS X (for shared library)... "
\r
70 > +printf "Checking which platform we are on... "
\r
71 > if [ `uname` =3D "Darwin" ] ; then
\r
74 > + printf "Mac OS X.\n"
\r
75 > + platform=3DMACOSX
\r
77 > -ifeq ($(MAC_OS_X),1)
\r
78 > +ifeq ($(PLATFORM),MACOSX)
\r
79 > LIBRARY_SUFFIX =3D dylib
\r
80 > # On OS X, library version numbers go before suffix.
\r
81 > LINKER_NAME =3D libnotmuch.$(LIBRARY_SUFFIX)
\r
83 That hunk was all described by your original commit message. So I've
\r
84 applied this part with your original commit message and will be pushing
\r
87 > +/* Helper functions to test if a given dirent is of a certain type
\r
90 > +_is_reg(const char *path, struct dirent *entry)
\r
92 > @@ -372,7 +426,7 @@ add_files_recursive (notmuch_database_t *notmuch,
\r
94 > if (! S_ISREG (st.st_mode))
\r
96 > - } else if (entry->d_type !=3D DT_REG) {
\r
97 > + } else if (!_is_reg(path, entry)) {
\r
101 This all might be well and good, but is also not described by the commit
\r
102 message. So I have not committed this either. If you resend with an
\r
103 actual description of the change, I'll be happy to take a closer look.
\r
110 carl.d.worth@intel.com
\r
113 Content-Type: application/pgp-signature
\r
115 -----BEGIN PGP SIGNATURE-----
\r
116 Version: GnuPG v1.4.10 (GNU/Linux)
\r
118 iD8DBQFMCEdX6JDdNq8qSWgRAnFmAJ9c/8QJJhK0TCg28QXFycXfO/3s1gCfcSn1
\r
119 qESwlVSHeNEXHAgO1yTKAlk=
\r
121 -----END PGP SIGNATURE-----
\r