1 Return-Path: <wking@tremily.us>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 11A8B431E64
\r
6 for <notmuch@notmuchmail.org>; Mon, 3 Feb 2014 02:55:03 -0800 (PST)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=1.625 tagged_above=-999 required=5
\r
12 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_NONE=-0.0001,
\r
13 SUBJ_ALL_CAPS=1.625] autolearn=disabled
\r
14 Received: from olra.theworths.org ([127.0.0.1])
\r
15 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
16 with ESMTP id hmsKK2g8SJWD for <notmuch@notmuchmail.org>;
\r
17 Mon, 3 Feb 2014 02:54:56 -0800 (PST)
\r
18 X-Greylist: delayed 487 seconds by postgrey-1.32 at olra;
\r
19 Mon, 03 Feb 2014 02:54:56 PST
\r
20 Received: from qmta15.westchester.pa.mail.comcast.net
\r
21 (qmta15.westchester.pa.mail.comcast.net [76.96.59.228])
\r
22 by olra.theworths.org (Postfix) with ESMTP id 6287E431FDB
\r
23 for <notmuch@notmuchmail.org>; Mon, 3 Feb 2014 02:54:56 -0800 (PST)
\r
24 Received: from omta10.westchester.pa.mail.comcast.net ([76.96.62.28])
\r
25 by qmta15.westchester.pa.mail.comcast.net with comcast
\r
26 id Mml01n0040cZkys5FmmoN5; Mon, 03 Feb 2014 10:46:48 +0000
\r
27 Received: from odin.tremily.us ([24.18.63.50])
\r
28 by omta10.westchester.pa.mail.comcast.net with comcast
\r
29 id Mmmm1n00G152l3L3Wmmn6y; Mon, 03 Feb 2014 10:46:48 +0000
\r
30 Received: from mjolnir.tremily.us (unknown [192.168.0.140])
\r
31 by odin.tremily.us (Postfix) with ESMTPS id 37353FB4C69;
\r
32 Mon, 3 Feb 2014 02:46:45 -0800 (PST)
\r
33 Received: (nullmailer pid 31476 invoked by uid 1000);
\r
34 Mon, 03 Feb 2014 10:45:48 -0000
\r
35 From: "W. Trevor King" <wking@tremily.us>
\r
36 To: notmuch@notmuchmail.org
\r
37 Subject: [PATCH 0/2]
\r
38 Date: Mon, 3 Feb 2014 02:45:32 -0800
\r
39 Message-Id: <cover.1391423201.git.wking@tremily.us>
\r
40 X-Mailer: git-send-email 1.8.5.2.8.g0f6c0d1
\r
41 In-Reply-To: <877g9chbay.fsf@qmul.ac.uk>
\r
42 References: <877g9chbay.fsf@qmul.ac.uk>
\r
43 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=comcast.net;
\r
44 s=q20121106; t=1391424408;
\r
45 bh=TpnJ9HjpB0UGthm9im+bFc4fZ3bxjNMLDBAnqrYPbhQ=;
\r
46 h=Received:Received:Received:Received:From:To:Subject:Date:
\r
48 b=ehOuuUqui6CedZZFuO6PEfrkriNwAiPiwL85u8eGcyeRR/L2JmnulebCdf7vUK4ZT
\r
49 ZYwQN04Xo1WSUIetcw6U5HGfREoPtDSY9eq7wRPwSwTGALFQKcrwY8xt+mBA6Zszrk
\r
50 bs2QGBpzqN1tQDQDmw/Mg+UvqXbp842T20dmAxcev9H5ka3m0IccyIed1zaBdODMeY
\r
51 3VX+mmgI2EIghZ8P8KPTCOAQLFyleLDCKkWF0Uu4d6uxop9gWu2IgP4LAUy5l91Q2G
\r
52 y9dJprfOtid1ZxNY+GWOy70eBSjy4OErr/u9ItZZlQvLkWK3ZX7wK01cZqWaMpcQZf
\r
54 X-BeenThere: notmuch@notmuchmail.org
\r
55 X-Mailman-Version: 2.1.13
\r
57 List-Id: "Use and development of the notmuch mail system."
\r
58 <notmuch.notmuchmail.org>
\r
59 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
60 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
61 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
62 List-Post: <mailto:notmuch@notmuchmail.org>
\r
63 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
64 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
65 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
66 X-List-Received-Date: Mon, 03 Feb 2014 10:55:03 -0000
\r
68 On Mon, Feb 03, 2014 at 08:04:21AM +0000, Mark Walters wrote:
\r
69 > I think notmuch-show.c gets most of the header and related
\r
70 > information directly from the mail file not from the database
\r
71 > directly. I think we use gmime for that parsing so adding an extra
\r
72 > output pair for content-description there should be
\r
73 > sufficient. (This is lines 655-700 or so notmuch-show.c)
\r
75 Thanks, that's exactly what I needed :).
\r
77 > I think the emacs side should be roughly as above: we would need to
\r
78 > check that the default filename offered when saving is still
\r
81 notmuch-save-attachments is using:
\r
83 (assq 'filename disposition)
\r
85 and it looks like 'name' in notmuch-show-insert-part-header is only
\r
86 used for the button text.
\r
88 > Stylistically I think
\r
89 > + (name (or (plist-get part :content-description)
\r
90 > + (plist-get part :filename)))
\r
92 > is a little nicer.
\r
94 Thanks for clearing up my search-engine Lisp ;). Fixed in these
\r
100 p.s. I checked a few earlier patches on the list and didn't see
\r
101 reviewer CCs. On the other hand, I didn't see any Reply-To headers
\r
102 either, so I'm CCing my reviewers to be safe ;). Let me know if the
\r
103 convention is to not CC reviewers, and I'll restrict future
\r
104 submissions to notmuch@.
\r
106 W. Trevor King (2):
\r
107 notmuch-show: Add content-description output pair
\r
108 emacs: Prefer Content-Description over filename for part buttons
\r
111 emacs/notmuch-show.el | 4 +-
\r
112 notmuch-show.c | 8 +++
\r
113 test/T160-json.sh | 4 +-
\r
114 test/T170-sexp.sh | 4 +-
\r
115 test/T450-emacs-show.sh | 12 ++++
\r
116 test/corpus/cur/24:2, | 1 +
\r
117 .../notmuch-show-buttons-content-description | 84 ++++++++++++++++++++++
\r
118 .../notmuch-show-buttons-filename | 74 +++++++++++++++++++
\r
119 9 files changed, 195 insertions(+), 5 deletions(-)
\r
120 create mode 100644 test/emacs-show.expected-output/notmuch-show-buttons-content-description
\r
121 create mode 100644 test/emacs-show.expected-output/notmuch-show-buttons-filename
\r