1 Return-Path: <dme@dme.org>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 75E9F4196F2
\r
6 for <notmuch@notmuchmail.org>; Mon, 19 Apr 2010 22:27:11 -0700 (PDT)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=-1.9 tagged_above=-999 required=5
\r
12 tests=[BAYES_00=-1.9] autolearn=ham
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id 8lBbCwImhGeZ for <notmuch@notmuchmail.org>;
\r
16 Mon, 19 Apr 2010 22:27:09 -0700 (PDT)
\r
17 Received: from mail-wy0-f181.google.com (mail-wy0-f181.google.com
\r
19 by olra.theworths.org (Postfix) with ESMTP id 8F16A431FC1
\r
20 for <notmuch@notmuchmail.org>; Mon, 19 Apr 2010 22:27:08 -0700 (PDT)
\r
21 Received: by wyj26 with SMTP id 26so3178850wyj.26
\r
22 for <notmuch@notmuchmail.org>; Mon, 19 Apr 2010 22:27:07 -0700 (PDT)
\r
23 Received: by 10.216.160.8 with SMTP id t8mr1804469wek.101.1271741227412;
\r
24 Mon, 19 Apr 2010 22:27:07 -0700 (PDT)
\r
25 Received: from ut.hh.sledj.net (host83-217-165-81.dsl.vispa.com
\r
27 by mx.google.com with ESMTPS id x14sm54752319wbs.18.2010.04.19.22.27.05
\r
28 (version=TLSv1/SSLv3 cipher=RC4-MD5);
\r
29 Mon, 19 Apr 2010 22:27:05 -0700 (PDT)
\r
30 Received: by ut.hh.sledj.net (Postfix, from userid 1000)
\r
31 id E5BC0594163; Tue, 20 Apr 2010 06:27:02 +0100 (BST)
\r
32 To: Carl Worth <cworth@cworth.org>, notmuch <notmuch@notmuchmail.org>
\r
33 Subject: Re: pull request
\r
34 In-Reply-To: <87ljcj2u4z.fsf@yoom.home.cworth.org>
\r
35 References: <87sk722sfq.fsf@ut.hh.sledj.net> <87eiibq22s.fsf@ut.hh.sledj.net>
\r
36 <87ljcj2u4z.fsf@yoom.home.cworth.org>
\r
37 User-Agent: Notmuch/0.2-20-g89ec2c1 (http://notmuchmail.org) Emacs/23.1.1
\r
38 (x86_64-pc-linux-gnu)
\r
39 From: David Edmondson <dme@dme.org>
\r
40 Date: Tue, 20 Apr 2010 06:27:02 +0100
\r
41 Message-ID: <8739yq8zix.fsf@ut.hh.sledj.net>
\r
43 Content-Type: text/plain; charset=us-ascii
\r
44 X-BeenThere: notmuch@notmuchmail.org
\r
45 X-Mailman-Version: 2.1.13
\r
47 List-Id: "Use and development of the notmuch mail system."
\r
48 <notmuch.notmuchmail.org>
\r
49 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
50 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
51 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
52 List-Post: <mailto:notmuch@notmuchmail.org>
\r
53 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
54 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
55 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
56 X-List-Received-Date: Tue, 20 Apr 2010 05:27:12 -0000
\r
58 On Mon, 19 Apr 2010 11:07:40 -0700, Carl Worth <cworth@cworth.org> wrote:
\r
59 > > commit 8586a86b9dd4ed2406a2fbda6c08bdc6a598cfd8
\r
60 > > debian: git should ignore packaging intermediate files
\r
62 > I committed an alternate version of this, (with a new debian/.gitignore
\r
63 > file). I used more wildcarding too. And I couldn't actually find how to
\r
64 > make all these files appear. If you need more ignores, just let me know
\r
65 > (and let me know what commands trigger those, since I'm curious).
\r
67 >From memory I ran 'debuild'.
\r
69 > > commit 53c4e64943d09b07e75c9258fc9f954c87a490d6
\r
70 > > json: Avoid calling strlen(NULL)
\r
72 > That commit message describes this hunk of the patch:
\r
74 > > + if (str == NULL)
\r
77 > > return (json_quote_chararray (ctx, str, strlen (str)));
\r
79 > But this other hunk looks independent. What's going on here?
\r
82 > > - return (char *)"\"\"";
\r
85 > So I haven't committed this piece yet.
\r
87 The second chunk was intended to cover a similar case (len == 0), but
\r
88 becomes unnecessary after the first chunk. At least, that's what I
\r
89 convinced myself after the conversation with Anthony Towns
\r
90 (id:h2y87b3a4191004060117v5421db8ejbe3030d0626e7440@mail.gmail.com).
\r
94 David Edmondson, http://dme.org
\r