1 Return-Path: <jrollins@finestructure.net>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id A3533431E64
\r
6 for <notmuch@notmuchmail.org>; Wed, 1 Feb 2012 00:47:47 -0800 (PST)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=-2.29 tagged_above=-999 required=5
\r
12 tests=[RCVD_IN_DNSWL_MED=-2.3, T_MIME_NO_TEXT=0.01] autolearn=disabled
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id YfsPsHnH+0bf for <notmuch@notmuchmail.org>;
\r
16 Wed, 1 Feb 2012 00:47:46 -0800 (PST)
\r
17 Received: from outgoing-mail.its.caltech.edu (outgoing-mail.its.caltech.edu
\r
19 by olra.theworths.org (Postfix) with ESMTP id D1E60431FAF
\r
20 for <notmuch@notmuchmail.org>; Wed, 1 Feb 2012 00:47:46 -0800 (PST)
\r
21 Received: from fire-doxen.imss.caltech.edu (localhost [127.0.0.1])
\r
22 by fire-doxen-postvirus (Postfix) with ESMTP id 378E22E50E5F;
\r
23 Wed, 1 Feb 2012 00:47:44 -0800 (PST)
\r
24 X-Spam-Scanned: at Caltech-IMSS on fire-doxen by amavisd-new
\r
25 Received: from finestructure.net (cpe-76-174-137-84.socal.res.rr.com
\r
26 [76.174.137.84]) (Authenticated sender: jrollins)
\r
27 by fire-doxen-submit (Postfix) with ESMTP id 746C82E50D46;
\r
28 Wed, 1 Feb 2012 00:47:34 -0800 (PST)
\r
29 Received: by finestructure.net (Postfix, from userid 1000)
\r
30 id B9987291; Wed, 1 Feb 2012 00:47:33 -0800 (PST)
\r
31 From: Jameson Graef Rollins <jrollins@finestructure.net>
\r
32 To: Dmitry Kurochkin <dmitry.kurochkin@gmail.com>, notmuch@notmuchmail.org
\r
33 Subject: Re: [PATCH] test: make test_expect_equal_file() arguments flexible
\r
34 In-Reply-To: <1328080794-24670-1-git-send-email-dmitry.kurochkin@gmail.com>
\r
35 References: <1328080794-24670-1-git-send-email-dmitry.kurochkin@gmail.com>
\r
36 User-Agent: Notmuch/0.11+128~g6f388fa (http://notmuchmail.org) Emacs/23.3.1
\r
37 (x86_64-pc-linux-gnu)
\r
38 Date: Wed, 01 Feb 2012 00:47:30 -0800
\r
39 Message-ID: <87r4yfszx9.fsf@servo.finestructure.net>
\r
41 Content-Type: multipart/signed; boundary="=-=-=";
\r
42 micalg=pgp-sha256; protocol="application/pgp-signature"
\r
43 X-BeenThere: notmuch@notmuchmail.org
\r
44 X-Mailman-Version: 2.1.13
\r
46 List-Id: "Use and development of the notmuch mail system."
\r
47 <notmuch.notmuchmail.org>
\r
48 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
49 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
50 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
51 List-Post: <mailto:notmuch@notmuchmail.org>
\r
52 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
53 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
54 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
55 X-List-Received-Date: Wed, 01 Feb 2012 08:47:47 -0000
\r
59 On Wed, 1 Feb 2012 11:19:54 +0400, Dmitry Kurochkin <dmitry.kurochkin@gmail.com> wrote:
\r
60 > The down side of this approach is that diff argument order depends on
\r
61 > test_expect_equal_file() argument order. So sometimes we get diff
\r
62 > from expected to actual results, and sometimes the other way around.
\r
63 > But the files are always named correctly.
\r
65 Actually, I think this last point is the most important thing to retain.
\r
66 Consistency in the diffs makes reading test results much more efficient.
\r
67 The order I don't much care about. But seeing as we have been
\r
68 consistent with a particular order for a while, it seems like more
\r
69 effort than it's worth to change it.
\r
74 Content-Type: application/pgp-signature
\r
76 -----BEGIN PGP SIGNATURE-----
\r
77 Version: GnuPG v1.4.11 (GNU/Linux)
\r
79 iQIcBAEBCAAGBQJPKPwjAAoJEO00zqvie6q8ptIP+wTZveaN5Cq04UsIjSi/shdL
\r
80 qrjvzOMMqT+gQC13PRpeFmYEklL5Xa3F9FTmyGaiEtv7dQG9GJ70ii8c7kRObZzO
\r
81 7DkZFu4n2o4wSmfTVBh6arX5fJbBY/1rb8nnq7SltTJ/FTaPv/C4tquQY32YKb4d
\r
82 jpPGWRt+zntKk4U4BE+djHGuoLO4/f5ru4ZwAPKt0AKJv2VK8IJus6gVQdG9rxDp
\r
83 abuAwnzc75Wy5wzi1mkyQjdFCH36GwNTZfj8Iu46PmZcDb/iPLJZ4o8aYZI47vU2
\r
84 KrLiNHjyg5amWoCh51YQrh16g2OpssmxZ3CA2ZcqIaAE4TSH/YDv98ZYOkCE6CLa
\r
85 X1JWpDrsZRbqqWOqnhU45cKJh6Iia84voloAIu0FoDwmT0VdE7SQIr3FNC6DaUJH
\r
86 Ygzlug7I5Sl5fVH1rMxGbnq7r716XPjhacTcfRP/daXG/8+2bSvHDqO6zhmTryaq
\r
87 klzGTUJF4SovfVjJmHSqJFcTT+a7r3r/7nLILIYcdDLS1xtFJO3//xMTw31tZepp
\r
88 /efN+0MtW3lFLl+jUvoqN7R47d5M5UHClcl81W43fC165uSoXAOidv5d5uQjpNJg
\r
89 IuOEzpwSrVXNE9OfXrc+WX29l46YNDOzGm2mCzTzibNnwTG7TDabWcGkdSRFbIOT
\r
90 70QnD6m/z19ovoaOyYcW
\r
92 -----END PGP SIGNATURE-----
\r