1 Return-Path: <dmitry.kurochkin@gmail.com>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id CA5B5431FD0
\r
6 for <notmuch@notmuchmail.org>; Thu, 7 Jul 2011 01:22:46 -0700 (PDT)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=-0.799 tagged_above=-999 required=5
\r
12 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1,
\r
13 FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled
\r
14 Received: from olra.theworths.org ([127.0.0.1])
\r
15 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
16 with ESMTP id iHd6yl8bP54W for <notmuch@notmuchmail.org>;
\r
17 Thu, 7 Jul 2011 01:22:46 -0700 (PDT)
\r
18 Received: from mail-bw0-f53.google.com (mail-bw0-f53.google.com
\r
19 [209.85.214.53]) (using TLSv1 with cipher RC4-SHA (128/128 bits))
\r
20 (No client certificate requested)
\r
21 by olra.theworths.org (Postfix) with ESMTPS id EF1C1431FB6
\r
22 for <notmuch@notmuchmail.org>; Thu, 7 Jul 2011 01:22:45 -0700 (PDT)
\r
23 Received: by bwg12 with SMTP id 12so754056bwg.26
\r
24 for <notmuch@notmuchmail.org>; Thu, 07 Jul 2011 01:22:44 -0700 (PDT)
\r
25 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma;
\r
26 h=from:to:subject:in-reply-to:references:user-agent:date:message-id
\r
27 :mime-version:content-type;
\r
28 bh=mZ2yVBvJ4jyC9g1j9wmxV6GrMtxARWsA4+IVZM0qI/s=;
\r
29 b=kFB4LapKZ+r57G17VxoE9K2gVmXwafthH/zlCT4UQBpkGDFglj5Yn7VM80QtsTfxAx
\r
30 TG8aQ65SgCedzHh7GZKaUjbWyxowJCgUax7BnEeL3YuTVN0Bi1qG/hQzEG/K3cXGyd4e
\r
31 UoJLZnUuWraFE0UjQ5MCC+WAST7m9aFkhYL1M=
\r
32 Received: by 10.204.84.24 with SMTP id h24mr439822bkl.185.1310026964524;
\r
33 Thu, 07 Jul 2011 01:22:44 -0700 (PDT)
\r
34 Received: from localhost ([91.144.186.21])
\r
35 by mx.google.com with ESMTPS id c13sm8294399bkc.2.2011.07.07.01.22.42
\r
36 (version=TLSv1/SSLv3 cipher=OTHER);
\r
37 Thu, 07 Jul 2011 01:22:43 -0700 (PDT)
\r
38 From: Dmitry Kurochkin <dmitry.kurochkin@gmail.com>
\r
39 To: Daniel Schoepe <daniel.schoepe@googlemail.com>,
\r
40 Pieter Praet <pieter@praet.org>, notmuch@notmuchmail.org
\r
41 Subject: Re: [PATCH v2] emacs: Turn id:"<message-id>" elements into buttons
\r
42 for notmuch searches
\r
43 In-Reply-To: <87vcve1p70.fsf@tredergarh.home.box>
\r
44 References: <1309896760-378-1-git-send-email-daniel.schoepe@googlemail.com>
\r
45 <1309961881-28333-1-git-send-email-daniel.schoepe@googlemail.com>
\r
46 <1309961881-28333-2-git-send-email-daniel.schoepe@googlemail.com>
\r
47 <87r5624l3g.fsf@gmail.com> <87vcve1p70.fsf@tredergarh.home.box>
\r
48 User-Agent: Notmuch/0.5-321-g41686e2 (http://notmuchmail.org) Emacs/23.3.1
\r
49 (x86_64-pc-linux-gnu)
\r
50 Date: Thu, 07 Jul 2011 12:22:37 +0400
\r
51 Message-ID: <87ipre4i0i.fsf@gmail.com>
\r
53 Content-Type: text/plain; charset=us-ascii
\r
54 X-BeenThere: notmuch@notmuchmail.org
\r
55 X-Mailman-Version: 2.1.13
\r
57 List-Id: "Use and development of the notmuch mail system."
\r
58 <notmuch.notmuchmail.org>
\r
59 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
60 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
61 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
62 List-Post: <mailto:notmuch@notmuchmail.org>
\r
63 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
64 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
65 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
66 X-List-Received-Date: Thu, 07 Jul 2011 08:22:46 -0000
\r
68 On Thu, 07 Jul 2011 10:15:47 +0200, Daniel Schoepe <daniel.schoepe@googlemail.com> wrote:
\r
71 > On Thu, 07 Jul 2011 11:16:03 +0400, Dmitry Kurochkin <dmitry.kurochkin@gmail.com> wrote:
\r
72 > > Why do we need to remove `goto-address-mode' overlays if it is not
\r
73 > > enabled ((goto-address-mode t) is below is removed)?
\r
75 > > `goto-address-mode' creates buttons not only for email addresses but
\r
76 > > also for URLs. Do we loose it now?
\r
78 > Everything `goto-address-mode' does is still in effect, I just replaced
\r
79 > (goto-address-mode t) by a call to `goto-address-fontify-region' in
\r
80 > notmuch-show-buttonise-links, to ensure that the id links will be
\r
81 > buttonised (and the overlay removed after it's actually been inserted)
\r
82 > _after_ goto-address does its thing.
\r
84 > I could also have left (goto-address-mode t) in and jit-register-lock'ed
\r
85 > notmuch-show-buttonise-links before that, but then I would be relying on
\r
86 > the fact that fontifiers that are registered first, will be run last. As
\r
87 > far as I can tell this is just an implementation detail and might change
\r
91 Thank you and Pieter for the answers. I missed
\r
92 `goto-address-fontify-region' on the first look.
\r