1 Return-Path: <tomi.ollila@iki.fi>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id ED869431FAF
\r
6 for <notmuch@notmuchmail.org>; Wed, 11 Apr 2012 11:57:49 -0700 (PDT)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id 0aNI4uxERNot for <notmuch@notmuchmail.org>;
\r
16 Wed, 11 Apr 2012 11:57:49 -0700 (PDT)
\r
17 Received: from guru.guru-group.fi (guru-group.fi [87.108.86.66])
\r
18 by olra.theworths.org (Postfix) with ESMTP id 5AA66431FAE
\r
19 for <notmuch@notmuchmail.org>; Wed, 11 Apr 2012 11:57:49 -0700 (PDT)
\r
20 Received: by guru.guru-group.fi (Postfix, from userid 501)
\r
21 id D8D1168055; Wed, 11 Apr 2012 21:57:45 +0300 (EEST)
\r
22 From: Tomi Ollila <tomi.ollila@iki.fi>
\r
23 To: Vladimir.Marek@oracle.com, notmuch@notmuchmail.org
\r
24 Subject: Re: [PATCH 2/4] dirent->d_type not available on Soalris
\r
25 In-Reply-To: <1333989127-21523-1-git-send-email-Vladimir.Marek@oracle.com>
\r
27 <CAMoJFUvHbSfXLTGKf2ZZnaLpLzZiHJ7W_ZUYZzm70n5mw4r1Kg@mail.gmail.com>
\r
28 <1333989127-21523-1-git-send-email-Vladimir.Marek@oracle.com>User-Agent:
\r
29 Notmuch/0.12+77~gee11800 (http://notmuchmail.org) Emacs/23.3.1
\r
30 (x86_64-unknown-linux-gnu)
\r
31 X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL
\r
32 $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F
\r
33 !)g;OY^,BjTbr)Np:%c_o'jj,Z
\r
34 Date: Wed, 11 Apr 2012 21:57:45 +0300
\r
35 Message-ID: <m2ty0qm6za.fsf@guru.guru-group.fi>
\r
37 Content-Type: text/plain; charset=us-ascii
\r
38 Cc: Vladimir Marek <vlmarek@volny.cz>
\r
39 X-BeenThere: notmuch@notmuchmail.org
\r
40 X-Mailman-Version: 2.1.13
\r
42 List-Id: "Use and development of the notmuch mail system."
\r
43 <notmuch.notmuchmail.org>
\r
44 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
45 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
46 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
47 List-Post: <mailto:notmuch@notmuchmail.org>
\r
48 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
49 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
50 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
51 X-List-Received-Date: Wed, 11 Apr 2012 18:57:50 -0000
\r
53 On Mon, Apr 09 2012, Vladimir.Marek@oracle.com wrote:
\r
55 > From: Vladimir Marek <vlmarek@volny.cz>
\r
57 > The inspiration was taken from similar issue in mutt:
\r
58 > http://does-not-exist.org/mail-archives/mutt-dev/msg11290.html
\r
60 > Signed-off-by: Vladimir Marek <vlmarek@volny.cz>
\r
63 Code looks pretty good, but 2 issues
\r
65 1) Commit message should contain more verbose information what and
\r
66 why something was done.
\r
68 2) Does these #ifdefs break code indenters such as uncrustify(1),
\r
69 indent(1) and emacs(1) indent functionality.
\r
70 (That used to happen but maybe these indenters are smarted today.
\r
74 > notmuch-new.c | 28 ++++++++++++++++++++++++++++
\r
75 > 1 files changed, 28 insertions(+), 0 deletions(-)
\r