1 Return-Path: <tomi.ollila@iki.fi>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 9081C431FAF
\r
6 for <notmuch@notmuchmail.org>; Wed, 2 May 2012 12:09:05 -0700 (PDT)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id 4Dt8bDhfM6Iq for <notmuch@notmuchmail.org>;
\r
16 Wed, 2 May 2012 12:09:04 -0700 (PDT)
\r
17 Received: from guru.guru-group.fi (guru-group.fi [87.108.86.66])
\r
18 by olra.theworths.org (Postfix) with ESMTP id 1F204431FAE
\r
19 for <notmuch@notmuchmail.org>; Wed, 2 May 2012 12:09:04 -0700 (PDT)
\r
20 Received: by guru.guru-group.fi (Postfix, from userid 501)
\r
21 id 61BE068057; Wed, 2 May 2012 22:08:54 +0300 (EEST)
\r
22 From: Tomi Ollila <tomi.ollila@iki.fi>
\r
23 To: Austin Clements <amdragon@MIT.EDU>, notmuch@notmuchmail.org
\r
24 Subject: Re: [PATCH v2 0/6] Make notmuch_database_{open,
\r
25 create} return status codes
\r
26 In-Reply-To: <1335803138-24024-1-git-send-email-amdragon@mit.edu>
\r
27 References: <1335651473-19652-1-git-send-email-amdragon@mit.edu>
\r
28 <1335803138-24024-1-git-send-email-amdragon@mit.edu>
\r
29 User-Agent: Notmuch/0.12+160~g9c17781 (http://notmuchmail.org) Emacs/23.3.1
\r
30 (x86_64-unknown-linux-gnu)
\r
31 X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL
\r
32 $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F
\r
33 !)g;OY^,BjTbr)Np:%c_o'jj,Z
\r
34 Date: Wed, 02 May 2012 22:08:54 +0300
\r
35 Message-ID: <m2ipge9z95.fsf@guru.guru-group.fi>
\r
37 Content-Type: text/plain; charset=us-ascii
\r
38 X-BeenThere: notmuch@notmuchmail.org
\r
39 X-Mailman-Version: 2.1.13
\r
41 List-Id: "Use and development of the notmuch mail system."
\r
42 <notmuch.notmuchmail.org>
\r
43 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
44 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
45 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
46 List-Post: <mailto:notmuch@notmuchmail.org>
\r
47 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
48 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
49 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
50 X-List-Received-Date: Wed, 02 May 2012 19:09:05 -0000
\r
52 On Mon, Apr 30 2012, Austin Clements <amdragon@MIT.EDU> wrote:
\r
54 > Relative to v1, this makes notmuch_database_open and
\r
55 > notmuch_database_create gracefully handle a NULL out-argument and adds
\r
56 > documentation of the possible error return values from these two
\r
57 > functions. Patches 3 and on have not changed.
\r
61 One question though:
\r
63 In bindings/python/notmuch/database.py class Database functions
\r
64 create() and open() have the following last lines:
\r
66 + if status != STATUS.SUCCESS:
\r
67 + raise NotmuchError(status)
\r
71 What is the point returning 'status' in the only case the
\r
72 value is STATUS.SUCCESS -- is some caller interested on this ?
\r