1 Return-Path: <dkg@fifthhorseman.net>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by arlo.cworth.org (Postfix) with ESMTP id 0C8D46DE1104
\r
6 for <notmuch@notmuchmail.org>; Wed, 10 Feb 2016 08:37:56 -0800 (PST)
\r
7 X-Virus-Scanned: Debian amavisd-new at cworth.org
\r
11 X-Spam-Status: No, score=-0.018 tagged_above=-999 required=5
\r
12 tests=[AWL=-0.018] autolearn=disabled
\r
13 Received: from arlo.cworth.org ([127.0.0.1])
\r
14 by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id HJ_2yq-Cclcd for <notmuch@notmuchmail.org>;
\r
16 Wed, 10 Feb 2016 08:37:54 -0800 (PST)
\r
17 Received: from che.mayfirst.org (che.mayfirst.org [209.234.253.108])
\r
18 by arlo.cworth.org (Postfix) with ESMTP id 6A2AB6DE0BF6
\r
19 for <notmuch@notmuchmail.org>; Wed, 10 Feb 2016 08:37:54 -0800 (PST)
\r
20 Received: from fifthhorseman.net (unknown [38.109.115.130])
\r
21 by che.mayfirst.org (Postfix) with ESMTPSA id 71100F997;
\r
22 Wed, 10 Feb 2016 11:37:51 -0500 (EST)
\r
23 Received: by fifthhorseman.net (Postfix, from userid 1000)
\r
24 id E15F71FF3A; Wed, 10 Feb 2016 11:37:52 -0500 (EST)
\r
25 From: Daniel Kahn Gillmor <dkg@fifthhorseman.net>
\r
26 To: David Bremner <david@tethera.net>, Notmuch Mail <notmuch@notmuchmail.org>
\r
27 Subject: Re: [PATCH v3 05/16] Use a blank _notmuch_crypto to choose the
\r
29 In-Reply-To: <87oabovl7h.fsf@maritornes.cs.unb.ca>
\r
30 References: <1454272801-23623-1-git-send-email-dkg@fifthhorseman.net>
\r
31 <1454272801-23623-6-git-send-email-dkg@fifthhorseman.net>
\r
32 <87oabovl7h.fsf@maritornes.cs.unb.ca>
\r
33 User-Agent: Notmuch/0.21+72~gd8c4f1c (http://notmuchmail.org) Emacs/24.5.1
\r
34 (x86_64-pc-linux-gnu)
\r
35 Date: Wed, 10 Feb 2016 11:37:52 -0500
\r
36 Message-ID: <877fico71b.fsf@alice.fifthhorseman.net>
\r
38 Content-Type: text/plain
\r
39 X-BeenThere: notmuch@notmuchmail.org
\r
40 X-Mailman-Version: 2.1.20
\r
42 List-Id: "Use and development of the notmuch mail system."
\r
43 <notmuch.notmuchmail.org>
\r
44 List-Unsubscribe: <https://notmuchmail.org/mailman/options/notmuch>,
\r
45 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
46 List-Archive: <http://notmuchmail.org/pipermail/notmuch/>
\r
47 List-Post: <mailto:notmuch@notmuchmail.org>
\r
48 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
49 List-Subscribe: <https://notmuchmail.org/mailman/listinfo/notmuch>,
\r
50 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
51 X-List-Received-Date: Wed, 10 Feb 2016 16:37:56 -0000
\r
53 On Wed 2016-02-10 06:49:54 -0500, David Bremner wrote:
\r
54 > Daniel Kahn Gillmor <dkg@fifthhorseman.net> writes:
\r
56 >> This way we're only choosing a default in one place.
\r
58 >> notmuch-config.c | 3 ++-
\r
59 >> 1 file changed, 2 insertions(+), 1 deletion(-)
\r
61 >> diff --git a/notmuch-config.c b/notmuch-config.c
\r
62 >> index d252bb2..7cd19a7 100644
\r
63 >> --- a/notmuch-config.c
\r
64 >> +++ b/notmuch-config.c
\r
65 >> @@ -418,7 +418,8 @@ notmuch_config_open (void *ctx,
\r
68 >> if (notmuch_config_get_crypto_gpg_path (config) == NULL) {
\r
69 >> - notmuch_config_set_crypto_gpg_path (config, "gpg");
\r
70 >> + _notmuch_crypto_t crypto = { .gpg_path = NULL };
\r
71 >> + notmuch_config_set_crypto_gpg_path (config, _notmuch_crypto_get_gpg_path (&crypto));
\r
74 > I'm not sure if it's worth it, but this particular usage would be
\r
75 > cleaner if _notmuch_crypto_get_path allowed a NULL argument.
\r
77 Agreed; this change will be in my v4 series.
\r