1 Return-Path: <amdragon@gmail.com>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 9219E429E2A
\r
6 for <notmuch@notmuchmail.org>; Mon, 27 Jun 2011 13:43:37 -0700 (PDT)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=-0.699 tagged_above=-999 required=5
\r
12 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, FREEMAIL_FROM=0.001,
\r
13 RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled
\r
14 Received: from olra.theworths.org ([127.0.0.1])
\r
15 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
16 with ESMTP id 6Ci6j-Ga6fAV for <notmuch@notmuchmail.org>;
\r
17 Mon, 27 Jun 2011 13:43:37 -0700 (PDT)
\r
18 Received: from mail-qy0-f174.google.com (mail-qy0-f174.google.com
\r
19 [209.85.216.174]) (using TLSv1 with cipher RC4-SHA (128/128 bits))
\r
20 (No client certificate requested)
\r
21 by olra.theworths.org (Postfix) with ESMTPS id 17D23431FD0
\r
22 for <notmuch@notmuchmail.org>; Mon, 27 Jun 2011 13:43:37 -0700 (PDT)
\r
23 Received: by qyk29 with SMTP id 29so1801288qyk.5
\r
24 for <notmuch@notmuchmail.org>; Mon, 27 Jun 2011 13:43:36 -0700 (PDT)
\r
25 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma;
\r
26 h=mime-version:sender:in-reply-to:references:date
\r
27 :x-google-sender-auth:message-id:subject:from:to:cc:content-type
\r
28 :content-transfer-encoding;
\r
29 bh=+OxYrq7szWM7d4/DjmmD8km3fu08VlBqJg65vUw+5TQ=;
\r
30 b=A3fzITVPNPBcdc28XjvtvptAXDH/b7rdXOUsi/j+g15Ah+0Nriem0Sss/WsXDeTPOZ
\r
31 QZDhn+ffVZake1EZYkmYubu+SLFcn4fZu4Mj1xC/0IM6r/ysrZ/JgnG3uh7glLMc6OaW
\r
32 umna4x0TogqQox+Vo1UsQ6p/lVMzAg+eT/qB8=
\r
34 Received: by 10.229.126.229 with SMTP id d37mr3021868qcs.24.1309207416186;
\r
35 Mon, 27 Jun 2011 13:43:36 -0700 (PDT)
\r
36 Sender: amdragon@gmail.com
\r
37 Received: by 10.229.32.197 with HTTP; Mon, 27 Jun 2011 13:43:36 -0700 (PDT)
\r
38 In-Reply-To: <87mxh319un.fsf@servo.factory.finestructure.net>
\r
39 References: <1307032735-27427-1-git-send-email-jrollins@finestructure.net>
\r
40 <1307120466-4980-1-git-send-email-jrollins@finestructure.net>
\r
41 <87wrgccedd.fsf@yoom.home.cworth.org>
\r
42 <87mxh319un.fsf@servo.factory.finestructure.net>
\r
43 Date: Mon, 27 Jun 2011 16:43:36 -0400
\r
44 X-Google-Sender-Auth: MTVgaHzDWG94p1XM12d9DzM1PR0
\r
45 Message-ID: <BANLkTik8v7uZDcO4wV1Ve1Lymd03Z-WWdw@mail.gmail.com>
\r
46 Subject: Re: [PATCH] Do not attept to output part raw if part is not
\r
48 From: Austin Clements <amdragon@mit.edu>
\r
49 To: Jameson Graef Rollins <jrollins@finestructure.net>
\r
50 Content-Type: text/plain; charset=ISO-8859-1
\r
51 Content-Transfer-Encoding: quoted-printable
\r
52 Cc: Notmuch Mail <notmuch@notmuchmail.org>
\r
53 X-BeenThere: notmuch@notmuchmail.org
\r
54 X-Mailman-Version: 2.1.13
\r
56 List-Id: "Use and development of the notmuch mail system."
\r
57 <notmuch.notmuchmail.org>
\r
58 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
59 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
60 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
61 List-Post: <mailto:notmuch@notmuchmail.org>
\r
62 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
63 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
64 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
65 X-List-Received-Date: Mon, 27 Jun 2011 20:43:37 -0000
\r
67 On Mon, Jun 27, 2011 at 1:07 PM, Jameson Graef Rollins
\r
68 <jrollins@finestructure.net> wrote:
\r
69 > On Thu, 23 Jun 2011 16:33:18 -0700, Carl Worth <cworth@cworth.org> wrote:
\r
70 >> I'd like to investigate this case a little bit to help answer the
\r
71 >> question of whether "notmuch should have done anything in this case".
\r
73 > Hi, Carl. =A0You can see this error if you try to output raw a multipart/=
\r
75 > or message/rfc822 part, ie:
\r
77 > servo:~ 0$ notmuch show --part=3D1 --format=3Draw id:"87wrgccedd.fsf@yoom=
\r
78 .home.cworth.org" >/dev/null
\r
80 > (process:29838): GLib-GObject-WARNING **: invalid cast from `GMimeMultipa=
\r
81 rtSigned' to `GMimePart'
\r
83 > (process:29838): gmime-CRITICAL **: g_mime_part_get_content_object: asser=
\r
84 tion `GMIME_IS_PART (mime_part)' failed
\r
87 > Gmime seems to be successfully casting the part into GMimePart and then
\r
88 > outputting the content, but it does produce the warning on stderr.
\r
90 Just to clarify my understanding, --format=3Draw is only intended to
\r
91 work on either the whole message (special-cased in do_show_single) or
\r
92 a leaf MIME part, and in any other case, it will output nothing? The
\r
93 raw output test cases seem pretty thin.
\r
95 (BTW, I believe the show restructuring I have under way should both
\r
96 lift this restriction and eliminate the special case.)
\r