1 Return-Path: <markwalters1009@gmail.com>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 2B02A431FBD
\r
6 for <notmuch@notmuchmail.org>; Sat, 12 Apr 2014 01:40:46 -0700 (PDT)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=0.201 tagged_above=-999 required=5
\r
12 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1,
\r
13 FREEMAIL_ENVFROM_END_DIGIT=1, FREEMAIL_FROM=0.001,
\r
14 RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled
\r
15 Received: from olra.theworths.org ([127.0.0.1])
\r
16 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
17 with ESMTP id mWOYk2VxsNXZ for <notmuch@notmuchmail.org>;
\r
18 Sat, 12 Apr 2014 01:40:40 -0700 (PDT)
\r
19 Received: from mail-wi0-f173.google.com (mail-wi0-f173.google.com
\r
20 [209.85.212.173]) (using TLSv1 with cipher RC4-SHA (128/128 bits))
\r
21 (No client certificate requested)
\r
22 by olra.theworths.org (Postfix) with ESMTPS id 974CF431FAF
\r
23 for <notmuch@notmuchmail.org>; Sat, 12 Apr 2014 01:40:40 -0700 (PDT)
\r
24 Received: by mail-wi0-f173.google.com with SMTP id z2so2075243wiv.0
\r
25 for <notmuch@notmuchmail.org>; Sat, 12 Apr 2014 01:40:38 -0700 (PDT)
\r
26 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
\r
27 h=from:to:cc:subject:date:message-id;
\r
28 bh=AkElRQbBDAy1Qwg2hEIgzfa0UMbDyUCCogNsw/5J2i4=;
\r
29 b=VCare2nvnErCzj01s+oe6rnK95hJCnsqnxU2BtPJilpSImpnth8aCBjcq4ZRVectC6
\r
30 2ZjOo4I7kVvPzpxW6uftcKURd6xrRjv1bksmhzGJ7ClhpXSlWSSHMvxCCL0ZAPG0TY/3
\r
31 rZNS0DpanW+Jlc6hhZa8lr633xS3Yw+Lk+1NPFa1zDfQNpHAQ6s05dgGvUZuM7v4yYg3
\r
32 sqGe7XEVZD+twiCHVgFyMJ0y2oU45FmqepDgBeVTtOxew6RrVoEdxYvXe3VDNWMtI8ev
\r
33 00Lv3bTFJHBWhiGsjjxu8gG7aMiu+q6hGarNjTLOwa28a2nC/zLdgp2E8wUyT55JxKAj
\r
35 X-Received: by 10.180.24.134 with SMTP id u6mr1700156wif.41.1397292037857;
\r
36 Sat, 12 Apr 2014 01:40:37 -0700 (PDT)
\r
37 Received: from localhost (5751dfa2.skybroadband.com. [87.81.223.162])
\r
38 by mx.google.com with ESMTPSA id hu7sm9367633wib.10.2014.04.12.01.40.36
\r
39 for <multiple recipients>
\r
40 (version=TLSv1.2 cipher=RC4-SHA bits=128/128);
\r
41 Sat, 12 Apr 2014 01:40:37 -0700 (PDT)
\r
42 From: Mark Walters <markwalters1009@gmail.com>
\r
43 To: notmuch@notmuchmail.org
\r
44 Subject: [PATCH 1/2] emacs: hello: bugfix: make alphabetically sorted saved
\r
46 Date: Sat, 12 Apr 2014 09:40:32 +0100
\r
47 Message-Id: <1397292033-26502-1-git-send-email-markwalters1009@gmail.com>
\r
48 X-Mailer: git-send-email 1.7.10.4
\r
49 X-BeenThere: notmuch@notmuchmail.org
\r
50 X-Mailman-Version: 2.1.13
\r
52 List-Id: "Use and development of the notmuch mail system."
\r
53 <notmuch.notmuchmail.org>
\r
54 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
55 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
56 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
57 List-Post: <mailto:notmuch@notmuchmail.org>
\r
58 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
59 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
60 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
61 X-List-Received-Date: Sat, 12 Apr 2014 08:40:46 -0000
\r
63 My recent changes to the saved search format broke the alphabetically
\r
64 sorted saved sort option. This makes it work again.
\r
66 Also, since the saved-search list is no longer an alist change the
\r
67 names in the sort function to avoid confusion.
\r
69 Thanks to Jani for pointing out the bug.
\r
75 emacs/notmuch-hello.el | 9 ++++++---
\r
76 1 file changed, 6 insertions(+), 3 deletions(-)
\r
78 diff --git a/emacs/notmuch-hello.el b/emacs/notmuch-hello.el
\r
79 index 4900a24..fca2bcc 100644
\r
80 --- a/emacs/notmuch-hello.el
\r
81 +++ b/emacs/notmuch-hello.el
\r
82 @@ -39,9 +39,12 @@ (defcustom notmuch-show-empty-saved-searches nil
\r
84 :group 'notmuch-hello)
\r
86 -(defun notmuch-sort-saved-searches (alist)
\r
87 - "Generate an alphabetically sorted saved searches alist."
\r
88 - (sort (copy-sequence alist) (lambda (a b) (string< (car a) (car b)))))
\r
89 +(defun notmuch-sort-saved-searches (saved-searches)
\r
90 + "Generate an alphabetically sorted saved searches list."
\r
91 + (sort (copy-sequence saved-searches)
\r
93 + (string< (notmuch-saved-search-get a :name)
\r
94 + (notmuch-saved-search-get b :name)))))
\r
96 (defcustom notmuch-saved-search-sort-function nil
\r
97 "Function used to sort the saved searches for the notmuch-hello view.
\r