1 Return-Path: <tomi.ollila@iki.fi>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 2CC20431FBD
\r
6 for <notmuch@notmuchmail.org>; Mon, 14 Apr 2014 11:00:32 -0700 (PDT)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id 1KgxvM3taj5T for <notmuch@notmuchmail.org>;
\r
16 Mon, 14 Apr 2014 11:00:24 -0700 (PDT)
\r
17 Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])
\r
18 by olra.theworths.org (Postfix) with ESMTP id B0E4C431FBC
\r
19 for <notmuch@notmuchmail.org>; Mon, 14 Apr 2014 11:00:23 -0700 (PDT)
\r
20 Received: from guru.guru-group.fi (localhost [IPv6:::1])
\r
21 by guru.guru-group.fi (Postfix) with ESMTP id E14BE10008F;
\r
22 Mon, 14 Apr 2014 21:00:15 +0300 (EEST)
\r
23 From: Tomi Ollila <tomi.ollila@iki.fi>
\r
24 To: "W. Trevor King" <wking@tremily.us>, notmuch@notmuchmail.org
\r
25 Subject: Re: [PATCH 0/7] doc: Python 3 compat, rst2man.py support, etc.
\r
26 In-Reply-To: <cover.1396718720.git.wking@tremily.us>
\r
27 References: <cover.1396718720.git.wking@tremily.us>
\r
28 User-Agent: Notmuch/0.17+200~g5c6d42d (http://notmuchmail.org) Emacs/24.3.1
\r
29 (x86_64-unknown-linux-gnu)
\r
30 X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL
\r
31 $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F
\r
32 !)g;OY^,BjTbr)Np:%c_o'jj,Z
\r
33 Date: Mon, 14 Apr 2014 21:00:15 +0300
\r
34 Message-ID: <m2ppkjpz9s.fsf@guru.guru-group.fi>
\r
36 Content-Type: text/plain; charset=utf-8
\r
37 Content-Transfer-Encoding: quoted-printable
\r
38 X-BeenThere: notmuch@notmuchmail.org
\r
39 X-Mailman-Version: 2.1.13
\r
41 List-Id: "Use and development of the notmuch mail system."
\r
42 <notmuch.notmuchmail.org>
\r
43 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
44 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
45 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
46 List-Post: <mailto:notmuch@notmuchmail.org>
\r
47 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
48 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
49 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
50 X-List-Received-Date: Mon, 14 Apr 2014 18:00:32 -0000
\r
52 On Sat, Apr 05 2014, "W. Trevor King" <wking@tremily.us> wrote:
\r
54 > I just bumped into this today while testing v2 of my
\r
55 > content-description series:
\r
61 > python ./doc/mkdocdeps.py ./doc doc/_build doc/docdeps.mk
\r
62 > Traceback (most recent call last):
\r
63 > File "./doc/mkdocdeps.py", line 6, in <module>
\r
64 > execfile(srcdir + '/conf.py')
\r
65 > NameError: name 'execfile' is not defined
\r
68 > The first patch in this series fixes that issue, and the rest of the
\r
69 > series fixes some other issues I bumped into while working on that.
\r
70 > Sorry I missed these in the initial series.
\r
72 > Note that while mkdocdeps.py and prerst2man.py are now Python 3
\r
73 > compatible (with this series), the build will fail for Python's 3.0
\r
74 > through 3.2 because of the explicit unicode literals in conf.py [1].
\r
75 > It's likely that conf.py could use [2]
\r
77 > from __future__ import unicode_literals
\r
79 > drop the u'' prefixes, and be compatible with all Python's =E2=89=A52.6
\r
80 > (including all 3s). I haven't checked the logic though, and I'm not
\r
81 > running 3.2 locally anymore, so it's not a big priority for me.
\r
86 > [1]: https://docs.python.org/3/whatsnew/3.3.html#pep-414-explicit-unicode=
\r
88 > [2]: from __future__ import unicode_literals
\r
90 > W. Trevor King (7):
\r
91 > doc/mkdocdeps.py: Convert execfile to import
\r
92 > doc/mkdocdeps.py: Use "with" statement for the output file
\r
93 > doc/prerst2man.py: Use Python-3-compatible octal notation
\r
94 > doc/prerst2man.py: Fix 'os.system' -> 'system' typo
\r
95 > doc: Allow rst2man.py as an alternative to rst2man
\r
96 > doc/prerst2man.py: Convert execfile to import
\r
97 > doc/INSTALL: Remove rst2man reference and other updates
\r
99 In this series IMO the patches 1-4:
\r
101 id:8d518408f2da8bc96ae3123f05791142da26b9bc.1396718720.git.wking@tremily.us
\r
102 id:543aee63407956e60f85dc11a2d25855e98c10c3.1396718720.git.wking@tremily.us
\r
103 id:5e4509ab08699afe2681110fb35075e1d0bbdc7e.1396718720.git.wking@tremily.us
\r
104 id:c5ec510ac25c867ad600c475a0070a003440a4b8.1396718720.git.wking@tremily.us
\r
106 could go in as those are. 5:
\r
108 id:adce76bb9a0ca728d856da4ecaf6b282e22e7440.1396718720.git.wking@tremily.us
\r
110 if, for consistency reason (we don't use absolute paths with other commands
\r
111 either), rst2man/rst2man.py is used as is (and commit message adjusted
\r
116 id:7c43c614cb09665400544fc0928ac14bb67ceeb5.1396718720.git.wking@tremily.us
\r
118 would be good as is, but it doesn't apply without 5
\r
122 id:edf9a674bc1f41917caead8d38b5f09295a9d1bd.1396718720.git.wking@tremily.us
\r
124 In addition to David's comments, s/genric/generic/ ;D. I don't have opinion
\r
125 whether INSTALL should be changed to README.rst. Maybe this is good idea;
\r
126 that also distingush between ./INSTALL & doc/INSTALL. In this case=20
\r
127 `git grep INSTALL` shows that the line 83 in ./INSTALL needs to be changed,
\r
132 PS: this id:<hash>.<timestamp>.git.<user@host> is PITA format to work with =
\r
136 > configure | 12 +++++++-----
\r
137 > doc/INSTALL | 34 ++++++++++++++++++++--------------
\r
138 > doc/Makefile.local | 6 +++---
\r
139 > doc/mkdocdeps.py | 19 ++++++++++---------
\r
140 > doc/prerst2man.py | 25 ++++++++++++++-----------
\r
141 > 5 files changed, 54 insertions(+), 42 deletions(-)
\r
144 > 1.9.1.353.gc66d89d
\r