1 Return-Path: <dmitry.kurochkin@gmail.com>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id B4824429E25
\r
6 for <notmuch@notmuchmail.org>; Sun, 11 Dec 2011 02:42:27 -0800 (PST)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=-0.799 tagged_above=-999 required=5
\r
12 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1,
\r
13 FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled
\r
14 Received: from olra.theworths.org ([127.0.0.1])
\r
15 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
16 with ESMTP id tFtovxKmztNn for <notmuch@notmuchmail.org>;
\r
17 Sun, 11 Dec 2011 02:42:27 -0800 (PST)
\r
18 Received: from mail-bw0-f53.google.com (mail-bw0-f53.google.com
\r
19 [209.85.214.53]) (using TLSv1 with cipher RC4-SHA (128/128 bits))
\r
20 (No client certificate requested)
\r
21 by olra.theworths.org (Postfix) with ESMTPS id 29AC9431FB6
\r
22 for <notmuch@notmuchmail.org>; Sun, 11 Dec 2011 02:42:27 -0800 (PST)
\r
23 Received: by bkat8 with SMTP id t8so4710411bka.26
\r
24 for <notmuch@notmuchmail.org>; Sun, 11 Dec 2011 02:42:25 -0800 (PST)
\r
25 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma;
\r
26 h=from:to:subject:in-reply-to:references:user-agent:date:message-id
\r
27 :mime-version:content-type;
\r
28 bh=7dGtLrWIWYB+AU0jjpDC9NYts78JQTm5QqEi29gPO2g=;
\r
29 b=KfE+Bz7oY1fOt8EwK6pYcVTDIrwAqIDaIDApi9SeCAkVONa3oo+noEYrGWaO4tHKpE
\r
30 VWeyLR2yhoUM8Lyb6fR9j1QXKQT+9TDn/NsYAIX8rxv8gWy3JKFNdCAnsFPT1/UL/5s0
\r
31 U78ZHPtuUGVtKWld6taFnVRkABDsaS1KDzM7U=
\r
32 Received: by 10.204.9.218 with SMTP id m26mr154227bkm.44.1323600145913;
\r
33 Sun, 11 Dec 2011 02:42:25 -0800 (PST)
\r
34 Received: from localhost ([91.144.186.21])
\r
35 by mx.google.com with ESMTPS id l5sm22924351bkv.9.2011.12.11.02.42.24
\r
36 (version=TLSv1/SSLv3 cipher=OTHER);
\r
37 Sun, 11 Dec 2011 02:42:24 -0800 (PST)
\r
38 From: Dmitry Kurochkin <dmitry.kurochkin@gmail.com>
\r
39 To: Austin Clements <amdragon@MIT.EDU>, notmuch@notmuchmail.org
\r
40 Subject: Re: [PATCH v3 0/4] First step of 'show' rewrite
\r
41 In-Reply-To: <1323460468-4030-1-git-send-email-amdragon@mit.edu>
\r
42 References: <1323027100-10307-1-git-send-email-amdragon@mit.edu>
\r
43 <1323460468-4030-1-git-send-email-amdragon@mit.edu>
\r
44 User-Agent: Notmuch/0.10.2+82~g96a629c (http://notmuchmail.org) Emacs/23.3.1
\r
45 (x86_64-pc-linux-gnu)
\r
46 Date: Sun, 11 Dec 2011 14:41:50 +0400
\r
47 Message-ID: <87borf75ld.fsf@gmail.com>
\r
49 Content-Type: text/plain; charset=us-ascii
\r
50 X-BeenThere: notmuch@notmuchmail.org
\r
51 X-Mailman-Version: 2.1.13
\r
53 List-Id: "Use and development of the notmuch mail system."
\r
54 <notmuch.notmuchmail.org>
\r
55 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
56 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
57 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
58 List-Post: <mailto:notmuch@notmuchmail.org>
\r
59 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
60 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
61 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
62 X-List-Received-Date: Sun, 11 Dec 2011 10:42:27 -0000
\r
64 Austin, good job! :) Thanks for this work. (and continue, please :))
\r
66 Most comments in my review are minor and/or concern the old code
\r
67 (i.e. the new code does not make it worse). Please feel free to ignore
\r
70 I vote for pushing this series as soon as Austin finds it appropriate.
\r
71 If Austin makes a new version of this patch series with some of my
\r
72 comments fixed, it gets my auto-approve without another round of review :)
\r