1 Return-Path: <amdragon@mit.edu>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id E7ECE431FAF
\r
6 for <notmuch@notmuchmail.org>; Wed, 2 May 2012 17:23:56 -0700 (PDT)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5
\r
12 tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id fTAMlJCSxLMQ for <notmuch@notmuchmail.org>;
\r
16 Wed, 2 May 2012 17:23:55 -0700 (PDT)
\r
17 Received: from dmz-mailsec-scanner-7.mit.edu (DMZ-MAILSEC-SCANNER-7.MIT.EDU
\r
19 by olra.theworths.org (Postfix) with ESMTP id 79826431FAE
\r
20 for <notmuch@notmuchmail.org>; Wed, 2 May 2012 17:23:55 -0700 (PDT)
\r
21 X-AuditID: 12074424-b7fae6d000000906-6a-4fa1d01aa58e
\r
22 Received: from mailhub-auth-4.mit.edu ( [18.7.62.39])
\r
23 by dmz-mailsec-scanner-7.mit.edu (Symantec Messaging Gateway) with SMTP
\r
24 id CC.B2.02310.A10D1AF4; Wed, 2 May 2012 20:23:54 -0400 (EDT)
\r
25 Received: from outgoing.mit.edu (OUTGOING-AUTH.MIT.EDU [18.7.22.103])
\r
26 by mailhub-auth-4.mit.edu (8.13.8/8.9.2) with ESMTP id q430NriG027903;
\r
27 Wed, 2 May 2012 20:23:54 -0400
\r
28 Received: from awakening.csail.mit.edu (awakening.csail.mit.edu [18.26.4.91])
\r
29 (authenticated bits=0)
\r
30 (User authenticated as amdragon@ATHENA.MIT.EDU)
\r
31 by outgoing.mit.edu (8.13.6/8.12.4) with ESMTP id q430Npl6004860
\r
32 (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NOT);
\r
33 Wed, 2 May 2012 20:23:53 -0400 (EDT)
\r
34 Received: from amthrax by awakening.csail.mit.edu with local (Exim 4.77)
\r
35 (envelope-from <amdragon@mit.edu>)
\r
36 id 1SPjpn-0006wx-F5; Wed, 02 May 2012 20:23:51 -0400
\r
37 Date: Wed, 2 May 2012 20:23:51 -0400
\r
38 From: Austin Clements <amdragon@MIT.EDU>
\r
39 To: Tomi Ollila <tomi.ollila@iki.fi>
\r
40 Subject: Re: [PATCH v2 0/6] Make notmuch_database_{open, create} return
\r
42 Message-ID: <20120503002351.GZ2704@mit.edu>
\r
43 References: <1335651473-19652-1-git-send-email-amdragon@mit.edu>
\r
44 <1335803138-24024-1-git-send-email-amdragon@mit.edu>
\r
45 <m2ipge9z95.fsf@guru.guru-group.fi>
\r
47 Content-Type: text/plain; charset=us-ascii
\r
48 Content-Disposition: inline
\r
49 In-Reply-To: <m2ipge9z95.fsf@guru.guru-group.fi>
\r
50 User-Agent: Mutt/1.5.21 (2010-09-15)
\r
51 X-Brightmail-Tracker:
\r
52 H4sIAAAAAAAAA+NgFmpkleLIzCtJLcpLzFFi42IRYrdT15W6sNDf4PoUE4vrN2cyW7xZOY/V
\r
53 gcnj8NeFLB7PVt1iDmCK4rJJSc3JLEst0rdL4Mr4dPs+e8Ek9oo9XRYNjAdYuxg5OSQETCTa
\r
54 m/cwQthiEhfurWfrYuTiEBLYxygxd+YXdghnPaPE6VszmEGqhAROMEkceVUAkVjCKHF8wVqg
\r
55 URwcLAIqEttfuoHUsAloSGzbvxxsqghQ+EHberBtzALSEt9+NzOBlAsLhEkc3MIBEuYV0JZY
\r
56 9nsC1K65jBLNZ34yQyQEJU7OfMIC0aslcePfS7BekDnL/4H1cgoYSCy9tJcdxBYFWjXl5Da2
\r
57 CYxCs5B0z0LSPQuhewEj8ypG2ZTcKt3cxMyc4tRk3eLkxLy81CJdc73czBK91JTSTYzgkHZR
\r
58 2cHYfEjpEKMAB6MSDy9z1EJ/IdbEsuLK3EOMkhxMSqK8804AhfiS8lMqMxKLM+KLSnNSiw8x
\r
59 SnAwK4nwqrUB5XhTEiurUovyYVLSHCxK4rwaWu/8hATSE0tSs1NTC1KLYLIyHBxKErxl54Ea
\r
60 BYtS01Mr0jJzShDSTBycIMN5gIangtTwFhck5hZnpkPkTzEqSonzeoEkBEASGaV5cL2wlPOK
\r
61 URzoFWHedJAqHmC6gut+BTSYCWhwvvk8kMEliQgpqQZGozuxzsGN7513h/Uwmn9n+L6e+/Cu
\r
62 K63Tg0t2ndskv7bs2O3WBx99rG8arEsU0QwseJ11sYyNS+f0R443s3+6hkqyPfxq5nym0zNz
\r
63 zqz4tgk71U9t0nz/52mc3wMP2X82RZMlrI+Vyax4d+eM23ndAJ76n1c9519RU7x0WrShxmXH
\r
64 pkkLbhSUKbEUZyQaajEXFScCAJIz8gkUAwAA
\r
65 Cc: notmuch@notmuchmail.org
\r
66 X-BeenThere: notmuch@notmuchmail.org
\r
67 X-Mailman-Version: 2.1.13
\r
69 List-Id: "Use and development of the notmuch mail system."
\r
70 <notmuch.notmuchmail.org>
\r
71 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
72 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
73 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
74 List-Post: <mailto:notmuch@notmuchmail.org>
\r
75 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
76 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
77 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
78 X-List-Received-Date: Thu, 03 May 2012 00:23:57 -0000
\r
80 Quoth Tomi Ollila on May 02 at 10:08 pm:
\r
81 > On Mon, Apr 30 2012, Austin Clements <amdragon@MIT.EDU> wrote:
\r
83 > > Relative to v1, this makes notmuch_database_open and
\r
84 > > notmuch_database_create gracefully handle a NULL out-argument and adds
\r
85 > > documentation of the possible error return values from these two
\r
86 > > functions. Patches 3 and on have not changed.
\r
90 > One question though:
\r
92 > In bindings/python/notmuch/database.py class Database functions
\r
93 > create() and open() have the following last lines:
\r
95 > + if status != STATUS.SUCCESS:
\r
96 > + raise NotmuchError(status)
\r
100 > What is the point returning 'status' in the only case the
\r
101 > value is STATUS.SUCCESS -- is some caller interested on this ?
\r
103 This was for consistency with other methods (e.g., begin_atomic also
\r
104 only ever returns STATUS.SUCCESS).
\r