1 Return-Path: <david@tethera.net>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 1EE6A431FC3
\r
6 for <notmuch@notmuchmail.org>; Sun, 5 Oct 2014 01:56:59 -0700 (PDT)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id 1lic-FtOHtVp for <notmuch@notmuchmail.org>;
\r
16 Sun, 5 Oct 2014 01:56:55 -0700 (PDT)
\r
17 Received: from yantan.tethera.net (yantan.tethera.net [199.188.72.155])
\r
18 (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits))
\r
19 (No client certificate requested)
\r
20 by olra.theworths.org (Postfix) with ESMTPS id AEB78431FB6
\r
21 for <notmuch@notmuchmail.org>; Sun, 5 Oct 2014 01:56:55 -0700 (PDT)
\r
22 Received: from remotemail by yantan.tethera.net with local (Exim 4.80)
\r
23 (envelope-from <david@tethera.net>)
\r
24 id 1Xahcc-0007mr-UE; Sun, 05 Oct 2014 05:56:54 -0300
\r
25 Received: (nullmailer pid 14365 invoked by uid 1000); Sun, 05 Oct 2014
\r
27 From: David Bremner <david@tethera.net>
\r
28 To: Austin Clements <aclements@csail.mit.edu>, notmuch@notmuchmail.org
\r
29 Subject: Re: [PATCH 08/11] lib: Implement upgrade to ghost messages feature
\r
30 In-Reply-To: <1412345958-8278-9-git-send-email-aclements@csail.mit.edu>
\r
31 References: <1412345958-8278-1-git-send-email-aclements@csail.mit.edu>
\r
32 <1412345958-8278-9-git-send-email-aclements@csail.mit.edu>
\r
33 User-Agent: Notmuch/0.18.1+98~gae27403 (http://notmuchmail.org) Emacs/24.3.1
\r
34 (x86_64-pc-linux-gnu)
\r
35 Date: Sun, 05 Oct 2014 10:56:44 +0200
\r
36 Message-ID: <87d2a6q4hf.fsf@maritornes.cs.unb.ca>
\r
38 Content-Type: text/plain
\r
39 X-BeenThere: notmuch@notmuchmail.org
\r
40 X-Mailman-Version: 2.1.13
\r
42 List-Id: "Use and development of the notmuch mail system."
\r
43 <notmuch.notmuchmail.org>
\r
44 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
45 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
46 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
47 List-Post: <mailto:notmuch@notmuchmail.org>
\r
48 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
49 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
50 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
51 X-List-Received-Date: Sun, 05 Oct 2014 08:56:59 -0000
\r
53 Austin Clements <aclements@csail.mit.edu> writes:
\r
54 > + if (new_features & NOTMUCH_FEATURE_GHOSTS) {
\r
55 > + t_end = db->metadata_keys_end ("thread_id_");
\r
56 > + for (t = db->metadata_keys_begin ("thread_id_"); t != t_end; ++t)
\r
60 It would be nice to have the comment below, or something like it, for
\r
63 > + /* Perform metadata upgrades. */
\r
65 > + /* Prior to NOTMUCH_FEATURE_GHOSTS, thread IDs for missing
\r
66 > + * messages were stored as database metadata. Change these to
\r
67 > + * ghost messages.
\r