1 Return-Path: <amdragon@mit.edu>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id B0043431FC2
\r
6 for <notmuch@notmuchmail.org>; Mon, 19 Nov 2012 20:23:07 -0800 (PST)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5
\r
12 tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id xBPdyXcsnujQ for <notmuch@notmuchmail.org>;
\r
16 Mon, 19 Nov 2012 20:23:07 -0800 (PST)
\r
17 Received: from dmz-mailsec-scanner-5.mit.edu (DMZ-MAILSEC-SCANNER-5.MIT.EDU
\r
19 by olra.theworths.org (Postfix) with ESMTP id 0F2D4431FBC
\r
20 for <notmuch@notmuchmail.org>; Mon, 19 Nov 2012 20:23:06 -0800 (PST)
\r
21 X-AuditID: 12074422-b7f746d0000008cc-d7-50ab05aa1947
\r
22 Received: from mailhub-auth-2.mit.edu ( [18.7.62.36])
\r
23 by dmz-mailsec-scanner-5.mit.edu (Symantec Messaging Gateway) with SMTP
\r
24 id 0D.6D.02252.AA50BA05; Mon, 19 Nov 2012 23:23:06 -0500 (EST)
\r
25 Received: from outgoing.mit.edu (OUTGOING-AUTH.MIT.EDU [18.7.22.103])
\r
26 by mailhub-auth-2.mit.edu (8.13.8/8.9.2) with ESMTP id qAK4N5iQ005671;
\r
27 Mon, 19 Nov 2012 23:23:06 -0500
\r
28 Received: from awakening.csail.mit.edu (awakening.csail.mit.edu [18.26.4.91])
\r
29 (authenticated bits=0)
\r
30 (User authenticated as amdragon@ATHENA.MIT.EDU)
\r
31 by outgoing.mit.edu (8.13.6/8.12.4) with ESMTP id qAK4N2oH024486
\r
32 (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NOT);
\r
33 Mon, 19 Nov 2012 23:23:04 -0500 (EST)
\r
34 Received: from amthrax by awakening.csail.mit.edu with local (Exim 4.77)
\r
35 (envelope-from <amdragon@mit.edu>)
\r
36 id 1TafMU-0008Qf-NN; Mon, 19 Nov 2012 23:23:02 -0500
\r
37 Date: Mon, 19 Nov 2012 23:23:02 -0500
\r
38 From: Austin Clements <amdragon@MIT.EDU>
\r
39 To: Ethan Glasser-Camp <ethan.glasser.camp@gmail.com>
\r
40 Subject: Re: [PATCH v2] emacs: display tags in notmuch-show with links
\r
41 Message-ID: <20121120042302.GF22284@mit.edu>
\r
42 References: <1353266322-20318-1-git-send-email-damien.cassou@gmail.com>
\r
43 <87ip921pqu.fsf@betacantrips.com>
\r
45 Content-Type: text/plain; charset=us-ascii
\r
46 Content-Disposition: inline
\r
47 In-Reply-To: <87ip921pqu.fsf@betacantrips.com>
\r
48 User-Agent: Mutt/1.5.21 (2010-09-15)
\r
49 X-Brightmail-Tracker:
\r
50 H4sIAAAAAAAAA+NgFmpnleLIzCtJLcpLzFFi42IRYrdT0V3FujrAYPodKYtdd7cyWdzp2cVi
\r
51 cf3mTGYHZo+ds+6yezxbdYs5gCmKyyYlNSezLLVI3y6BK+P9AZmCA4IVh9fOZ2xgfMHbxcjJ
\r
52 ISFgIrHoZDsjhC0mceHeerYuRi4OIYF9jBJH165kgnA2MEocaDrFCOGcZJI48/ctK4SzhFGi
\r
53 afVaVpB+FgFViZ3tC8FmsQloSGzbvxzI5uAQETCV+HtQHSTMLJAisbJjJzOILSzgJrHo5TEW
\r
54 EJtXQEdi1YTrYGOEBLIlru3tY4OIC0qcnPmEBaJXS+LGv5dMICOZBaQllv/jAAlzCuhJnJy6
\r
55 HKxcVEBFYsrJbWwTGIVmIemehaR7FkL3AkbmVYyyKblVurmJmTnFqcm6xcmJeXmpRbqmermZ
\r
56 JXqpKaWbGMHh7aK0g/HnQaVDjAIcjEo8vA8SVgUIsSaWFVfmHmKU5GBSEuXt/wUU4kvKT6nM
\r
57 SCzOiC8qzUktPsQowcGsJMLbVA6U401JrKxKLcqHSUlzsCiJ815LuekvJJCeWJKanZpakFoE
\r
58 k5Xh4FCS4D3IsjpASLAoNT21Ii0zpwQhzcTBCTKcB2j4RZAa3uKCxNzizHSI/ClGRSlx3icg
\r
59 CQGQREZpHlwvLP28YhQHekWY9wBIFQ8wdcF1vwIazAQ0+FrAcpDBJYkIKakGxlmHFxhXW6nm
\r
60 zPs9wV3v1pIgv3JrZzcGdYUIjzUK05codb938mg4eKRuU+7HXOnSG1UhPx4kSu5f1tgQ+Vjm
\r
61 eoTpnJs26bl65ceP9Gee/alQv1xy2WTrFw+0dojtXej0ccWD3c8OTC/ckhWg8ujBJZ/uN6kv
\r
62 tY2CP8p38Kxf9NyaP+esu+reb0osxRmJhlrMRcWJACqkikgaAwAA
\r
63 Cc: notmuch mailing list <notmuch@notmuchmail.org>
\r
64 X-BeenThere: notmuch@notmuchmail.org
\r
65 X-Mailman-Version: 2.1.13
\r
67 List-Id: "Use and development of the notmuch mail system."
\r
68 <notmuch.notmuchmail.org>
\r
69 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
70 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
71 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
72 List-Post: <mailto:notmuch@notmuchmail.org>
\r
73 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
74 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
75 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
76 X-List-Received-Date: Tue, 20 Nov 2012 04:23:07 -0000
\r
78 Quoth Ethan Glasser-Camp on Nov 18 at 5:59 pm:
\r
79 > Damien Cassou <damien.cassou@gmail.com> writes:
\r
81 > > This patch obsoletes
\r
82 > > id:1352565719-12397-1-git-send-email-damien.cassou@gmail.com
\r
84 > > [PATCH 1/4] emacs: Add a thread's tags to emacs header-line
\r
85 > > [PATCH 2/4] emacs: Make tags in header-line clickable
\r
86 > > [PATCH 3/4] emacs: Make tags that appear in `notmuch-show' clickable
\r
87 > > [PATCH 4/4] emacs: Add unit-tests for clickable tags in notmuch-show
\r
89 > > This patch makes clickable all tags that appear in notmuch-show
\r
90 > > buffers. Each tag is a link to open a new notmuch-search buffer for
\r
91 > > this tag. Additionally, the buffer's header-line now shows the
\r
92 > > thread's tags (clickable only if the `header-button' library is loaded
\r
95 > Looks fine to me. Let me just get the notes from my bikeshed, in case
\r
96 > you get asked to roll another version :)
\r
98 > - You might want to use #' on lambdas.
\r
100 > - It bothers me how similar notmuch-tagger-{body,header}-button-action
\r
101 > are. I thought it might be better to unify them by seeing what type
\r
102 > the button argument was. Here's my (untested) approach which you might
\r
103 > find prettier or uglier.
\r
105 > (notmuch-tagger-all-button-get (button attrib)
\r
106 > "Utility function to do button-get on different kinds of buttons."
\r
108 > ((integer-or-marker-p button)
\r
109 > (button-get button attrib))
\r
110 > ((and (featurep 'header-button)
\r
112 > (header-button-get button attrib))
\r
113 > (t (error "unknown type of button %s" button))
\r
115 This seems like overkill given that all of the common code in
\r
116 notmuch-tagger-{body,header}-button-action is already abstracted into
\r
117 a common function. Were there other places where code was duplicated
\r
118 because of the difference between regular buttons and header buttons?
\r
120 > - The comment for notmuch-tagger-make-body-link reads that it will work
\r
121 > "everywhere except in the header-line". Does this mean mode-line, menu
\r
122 > bar, or what? How about just "won't work in the header-line"?
\r
126 > +If tags the result of this function is to be used within the
\r
128 > I think this should just read "If the result".
\r