04/34ea729c8f595f179257873ecf35122140319f

   1 Return-Path: <aclements@csail.mit.edu>\r
   2 X-Original-To: notmuch@notmuchmail.org\r
   3 Delivered-To: notmuch@notmuchmail.org\r
   4 Received: from localhost (localhost [127.0.0.1])\r
   5         by olra.theworths.org (Postfix) with ESMTP id 2BFCF431FDC\r
   6         for <notmuch@notmuchmail.org>; Fri,  3 Oct 2014 07:20:16 -0700 (PDT)\r
   7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
   8 X-Spam-Flag: NO\r
   9 X-Spam-Score: -2.3\r
  10 X-Spam-Level: \r
  11 X-Spam-Status: No, score=-2.3 tagged_above=-999 required=5\r
  12         tests=[RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled\r
  13 Received: from olra.theworths.org ([127.0.0.1])\r
  14         by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
  15         with ESMTP id cqXcrULdslkl for <notmuch@notmuchmail.org>;\r
  16         Fri,  3 Oct 2014 07:20:08 -0700 (PDT)\r
  17 Received: from dmz-mailsec-scanner-3.mit.edu (dmz-mailsec-scanner-3.mit.edu\r
  18         [18.9.25.14])\r
  19         (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))\r
  20         (No client certificate requested)\r
  21         by olra.theworths.org (Postfix) with ESMTPS id 10E60431FDD\r
  22         for <notmuch@notmuchmail.org>; Fri,  3 Oct 2014 07:19:35 -0700 (PDT)\r
  23 X-AuditID: 1209190e-f79d46d000003643-30-542eb076825d\r
  24 Received: from mailhub-auth-3.mit.edu ( [18.9.21.43])\r
  25         (using TLS with cipher AES256-SHA (256/256 bits))\r
  26         (Client did not present a certificate)\r
  27         by dmz-mailsec-scanner-3.mit.edu (Symantec Messaging Gateway) with SMTP\r
  28         id B2.C6.13891.670BE245; Fri,  3 Oct 2014 10:19:34 -0400 (EDT)\r
  29 Received: from outgoing.mit.edu (outgoing-auth-1.mit.edu [18.9.28.11])\r
  30         by mailhub-auth-3.mit.edu (8.13.8/8.9.2) with ESMTP id s93EJNM9018547; \r
  31         Fri, 3 Oct 2014 10:19:24 -0400\r
  32 Received: from drake.dyndns.org\r
  33         (216-15-114-40.c3-0.arl-ubr1.sbo-arl.ma.cable.rcn.com\r
  34         [216.15.114.40]) (authenticated bits=0)\r
  35         (User authenticated as amdragon@ATHENA.MIT.EDU)\r
  36         by outgoing.mit.edu (8.13.8/8.12.4) with ESMTP id s93EJLxD023310\r
  37         (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NOT);\r
  38         Fri, 3 Oct 2014 10:19:23 -0400\r
  39 Received: from amthrax by drake.dyndns.org with local (Exim 4.84)\r
  40         (envelope-from <aclements@csail.mit.edu>)\r
  41         id 1Xa3hZ-0002Jh-2r; Fri, 03 Oct 2014 10:19:21 -0400\r
  42 From: Austin Clements <aclements@csail.mit.edu>\r
  43 To: notmuch@notmuchmail.org\r
  44 Subject: [PATCH 03/11] lib: Handle empty date value\r
  45 Date: Fri,  3 Oct 2014 10:19:10 -0400\r
  46 Message-Id: <1412345958-8278-4-git-send-email-aclements@csail.mit.edu>\r
  47 X-Mailer: git-send-email 2.1.0\r
  48 In-Reply-To: <1412345958-8278-1-git-send-email-aclements@csail.mit.edu>\r
  49 References: <1412345958-8278-1-git-send-email-aclements@csail.mit.edu>\r
  50 X-Brightmail-Tracker:\r
  51  H4sIAAAAAAAAA+NgFtrPIsWRmVeSWpSXmKPExsUixCmqrVu2QS/EoGuzhMX1mzOZHRg9nq26\r
  52         xRzAGMVlk5Kak1mWWqRvl8CVsXPVF7aCjawVjy8eY2pgXM7SxcjJISFgInFxbz8jhC0mceHe\r
  53         erYuRi4OIYHZTBIdlxYyQTgbGCVWvm6Ecm4zSezdc5kdwlnCKPGv/x9YP5uAvsSKtZNYQWwR\r
  54         AWmJnXdnA9kcHMwCahJ/ulRAwsICxhIPT2wCK2ERUJXYc+EMG4jNK+Am0fZ8NjPEGXISG3b/\r
  55         BxvJKeAuceHuU7AaIaCaVce62SYw8i9gZFjFKJuSW6Wbm5iZU5yarFucnJiXl1qka6yXm1mi\r
  56         l5pSuokRHDaSfDsYvx5UOsQowMGoxMP74YZuiBBrYllxZe4hRkkOJiVR3srFeiFCfEn5KZUZ\r
  57         icUZ8UWlOanFhxglOJiVRHgXrATK8aYkVlalFuXDpKQ5WJTEeTf94AsREkhPLEnNTk0tSC2C\r
  58         ycpwcChJ8LavB2oULEpNT61Iy8wpQUgzcXCCDOcBGg5Ww1tckJhbnJkOkT/FqMvR0vS2l0mI\r
  59         JS8/L1VKnPfhOqAiAZCijNI8uDmweH/FKA70ljBvF8goHmCqgJv0CmgJE9CSd/a6IEtKEhFS\r
  60         Ug2MMqHnPh39pTH99f6NyppyPyyZ+Bs232b7fjx0t7LDbz0bIf7tRyxPH+TkvWl5wyz10M7D\r
  61         t8qahK9Idq2LeWO4Oys5i//dim9mb8J0lJpzO//+Pv7sWuHP8lP1hzhedfEo+sx+LbHjdHZh\r
  62         y7Ww0GLRxPXKWV0Z5m6HUo+5bZJ+/5TTVYmx7kyTEktxRqKhFnNRcSIA/nB3JNICAAA=\r
  63 X-BeenThere: notmuch@notmuchmail.org\r
  64 X-Mailman-Version: 2.1.13\r
  65 Precedence: list\r
  66 List-Id: "Use and development of the notmuch mail system."\r
  67         <notmuch.notmuchmail.org>\r
  68 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
  69         <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
  70 List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
  71 List-Post: <mailto:notmuch@notmuchmail.org>\r
  72 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
  73 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
  74         <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
  75 X-List-Received-Date: Fri, 03 Oct 2014 14:20:16 -0000\r
  76 \r
  77 From: Austin Clements <amdragon@mit.edu>\r
  78 \r
  79 In the interest of robustness, avoid undefined behavior of\r
  80 sortable_unserialise if the date value is missing.  This shouldn't\r
  81 happen now, but ghost messages will have blank date values.\r
  82 ---\r
  83  lib/message.cc | 3 +++\r
  84  1 file changed, 3 insertions(+)\r
  85 \r
  86 diff --git a/lib/message.cc b/lib/message.cc\r
  87 index bbfc250..38bc929 100644\r
  88 --- a/lib/message.cc\r
  89 +++ b/lib/message.cc\r
  90 @@ -896,6 +896,9 @@ notmuch_message_get_date (notmuch_message_t *message)\r
  91         return 0;\r
  92      }\r
  93  \r
  94 +    if (value.empty ())\r
  95 +       /* sortable_unserialise is undefined on empty string */\r
  96 +       return 0;\r
  97      return Xapian::sortable_unserialise (value);\r
  98  }\r
  99  \r
 100 -- \r
 101 2.1.0\r
 102 \r