1 Return-Path: <awg@xvx.ca>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id C4F9D431FB6
\r
6 for <notmuch@notmuchmail.org>; Thu, 9 Feb 2012 20:27:31 -0800 (PST)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id 0YdkEIxHcFsB for <notmuch@notmuchmail.org>;
\r
16 Thu, 9 Feb 2012 20:27:31 -0800 (PST)
\r
17 Received: from mail-lpp01m020-f181.google.com (mail-lpp01m020-f181.google.com
\r
18 [209.85.217.181]) (using TLSv1 with cipher RC4-SHA (128/128 bits))
\r
19 (No client certificate requested)
\r
20 by olra.theworths.org (Postfix) with ESMTPS id DF2B2431FAE
\r
21 for <notmuch@notmuchmail.org>; Thu, 9 Feb 2012 20:27:30 -0800 (PST)
\r
22 Received: by lbbgn5 with SMTP id gn5so1368423lbb.26
\r
23 for <notmuch@notmuchmail.org>; Thu, 09 Feb 2012 20:27:29 -0800 (PST)
\r
25 Received: by 10.152.123.68 with SMTP id ly4mr3052300lab.13.1328848049088; Thu,
\r
26 09 Feb 2012 20:27:29 -0800 (PST)
\r
28 Received: by 10.112.90.20 with HTTP; Thu, 9 Feb 2012 20:27:29 -0800 (PST)
\r
29 X-Originating-IP: [96.52.216.56]
\r
30 In-Reply-To: <87mx8sa2tj.fsf@gmail.com>
\r
31 References: <1326995217-27423-1-git-send-email-awg+notmuch@xvx.ca>
\r
32 <1328746916-25447-1-git-send-email-awg+notmuch@xvx.ca>
\r
33 <1328746916-25447-3-git-send-email-awg+notmuch@xvx.ca>
\r
34 <87mx8sa2tj.fsf@gmail.com>
\r
35 Date: Thu, 9 Feb 2012 21:27:29 -0700
\r
36 X-Google-Sender-Auth: TIS98BnxoTlkJAolME_OyVN1q1Y
\r
38 <CAMoJFUshAUAO6hnYWefXgdBdZe3qavgWokLC8du3VWGYDb9RUQ@mail.gmail.com>
\r
39 Subject: Re: [PATCH v4 2/4] reply: Add a JSON reply format.
\r
40 From: Adam Wolfe Gordon <awg+notmuch@xvx.ca>
\r
41 To: Dmitry Kurochkin <dmitry.kurochkin@gmail.com>
\r
42 Content-Type: text/plain; charset=ISO-8859-1
\r
43 Content-Transfer-Encoding: quoted-printable
\r
45 ALoCoQkH0/0VaDrio0eFWD9t/wbwLVVOO2lN1vLxwks4eduoP/qD+1u4OGG4KJ3bES8OxN1xwwsd
\r
46 Cc: notmuch@notmuchmail.org
\r
47 X-BeenThere: notmuch@notmuchmail.org
\r
48 X-Mailman-Version: 2.1.13
\r
50 List-Id: "Use and development of the notmuch mail system."
\r
51 <notmuch.notmuchmail.org>
\r
52 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
53 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
54 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
55 List-Post: <mailto:notmuch@notmuchmail.org>
\r
56 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
57 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
58 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
59 X-List-Received-Date: Fri, 10 Feb 2012 04:27:31 -0000
\r
63 On Thu, Feb 9, 2012 at 00:22, Dmitry Kurochkin
\r
64 <dmitry.kurochkin@gmail.com> wrote:
\r
65 >> Reply now enforces that only one message is returned, as the semantics
\r
66 >> of replying to multiple messages are not wel-defined.
\r
70 Oops! git filter-branch to the rescue :-).
\r
72 >> Show is modified such that --format=3Djson no longer implies
\r
73 >> --entire-thread, as MUAs will use --format=3Djson when constructing
\r
74 >> replies. The man page is updated to reflect this change.
\r
76 > I did not look into details. =A0But I am surprised that user needs to cal=
\r
78 > notmuch show --format=3Djson to make reply. =A0I would expect notmuch rep=
\r
80 > to provide all required info (except for bodies).
\r
82 I agree, it would be ideal to include the data from show --format=3Djson
\r
83 in the reply JSON. I started down the path of implementing this, but
\r
84 realized it requires either copying quite a bit of code from show or
\r
85 factoring it out, and both options felt kind of dirty. I'd like show
\r
86 and reply to share a function that produces the JSON-formatted body of
\r
87 a message, but it doesn't feel right to expose the entire JSON format
\r
88 and all the functions that go with it from notmuch-show.c and put the
\r
89 structure and all the prototypes in notmuch-client.h.
\r
91 Will Austin's show rewrite make this easier/cleaner? Or am I being too
\r
92 squeamish about moving code?
\r
94 > Anyway, I think you should put this change in a separate patch.
\r
96 Yeah, if I leave it as is it changes a default behavior, so a separate
\r
97 patch would probably be a good idea.
\r
99 > Also, we clearly need a NEWS entry for it and user-customizable Emacs
\r
100 > variable changes. =A0Though it can be done after this series is pushed, I
\r
103 I don't think there are any emacs customization changes here, unless
\r
104 we want to implement the notmuch mode config file that was discussed
\r
105 before to give message-citation-line-format and other things nice
\r
106 defaults. Or are you suggesting that there should be some new
\r
107 customization options? (One I can think of would be the list of
\r
108 preferred types for multipart/alternative display, which right now is
\r
109 hardcoded in notmuch-show.el.)
\r
111 > Thank you for this work, it is much appreciated.
\r
113 Thanks for taking the time to review these patches! I think as a
\r
114 result of everyone's reviews I've pushed the series toward what I
\r
115 envisioned/wanted in the first place, rather than the kinda kludgey
\r
116 thing I did initially.
\r
118 Amusingly, I've started a new job since I wrote the original patch and
\r
119 no longer receive much HTML-only email, but I like this patch series
\r
120 enough to see it through anyway :-).
\r
projects / notmuch-archives.git / blob