From fed6ae4e2e08afdb18110b94f8ed0cf78d208716 Mon Sep 17 00:00:00 2001 From: Austin Clements Date: Sun, 16 Dec 2012 14:45:47 +1900 Subject: [PATCH] Re: [PATCH 1/7] emacs: Centralize notmuch command error handling --- 81/7a1a2f399c13073989ed8b077ae1cd2d7e6189 | 107 ++++++++++++++++++++++ 1 file changed, 107 insertions(+) create mode 100644 81/7a1a2f399c13073989ed8b077ae1cd2d7e6189 diff --git a/81/7a1a2f399c13073989ed8b077ae1cd2d7e6189 b/81/7a1a2f399c13073989ed8b077ae1cd2d7e6189 new file mode 100644 index 000000000..bffd5151b --- /dev/null +++ b/81/7a1a2f399c13073989ed8b077ae1cd2d7e6189 @@ -0,0 +1,107 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 6BEE1431FBC + for ; Sat, 15 Dec 2012 11:45:55 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -0.7 +X-Spam-Level: +X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5 + tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id j8XqHIcXZKZZ for ; + Sat, 15 Dec 2012 11:45:54 -0800 (PST) +Received: from dmz-mailsec-scanner-7.mit.edu (DMZ-MAILSEC-SCANNER-7.MIT.EDU + [18.7.68.36]) + by olra.theworths.org (Postfix) with ESMTP id 7B391431FB6 + for ; Sat, 15 Dec 2012 11:45:54 -0800 (PST) +X-AuditID: 12074424-b7fe06d0000008f0-a9-50ccd3705bcb +Received: from mailhub-auth-4.mit.edu ( [18.7.62.39]) + by dmz-mailsec-scanner-7.mit.edu (Symantec Messaging Gateway) with SMTP + id 55.B3.02288.073DCC05; Sat, 15 Dec 2012 14:45:53 -0500 (EST) +Received: from outgoing.mit.edu (OUTGOING-AUTH.MIT.EDU [18.7.22.103]) + by mailhub-auth-4.mit.edu (8.13.8/8.9.2) with ESMTP id qBFJjqOg011443; + Sat, 15 Dec 2012 14:45:52 -0500 +Received: from awakening.csail.mit.edu (awakening.csail.mit.edu [18.26.4.91]) + (authenticated bits=0) + (User authenticated as amdragon@ATHENA.MIT.EDU) + by outgoing.mit.edu (8.13.6/8.12.4) with ESMTP id qBFJjmEI022364 + (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT); + Sat, 15 Dec 2012 14:45:51 -0500 (EST) +Received: from amthrax by awakening.csail.mit.edu with local (Exim 4.80) + (envelope-from ) + id 1TjxgB-0003Du-VN; Sat, 15 Dec 2012 14:45:48 -0500 +From: Austin Clements +To: Tomi Ollila , notmuch@notmuchmail.org +Subject: Re: [PATCH 1/7] emacs: Centralize notmuch command error handling +In-Reply-To: +References: <1355548513-10085-1-git-send-email-amdragon@mit.edu> + <1355548513-10085-2-git-send-email-amdragon@mit.edu> + +User-Agent: Notmuch/0.14+184~gc26cc51 (http://notmuchmail.org) Emacs/23.4.1 + (i486-pc-linux-gnu) +Date: Sat, 15 Dec 2012 14:45:47 -0500 +Message-ID: <877gojxfo4.fsf@awakening.csail.mit.edu> +MIME-Version: 1.0 +Content-Type: text/plain; charset=us-ascii +X-Brightmail-Tracker: + H4sIAAAAAAAAA+NgFnrEIsWRmVeSWpSXmKPExsUixG6nrlt4+UyAwaILjBbXb85ktnizch6r + A5PH4a8LWTyerbrFHMAUxWWTkpqTWZZapG+XwJXRv+gnW8EpjopzDX+YGhhfsHUxcnJICJhI + fDh7nAXCFpO4cG89UJyLQ0hgH6PE+Zt/WSCcDYwSd7Ysh8pcZJL4tbWdHcJZwihxe9ZqRpB+ + NgENiW37l4PZIgK2EleWnGQFsYUFPCV6Ti4Ei3MKGEh0fbgANWkmo8THqTeBJnFwiArES5xd + agJSwyKgKrFx5QSwm3iB7pvzfTcThC0ocXLmE7A4s4CWxI1/L5kmMArMQpKahSS1gJFpFaNs + Sm6Vbm5iZk5xarJucXJiXl5qka65Xm5miV5qSukmRnBQuqjsYGw+pHSIUYCDUYmHd0fE6QAh + 1sSy4srcQ4ySHExKorwV584ECPEl5adUZiQWZ8QXleakFh9ilOBgVhLhTZoPlONNSaysSi3K + h0lJc7AoifNeT7npLySQnliSmp2aWpBaBJOV4eBQkuCddQmoUbAoNT21Ii0zpwQhzcTBCTKc + B2h4P0gNb3FBYm5xZjpE/hSjopQ471SQhABIIqM0D64XljReMYoDvSLMWwdSxQNMOHDdr4AG + MwENXm4DNrgkESEl1cDY7OXg/l391Kq3c9q/5zw9n832+MINm8hN/cd7b4h3bLSNnl/jpX/F + srmzNUuT7RtrSfj2y98eW/yfdXX1q5wQvhbXN75MFlE7HZ5e3WVR93uba3+SC+eB1/usjxX8 + 36/8p/Q4k3T6dtv6ZayaTiwTeyQurbSIUbD/feDAEQej1UuNrJZmpi9WYinOSDTUYi4qTgQA + gTBFivUCAAA= +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Sat, 15 Dec 2012 19:45:55 -0000 + +On Sat, 15 Dec 2012, Tomi Ollila wrote: +> On Sat, Dec 15 2012, Austin Clements wrote: +> +>> This provides library functions for unified handling of errors from +>> the notmuch CLI. Follow-up patches will convert some scattered error +>> handling to use this and add error handling where we currently ignore +>> errors. +>> --- +> +> The series looks pretty good, some hardcoded patchs Mark noticed +> and it looks to me (after viewing id:8738z7hd6x.fsf@qmul.ac.uk +> that err -> nil could be done. + +Fixed. + +> Would (goto-char (point-min)) be needed before (insert msg) in +> this patch -- what If user has moved cursor while viewing old +> error messages but not pressed q (dismissed) on the buffer. + +Good idea. Actually, I had intended to *append* the error to the buffer +so it would be in chronological order. I tweaked things a bit so +messages should always be appended and point will be left at the end of +the error log. + +> Also, what about (unless (eobp) (insert "\n")) to add empty +> line between error messages ? + +Done. + +> Tomi -- 2.26.2