From fb028e8ca2b61803b402bd0595ed7073540cd879 Mon Sep 17 00:00:00 2001 From: Mark Walters Date: Mon, 3 Dec 2012 00:58:34 +0000 Subject: [PATCH] [PATCH v2 0/3] Allow emacs to toggle display of all parts including multipart --- f7/71cd346346494a5daf0b63220988300cb1561d | 101 ++++++++++++++++++++++ 1 file changed, 101 insertions(+) create mode 100644 f7/71cd346346494a5daf0b63220988300cb1561d diff --git a/f7/71cd346346494a5daf0b63220988300cb1561d b/f7/71cd346346494a5daf0b63220988300cb1561d new file mode 100644 index 000000000..03eb30458 --- /dev/null +++ b/f7/71cd346346494a5daf0b63220988300cb1561d @@ -0,0 +1,101 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 7A32C431FB6 + for ; Sun, 2 Dec 2012 16:58:49 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: 2.7 +X-Spam-Level: ** +X-Spam-Status: No, score=2.7 tagged_above=-999 required=5 + tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, + FREEMAIL_ENVFROM_END_DIGIT=1, FREEMAIL_FROM=0.001, + FREEMAIL_REPLY=2.499, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id BC5JiE3dG7ev for ; + Sun, 2 Dec 2012 16:58:48 -0800 (PST) +Received: from mail-wg0-f41.google.com (mail-wg0-f41.google.com + [74.125.82.41]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client + certificate requested) by olra.theworths.org (Postfix) with ESMTPS id + AADDB431FAE for ; Sun, 2 Dec 2012 16:58:48 -0800 + (PST) +Received: by mail-wg0-f41.google.com with SMTP id ds1so737127wgb.2 + for ; Sun, 02 Dec 2012 16:58:47 -0800 (PST) +DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; + h=from:to:cc:subject:date:message-id:x-mailer; + bh=t+ecVFlvFEAvcGOxZyvCGOiXQ0SdFUPAjlAiSAhq6cg=; + b=EypN/O83BUAXSsULRpNJrBzwuXAYQQtcOl426CwmA66x+x7BfjtyNBBvnq7lBUCu2U + 5hQjBnDM//MiQxBVqdivEapSZKBqrC0pb7KmqqAiLenoNjoPQ0Wo8IF0FZhgF0EiOiHw + bPJerxYJ7YaDG8h1XA+3vy/vXosFpI9OvjGg4sA3pkitc6KceyoomvMEJX0aHlGTW/46 + qIS9OX++CcdFW2lQW9YYlHZD278VRBi+GNfoL0V9r2EuJX9MV81996Nil95mYSLZa6ND + PHvwiGXi67AKWvvmpKdzwd6hpQ2o7y3Fk7/dPAeCnVXlKKvPDnBkSUJFicY1clJEwK8Q + ZLlg== +Received: by 10.180.87.39 with SMTP id u7mr6906382wiz.6.1354496326080; + Sun, 02 Dec 2012 16:58:46 -0800 (PST) +Received: from localhost (93-97-24-31.zone5.bethere.co.uk. [93.97.24.31]) + by mx.google.com with ESMTPS id i6sm9020485wix.5.2012.12.02.16.58.44 + (version=TLSv1/SSLv3 cipher=OTHER); + Sun, 02 Dec 2012 16:58:44 -0800 (PST) +From: Mark Walters +To: notmuch@notmuchmail.org +Subject: [PATCH v2 0/3] Allow emacs to toggle display of all parts including + multipart +Date: Mon, 3 Dec 2012 00:58:34 +0000 +Message-Id: <1354496317-24564-1-git-send-email-markwalters1009@gmail.com> +X-Mailer: git-send-email 1.7.9.1 +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Mon, 03 Dec 2012 00:58:49 -0000 + +This is rather more polished version of +id:1351152563-27277-1-git-send-email-markwalters1009@gmail.com. + +The first patch modifies the behaviour of show refresh buffer to keep +state more accurately where possible. It can never be perfect but it +makes a reasonable attempt. This is independent of patches 2 and 3. + +The second patch allows the user to toggle the visibility of any part +with 't' on the part button. It does this by storing a list of all +parts that the user has over-ruled. + +The final patch binds the toggle to the default action in cases where +the part has no filename. Is this a reasonable heuristic? And should +it be customisable? In all cases the defined actions (save, view, +other, and toggle) always do their action (ie they do not apply any +heuristics) + +Overall I am pleased with the way it works. The one caveat is that it +does redisplay the whole buffer when toggling the parts: it might be +nice to use invisibility but that is beyond my lisp. Moreover it could +be added at a later stage without changing the user experience. + + +Best wishes + +Mark + + +Mark Walters (3): + emacs: show: make refresh fix point(ish) + emacs: allow the user to toggle the visibility of + multipart/alternative parts + emacs: show make default part button toggle view when sensible + + emacs/notmuch-show.el | 80 ++++++++++++++++++++++++++++++++++++++---------- + 1 files changed, 63 insertions(+), 17 deletions(-) + +-- +1.7.9.1 + -- 2.26.2