From fa40c33f235516baa60d3fc343b04e0d282a46f7 Mon Sep 17 00:00:00 2001 From: Jameson Graef Rollins Date: Tue, 4 Dec 2012 09:15:21 +1600 Subject: [PATCH] Re: [PATCH (draft) 0/2] Allow emacs to toggle display of all parts including multipart --- 7c/cdd7ee4ad5d8f8d67ddba0a7c4883e4c881a9d | 116 ++++++++++++++++++++++ 1 file changed, 116 insertions(+) create mode 100644 7c/cdd7ee4ad5d8f8d67ddba0a7c4883e4c881a9d diff --git a/7c/cdd7ee4ad5d8f8d67ddba0a7c4883e4c881a9d b/7c/cdd7ee4ad5d8f8d67ddba0a7c4883e4c881a9d new file mode 100644 index 000000000..8a5108347 --- /dev/null +++ b/7c/cdd7ee4ad5d8f8d67ddba0a7c4883e4c881a9d @@ -0,0 +1,116 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 8A2E8431FB6 + for ; Mon, 3 Dec 2012 09:15:34 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -2.3 +X-Spam-Level: +X-Spam-Status: No, score=-2.3 tagged_above=-999 required=5 + tests=[RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id AXicypA5Xoi7 for ; + Mon, 3 Dec 2012 09:15:30 -0800 (PST) +Received: from outgoing-mail.its.caltech.edu (outgoing-mail.its.caltech.edu + [131.215.239.19]) + by olra.theworths.org (Postfix) with ESMTP id 8C5A0431FAE + for ; Mon, 3 Dec 2012 09:15:30 -0800 (PST) +Received: from earth-doxen.imss.caltech.edu (localhost [127.0.0.1]) + by earth-doxen-postvirus (Postfix) with ESMTP id 0009D66E0204; + Mon, 3 Dec 2012 09:15:29 -0800 (PST) +X-Spam-Scanned: at Caltech-IMSS on earth-doxen by amavisd-new +Received: from finestructure.net (DHCP-123-194.caltech.edu [131.215.123.194]) + (Authenticated sender: jrollins) + by earth-doxen-submit (Postfix) with ESMTP id EA50D66E01CE; + Mon, 3 Dec 2012 09:15:25 -0800 (PST) +Received: by finestructure.net (Postfix, from userid 1000) + id 1074D616EF; Mon, 3 Dec 2012 09:15:24 -0800 (PST) +From: Jameson Graef Rollins +To: Jani Nikula , Mark Walters , + notmuch@notmuchmail.org +Subject: Re: [PATCH (draft) 0/2] Allow emacs to toggle display of all parts + including multipart +In-Reply-To: <87mwxwme1b.fsf@nikula.org> +References: <1351152563-27277-1-git-send-email-markwalters1009@gmail.com> + <87mwxwme1b.fsf@nikula.org> +User-Agent: Notmuch/0.14+132~g59fcb16 (http://notmuchmail.org) Emacs/24.2.1 + (x86_64-pc-linux-gnu) +Date: Mon, 03 Dec 2012 09:15:21 -0800 +Message-ID: <87y5hf9hw6.fsf@servo.finestructure.net> +MIME-Version: 1.0 +Content-Type: multipart/signed; boundary="=-=-="; + micalg=pgp-sha256; protocol="application/pgp-signature" +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Mon, 03 Dec 2012 17:15:34 -0000 + +--=-=-= +Content-Type: text/plain + +On Sun, Dec 02 2012, Jani Nikula wrote: +>> The first patch binds this toggle to 't' on the part button. This +>> patch works by itself. +> +> I'd like to rebind RET to do the toggle by default. I don't think it's +> very useful to be able to save multipart/alternative parts by default. + +In my opinion RET should always just display the part. If the part is +inlineable, then it should toggle display of it in the show buffer. If +it's not, it should open it in an external viewer. I think that makes +the most sense, and agrees with the behavior of the collapsed citation +text buttons, for instance. + +> One more wishlist item, which also doesn't need to be part of this +> series, or by you: I'd like to be able to specify *which* +> multipart/alternative parts should be displayed in addition to +> preferred. A list of (regexps matching) mime types to always open, +> whether they're preferred or not. I've previously sent patches to this +> effect, but they were never merged (I can repost if you want). + +I still think that for multipart/alternatives parts we should just cycle +through display of the alternatives. That's kind of the whole point of +this mime type. Obviously display everything is better than not being +able to access the alternative parts at all. But forcing +mutlipart/alternative to behave exactly like multipart/mixed seems to +miss the point to me. + +This is something that could be worked off of this series, though, so +definitely don't take this as a mark against this work. I think this is +a very useful usability improvement. Thank you for working on it, Mark. + +jamie. + +--=-=-= +Content-Type: application/pgp-signature + +-----BEGIN PGP SIGNATURE----- +Version: GnuPG v1.4.12 (GNU/Linux) + +iQIcBAEBCAAGBQJQvN4pAAoJEO00zqvie6q8ohcP/1U4mEZJjQPmZIjvTUfb/csA +nmocmBGumDAq43uO9mIDKhJbeJXfJXS6SonTPNzme0hfL1LiDAePE02/wnKixMsc +AvZqkgZtPdPYv/dKFr0dGmzHKuFZzHTv36F6QPml9ipT9B1i+hW3XV14Lb4ly+Zc +F2rlNelSQr2kRKvRijrceih873jx07XhSjVxUm+3s3wbMUTQu7fIpWCbEe21ZI41 +A56EoPZlBNwJoiOZSkQyOC31CHl41wwCWbyQqBPfn8GwUkQy4cb4c/h0i3dBOMvv +1O9n736KJiYIarHwn4zGMNj7gMb9GAMVapeyKcrRbfv/XPB//iUaubn+0vuX8L+/ +sS4MjepWfRGgoEn3WE2XORFDw8fQuF5hVYaaT92YJtXfypPaS9dffLx+06HAwAwK +Ojksyfh65E1U/GWViIkAJzsvMMqmU1COQLge2r9+c3o56NDZoYV8oe1bblx0M+pl +ii6AiYXuIESvwIggAOCgRE5qRB9aRAaIK8eccLyG1JjeCMG4P6hZEpiiwnNkI8X/ +qd9YF5GL/GtOlnlsm7sSMxpYVPqaOZfKoE2g4H0Fb63TY0jHIID5fhuLwX8Onxsd +n4gz+ArnL9rl1KHU/pc29Co/LN2kGTni5qmGHBQGNJnbJKofhLlsL4U9jvn8qgqT +8DKC6+bXL1b4O+CnwDqS +=0BXQ +-----END PGP SIGNATURE----- +--=-=-=-- -- 2.26.2