From f9d9365552d0149a0a820bc1588eebdd3cf57536 Mon Sep 17 00:00:00 2001 From: Felipe Contreras Date: Thu, 24 May 2012 10:56:58 +0200 Subject: [PATCH] Re: [PATCH 3/4] ruby: Add workarounds to use in-tree build not the installed one --- 83/2bc712dc6a661153f7446623342d32cd334b56 | 113 ++++++++++++++++++++++ 1 file changed, 113 insertions(+) create mode 100644 83/2bc712dc6a661153f7446623342d32cd334b56 diff --git a/83/2bc712dc6a661153f7446623342d32cd334b56 b/83/2bc712dc6a661153f7446623342d32cd334b56 new file mode 100644 index 000000000..43d74f76e --- /dev/null +++ b/83/2bc712dc6a661153f7446623342d32cd334b56 @@ -0,0 +1,113 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 06625431FCF + for ; Thu, 24 May 2012 01:57:01 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -0.799 +X-Spam-Level: +X-Spam-Status: No, score=-0.799 tagged_above=-999 required=5 + tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, + FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id jH6neqJPXVkf for ; + Thu, 24 May 2012 01:57:00 -0700 (PDT) +Received: from mail-lpp01m010-f53.google.com (mail-lpp01m010-f53.google.com + [209.85.215.53]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id 1EA44431FC4 + for ; Thu, 24 May 2012 01:56:59 -0700 (PDT) +Received: by lagu2 with SMTP id u2so6662211lag.26 + for ; Thu, 24 May 2012 01:56:58 -0700 (PDT) +DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; + h=mime-version:in-reply-to:references:date:message-id:subject:from:to + :cc:content-type; + bh=xaoNbORwsILS5aO/xxwsRrDLMGJZ1LEprtWP+cL9XO8=; + b=fYgrxjmxM4QYAtJcAdt7TGBOJPq1gnqpdurc77ATb5FXByKCWGj3f6mIN7EL4VsrYW + 5of9URK8Pd4R5k6/FOo6qk56NAnxifkDbU1Fd7mz0SCUAEF7OriNdjtWP8Sd/2SAZaHW + ndeh0Gs64vZ0gikNjhLLjjttX1H24x9N6pE5QoO9wFxDaXOXQmiptt0VpfVXmUrVTSq5 + 79TN54YcocI4GPysZ3xdWPt83lJF6nc7tRgMuyuknZfEjxkhSiE0tgPoH2dkrmgBB19M + HLZFsSVC2VY5ESenXj2nGIIjmJjYnGOKrZ2Ng0/NusAGfteYLbleKKA4EaQvPIq2Fdrj + HanQ== +MIME-Version: 1.0 +Received: by 10.152.108.38 with SMTP id hh6mr29784900lab.28.1337849818389; + Thu, 24 May 2012 01:56:58 -0700 (PDT) +Received: by 10.112.107.65 with HTTP; Thu, 24 May 2012 01:56:58 -0700 (PDT) +In-Reply-To: <878vgi1ign.fsf@zancas.localnet> +References: <87txzsgs4g.fsf@zancas.localnet> + + <1559639bc5e9e3253f2ee2220a8d8d00c39d9d43.1336402558.git.alip@exherbo.org> + + <878vgi1ign.fsf@zancas.localnet> +Date: Thu, 24 May 2012 10:56:58 +0200 +Message-ID: + +Subject: Re: [PATCH 3/4] ruby: Add workarounds to use in-tree build not the + installed one +From: Felipe Contreras +To: David Bremner +Content-Type: text/plain; charset=UTF-8 +Cc: Ali Polatel , notmuch@notmuchmail.org +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Thu, 24 May 2012 08:57:01 -0000 + +On Thu, May 24, 2012 at 3:22 AM, David Bremner wrote: +> Felipe Contreras writes: +> +> +>> I don't see how this patch could be fixed properly easily, and it was +>> labeled as a hack, and I didn't like it in the first place anyway, so +>> I'm going to revert it by tomorrow if I don't hear any good reason not +>> to. +> +> I think this highlights the need for at least a minimal test suite for +> the ruby + +Yeap, I thought the same. + +> I do plan on a bug fix release, to fix an annoying emacs interface bug +> if nothing else. I'd rather see a fix/revert coordinated with Ali in his +> role as ruby bindings maintainer. + +Well, sure, if possible that would be best. But I doubt the ruby +bindings maintainer would complain about making the Ruby bindings work +again :) + +Worst-case scenario we would end up with what we had before. + +> FWIW, the previous situation of linking with the installed version of +> notmuch sounds somewhat broken as well, although obviously preferable to +> not working at all. + +That would be only if there was installed version of notmuch, which +some people don't have (e.g. me). + +Either way, to fix that particular problem we don't need to link to +the static library, we can just the right CFLAGS and LDFLAGS, in fact, +I wonder how is it that it's not working properly; AFAIK the linker +and compiler would use first the headers and libraries found in these +flags, and only as a fallback use the system ones, so if anybody has +managed to compile before (I have) the headers and libraries would be +in some -I/-L path. + +I could try to investigate, but at the moment I still see no reason +not to revert. + +Cheers. + +-- +Felipe Contreras -- 2.26.2