From f8618ba97c98408a2ae19a0df0349ebb977608c5 Mon Sep 17 00:00:00 2001 From: Tomi Ollila Date: Wed, 4 Jul 2012 19:37:59 +0300 Subject: [PATCH] Re: [PATCH 0/8] JSON-based search-mode --- 54/e984c86832aa24b88822f6ad0f952883255042 | 84 +++++++++++++++++++++++ 1 file changed, 84 insertions(+) create mode 100644 54/e984c86832aa24b88822f6ad0f952883255042 diff --git a/54/e984c86832aa24b88822f6ad0f952883255042 b/54/e984c86832aa24b88822f6ad0f952883255042 new file mode 100644 index 000000000..16ef4cce7 --- /dev/null +++ b/54/e984c86832aa24b88822f6ad0f952883255042 @@ -0,0 +1,84 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 0F786431FB6 + for ; Wed, 4 Jul 2012 09:37:48 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: 0 +X-Spam-Level: +X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] + autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id fBzlqqQaTHMZ for ; + Wed, 4 Jul 2012 09:37:47 -0700 (PDT) +Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34]) + by olra.theworths.org (Postfix) with ESMTP id 55A24431FAE + for ; Wed, 4 Jul 2012 09:37:47 -0700 (PDT) +Received: by guru.guru-group.fi (Postfix, from userid 501) + id 2442F100637; Wed, 4 Jul 2012 19:37:59 +0300 (EEST) +From: Tomi Ollila +To: Austin Clements , notmuch@notmuchmail.org +Subject: Re: [PATCH 0/8] JSON-based search-mode +In-Reply-To: <1341354059-29396-1-git-send-email-amdragon@mit.edu> +References: <1341354059-29396-1-git-send-email-amdragon@mit.edu> +User-Agent: Notmuch/0.13.2+73~g94db390 (http://notmuchmail.org) Emacs/23.1.1 + (x86_64-redhat-linux-gnu) +X-Face: HhBM'cA~ +MIME-Version: 1.0 +Content-Type: text/plain; charset=us-ascii +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Wed, 04 Jul 2012 16:37:48 -0000 + +On Wed, Jul 04 2012, Austin Clements wrote: + +> This patch series replaces the text format parser used for search in +> Emacs with a parser for the JSON format. This should address the +> escaping and flexibility problems that have plagued the text format. +> Like the text format, it supports incremental output. +> +> Patches 1-4 simply clean up the Emacs search code and could be pushed +> before the rest of the series. Patch 5 switches to the JSON plist +> representation internally, but retains the text parser. This requires +> some changes to the text parser to keep things working, but don't get +> too hung up on them since it's about to get replaced entirely. Patch +> 6 adds a test. +> +> Finally, patches 7 and 8 are the real meat. Patch 7 introduces a +> general incremental JSON parser. For search, we could probably get +> away with a simpler, hacky approach, but an incremental JSON parser is +> the type of thing you only want to write once---hacky or not---and it +> seems like the type of thing that could be useful elsewhere, too. +> It's general enough to support things like incremental show buffer +> rendering. +> +> Patch 8 rewrites the search output parser to use the JSON format via +> this incremental parser. + +Looks good, works fine, tests pass. + +I am having those patches applied in this copy of notmuch (emacs mua) +I am running and will continue to do so until new series arrives, this +will be pushed, or latest patch series go stale (which I hope doesn't +happen :) + ++1 + +Tomi -- 2.26.2