From f3194bd831a2f127633fabc25b524a673982cefa Mon Sep 17 00:00:00 2001 From: Austin Clements Date: Wed, 4 Jul 2012 22:04:27 +2000 Subject: [PATCH] Re: [PATCH 1/3] test: add basic show, search --format=text tests --- 5f/64675f8073ef15cb8b2a532232643d84abc8f1 | 182 ++++++++++++++++++++++ 1 file changed, 182 insertions(+) create mode 100644 5f/64675f8073ef15cb8b2a532232643d84abc8f1 diff --git a/5f/64675f8073ef15cb8b2a532232643d84abc8f1 b/5f/64675f8073ef15cb8b2a532232643d84abc8f1 new file mode 100644 index 000000000..038387b68 --- /dev/null +++ b/5f/64675f8073ef15cb8b2a532232643d84abc8f1 @@ -0,0 +1,182 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 6869E431FB6 + for ; Tue, 3 Jul 2012 19:04:31 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -0.7 +X-Spam-Level: +X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5 + tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id CRbVN8VT4NP2 for ; + Tue, 3 Jul 2012 19:04:30 -0700 (PDT) +Received: from dmz-mailsec-scanner-2.mit.edu (DMZ-MAILSEC-SCANNER-2.MIT.EDU + [18.9.25.13]) + by olra.theworths.org (Postfix) with ESMTP id 7E421431FAE + for ; Tue, 3 Jul 2012 19:04:30 -0700 (PDT) +X-AuditID: 1209190d-b7fd56d000000933-4a-4ff3a4ad76a8 +Received: from mailhub-auth-4.mit.edu ( [18.7.62.39]) + by dmz-mailsec-scanner-2.mit.edu (Symantec Messaging Gateway) with SMTP + id 4B.07.02355.DA4A3FF4; Tue, 3 Jul 2012 22:04:29 -0400 (EDT) +Received: from outgoing.mit.edu (OUTGOING-AUTH.MIT.EDU [18.7.22.103]) + by mailhub-auth-4.mit.edu (8.13.8/8.9.2) with ESMTP id q6424Ttf008907; + Tue, 3 Jul 2012 22:04:29 -0400 +Received: from awakening.csail.mit.edu (awakening.csail.mit.edu [18.26.4.91]) + (authenticated bits=0) + (User authenticated as amdragon@ATHENA.MIT.EDU) + by outgoing.mit.edu (8.13.6/8.12.4) with ESMTP id q6424RUc009966 + (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NOT); + Tue, 3 Jul 2012 22:04:28 -0400 (EDT) +Received: from amthrax by awakening.csail.mit.edu with local (Exim 4.77) + (envelope-from ) + id 1SmEx9-0006Ed-Ih; Tue, 03 Jul 2012 22:04:27 -0400 +Date: Tue, 3 Jul 2012 22:04:27 -0400 +From: Austin Clements +To: Peter Wang +Subject: Re: [PATCH 1/3] test: add basic show, search --format=text tests +Message-ID: <20120704020427.GA21653@mit.edu> +References: <1340508470-16606-1-git-send-email-novalazy@gmail.com> +MIME-Version: 1.0 +Content-Type: text/plain; charset=iso-8859-1 +Content-Disposition: inline +Content-Transfer-Encoding: 8bit +In-Reply-To: <1340508470-16606-1-git-send-email-novalazy@gmail.com> +User-Agent: Mutt/1.5.21 (2010-09-15) +X-Brightmail-Tracker: + H4sIAAAAAAAAA+NgFprJKsWRmVeSWpSXmKPExsUixG6nrrt2yWd/g50rbCyu35zJbPG8dS+T + A5PHzll32T2erbrFHMAUxWWTkpqTWZZapG+XwJWxe95s1oKP0hVrZ8k1MK4X72Lk5JAQMJH4 + ffYKK4QtJnHh3nq2LkYuDiGBfYwSz9peMUE46xklNn47AuWcYJJYv3MvC4SzhFHiyZ197CD9 + LAIqEhtuXmMDsdkENCS27V/OCGKLCChL/Pn1DCzOLCAt8e13MxOILSzgKXH53k+gGg4OXgEd + idlrFUBMIQEnifUby0AqeAUEJU7OfMIC0akjsXPrHTaQEpApy/9xQITlJZq3zmYGsTkFnCW2 + 3N4LNlwU6JgpJ7exTWAUnoVk0iwkk2YhTJqFZNICRpZVjLIpuVW6uYmZOcWpybrFyYl5ealF + ukZ6uZkleqkppZsYQTHAKcm7g/HdQaVDjAIcjEo8vIkKn/2FWBPLiitzDzFKcjApifIumwkU + 4kvKT6nMSCzOiC8qzUktPsQowcGsJMK7Ogkox5uSWFmVWpQPk5LmYFES572SctNfSCA9sSQ1 + OzW1ILUIJivDwaEkwXtuMVCjYFFqempFWmZOCUKaiYMTZDgP0HAbkBre4oLE3OLMdIj8KUZF + KXHeCpCEAEgiozQPrheWol4xigO9Isz7E6SKB5je4LpfAQ1mAhqct/gTyOCSRISUVAOj5r3V + 33UnWSrsbOEPVbnkF8Et+DJC9LqP3Zt/Sz6ebHsQ0qpRUGIikytdYbhuUoPhhgj2F1ViJ8Rs + VeO3sX94FdhzQzn7Z+Lu7bf6vvicb/9za76TGPeqFLVod6l9PkI5OoWP37r27XH+tDlbOPuV + 0Ua95bo71cq15yzO37jCOvrMVyO3+lolluKMREMt5qLiRAAdRjUALAMAAA== +Cc: notmuch@notmuchmail.org +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Wed, 04 Jul 2012 02:04:31 -0000 + +Series LGTM, though I'm curious why you want the reply-to header, +given that nothing I'm aware of consumes it. + +I second Jameson's opinion that we should push this first patch even +if we wind up not pushing the others. + +Quoth Peter Wang on Jun 24 at 1:27 pm: +> There didn't seem to be these basic tests for --format=text, +> as there are for --format=json. These are just the tests from +> the `json' script, with adjusted expected outputs. +> --- +> test/notmuch-test | 1 + +> test/text | 55 +++++++++++++++++++++++++++++++++++++++++++++++++++++ +> 2 files changed, 56 insertions(+), 0 deletions(-) +> create mode 100755 test/text +> +> diff --git a/test/notmuch-test b/test/notmuch-test +> index bfad5d3..ea39dfc 100755 +> --- a/test/notmuch-test +> +++ b/test/notmuch-test +> @@ -31,6 +31,7 @@ TESTS=" +> excludes +> tagging +> json +> + text +> multipart +> thread-naming +> raw +> diff --git a/test/text b/test/text +> new file mode 100755 +> index 0000000..428c89b +> --- /dev/null +> +++ b/test/text +> @@ -0,0 +1,55 @@ +> +#!/usr/bin/env bash +> +test_description="--format=text output" +> +. ./test-lib.sh +> + +> +test_begin_subtest "Show message: text" +> +add_message "[subject]=\"text-show-subject\"" "[date]=\"Sat, 01 Jan 2000 12:00:00 -0000\"" "[body]=\"text-show-message\"" +> +output=$(notmuch show --format=text "text-show-message" | notmuch_show_sanitize_all) +> +test_expect_equal "$output" "\ +> + +message{ id:XXXXX depth:0 match:1 excluded:0 filename:XXXXX +> + +header{ +> +Notmuch Test Suite (2000-01-01) (inbox unread) +> +Subject: text-show-subject +> +From: Notmuch Test Suite +> +To: Notmuch Test Suite +> +Date: Sat, 01 Jan 2000 12:00:00 +0000 +> + +header} +> + +body{ +> + +part{ ID: 1, Content-type: text/plain +> +text-show-message +> + +part} +> + +body} +> + +message}" +> + +> +test_begin_subtest "Search message: text" +> +add_message "[subject]=\"text-search-subject\"" "[date]=\"Sat, 01 Jan 2000 12:00:00 -0000\"" "[body]=\"text-search-message\"" +> +output=$(notmuch search --format=text "text-search-message" | notmuch_search_sanitize) +> +test_expect_equal "$output" \ +> +"thread:XXX 2000-01-01 [1/1] Notmuch Test Suite; text-search-subject (inbox unread)" +> + +> +test_begin_subtest "Show message: text, utf-8" +> +add_message "[subject]=\"text-show-utf8-body-sübjéct\"" "[date]=\"Sat, 01 Jan 2000 12:00:00 -0000\"" "[body]=\"tëxt-show-méssage\"" +> +output=$(notmuch show --format=text "tëxt-show-méssage" | notmuch_show_sanitize_all) +> +test_expect_equal "$output" "\ +> + +message{ id:XXXXX depth:0 match:1 excluded:0 filename:XXXXX +> + +header{ +> +Notmuch Test Suite (2000-01-01) (inbox unread) +> +Subject: text-show-utf8-body-sübjéct +> +From: Notmuch Test Suite +> +To: Notmuch Test Suite +> +Date: Sat, 01 Jan 2000 12:00:00 +0000 +> + +header} +> + +body{ +> + +part{ ID: 1, Content-type: text/plain +> +tëxt-show-méssage +> + +part} +> + +body} +> + +message}" +> + +> +test_begin_subtest "Search message: text, utf-8" +> +add_message "[subject]=\"text-search-utf8-body-sübjéct\"" "[date]=\"Sat, 01 Jan 2000 12:00:00 -0000\"" "[body]=\"tëxt-search-méssage\"" +> +output=$(notmuch search --format=text "tëxt-search-méssage" | notmuch_search_sanitize) +> +test_expect_equal "$output" \ +> +"thread:XXX 2000-01-01 [1/1] Notmuch Test Suite; text-search-utf8-body-sübjéct (inbox unread)" +> + +> +test_done -- 2.26.2