From f1db424dfc338c4532ad3462be031fd546fcc6d8 Mon Sep 17 00:00:00 2001 From: Austin Clements Date: Mon, 20 Feb 2012 12:25:41 +1900 Subject: [PATCH] Re: [PATCH 0/3] Make notmuch-show-refresh-view retain state by default --- 41/a2c57df37ccef2691cc1eb5302ec9fdf9f6050 | 102 ++++++++++++++++++++++ 1 file changed, 102 insertions(+) create mode 100644 41/a2c57df37ccef2691cc1eb5302ec9fdf9f6050 diff --git a/41/a2c57df37ccef2691cc1eb5302ec9fdf9f6050 b/41/a2c57df37ccef2691cc1eb5302ec9fdf9f6050 new file mode 100644 index 000000000..20c27dc47 --- /dev/null +++ b/41/a2c57df37ccef2691cc1eb5302ec9fdf9f6050 @@ -0,0 +1,102 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 66A08431FB6 + for ; Sun, 19 Feb 2012 09:27:36 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -0.7 +X-Spam-Level: +X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5 + tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id fwktTYtHw1id for ; + Sun, 19 Feb 2012 09:27:35 -0800 (PST) +Received: from dmz-mailsec-scanner-6.mit.edu (DMZ-MAILSEC-SCANNER-6.MIT.EDU + [18.7.68.35]) + by olra.theworths.org (Postfix) with ESMTP id B3F7B431FAE + for ; Sun, 19 Feb 2012 09:27:35 -0800 (PST) +X-AuditID: 12074423-b7f9c6d0000008c3-0c-4f4131072d6c +Received: from mailhub-auth-3.mit.edu ( [18.9.21.43]) + by dmz-mailsec-scanner-6.mit.edu (Symantec Messaging Gateway) with SMTP + id FD.06.02243.701314F4; Sun, 19 Feb 2012 12:27:35 -0500 (EST) +Received: from outgoing.mit.edu (OUTGOING-AUTH.MIT.EDU [18.7.22.103]) + by mailhub-auth-3.mit.edu (8.13.8/8.9.2) with ESMTP id q1JHRYL3025989; + Sun, 19 Feb 2012 12:27:34 -0500 +Received: from awakening.csail.mit.edu (awakening.csail.mit.edu [18.26.4.91]) + (authenticated bits=0) + (User authenticated as amdragon@ATHENA.MIT.EDU) + by outgoing.mit.edu (8.13.6/8.12.4) with ESMTP id q1JHRWFC009074 + (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NOT); + Sun, 19 Feb 2012 12:27:33 -0500 (EST) +Received: from amthrax by awakening.csail.mit.edu with local (Exim 4.77) + (envelope-from ) + id 1RzAW5-0007W5-Qu; Sun, 19 Feb 2012 12:25:41 -0500 +Date: Sun, 19 Feb 2012 12:25:41 -0500 +From: Austin Clements +To: Tomi Ollila +Subject: Re: [PATCH 0/3] Make notmuch-show-refresh-view retain state by + default +Message-ID: <20120219172541.GQ5991@mit.edu> +References: <1329632533-16152-1-git-send-email-amdragon@mit.edu> + +MIME-Version: 1.0 +Content-Type: text/plain; charset=us-ascii +Content-Disposition: inline +In-Reply-To: +User-Agent: Mutt/1.5.21 (2010-09-15) +X-Brightmail-Tracker: + H4sIAAAAAAAAA+NgFupjleLIzCtJLcpLzFFi42IR4hTV1mU3dPQ32N7OZnH95kxmizcr57E6 + MHkc/rqQxePZqlvMAUxRXDYpqTmZZalF+nYJXBm35zxgLDjCUXHxhHkD4xu2LkZODgkBE4mH + v49A2WISF+6tB7K5OIQE9jFKnO34xgLhbGCUePjmAyOEc5JJonH+UiYIZwmjxMlnTYwg/SwC + qhJnNs5gBrHZBDQktu1fDhYXEVCReNC2nhXEZhaQlvj2u5kJxBYWCJSY934KO4jNK6Atcf7i + HxYQW0ggTaKjeQkzRFxQ4uTMJywQvVoSN/69BOrlAJuz/B8HiMkpYCDxd0IJSIUo0KYpJ7ex + TWAUmoWkeRaS5lkIzQsYmVcxyqbkVunmJmbmFKcm6xYnJ+blpRbpmunlZpbopaaUbmIEBTW7 + i/IOxj8HlQ4xCnAwKvHwSpU5+AuxJpYVV+YeYpTkYFIS5bUxcPQX4kvKT6nMSCzOiC8qzUkt + PsQowcGsJMJbetPeX4g3JbGyKrUoHyYlzcGiJM6rofXOT0ggPbEkNTs1tSC1CCYrw8GhJMHr + AzJUsCg1PbUiLTOnBCHNxMEJMpwHaLgeSA1vcUFibnFmOkT+FKMux8cDTy4wCrHk5eelSonz + qoMUCYAUZZTmwc2BJaNXjOJAbwnzmoNU8QATGdykV0BLmICW8ArZgSwpSURISTUwCqclWrn7 + X3ZzM3S8n/KG31A5qXPD/ENrTt7L6d5gb3kocOefN3OObmh3besqXCzP//24V3V2wrqfbk7q + aRK+vadqv08tVhCvnPNzt/I1ie3M0qcXCZYvmbl9dbKGdmqE7T62ZXu/X7WacCrWdvP5vtaL + 4c8EXNn3f/55NGLL1NVb5DfYXn6eqsRSnJFoqMVcVJwIAFzbWl0hAwAA +Cc: notmuch@notmuchmail.org +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Sun, 19 Feb 2012 17:27:36 -0000 + +Quoth Tomi Ollila on Feb 19 at 11:43 am: +> On Sun, 19 Feb 2012 01:22:10 -0500, Austin Clements wrote: +> > Based on the thread at id:"20120213152858.GO27039@mit.edu" it seems +> > like people want show refresh to retain message state by default (I +> > certainly do), rather than reset it by default. As a nice bonus, this +> > fixes a broken test. +> +> Hmm +> +> Every '=' keypress in a thread removes 'unread' tag from next unread +> message :o + +Oh dear. It's slightly subtler than that, though. Refreshing will +remove the unread tag from the first message matching the query. (I +suspect you had tag:unread in your query?) This is particularly +confusing for state-retaining refresh because that message might not +even be open. + +> That is probably desirable feature when refreshing view without +> retaining state. Also, probably notmuch-show-refresh-view should +> be fixed not to mark next message unread when retaining state ? + +I would argue that refresh should never have side-effects, so neither +case should mark anything read. I'll send a v2. -- 2.26.2