From f1084a447166a76ab671af6e688961586e5e54bd Mon Sep 17 00:00:00 2001 From: Jameson Graef Rollins Date: Tue, 19 Jun 2012 10:14:58 +1700 Subject: [PATCH] Re: Notmuch Pick --- 49/bb3fe6f10fcf624887243d16cd29ab5696ac2a | 130 ++++++++++++++++++++++ 1 file changed, 130 insertions(+) create mode 100644 49/bb3fe6f10fcf624887243d16cd29ab5696ac2a diff --git a/49/bb3fe6f10fcf624887243d16cd29ab5696ac2a b/49/bb3fe6f10fcf624887243d16cd29ab5696ac2a new file mode 100644 index 000000000..3bd75fb91 --- /dev/null +++ b/49/bb3fe6f10fcf624887243d16cd29ab5696ac2a @@ -0,0 +1,130 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 27A09431FB6 + for ; Mon, 18 Jun 2012 10:15:09 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -2.29 +X-Spam-Level: +X-Spam-Status: No, score=-2.29 tagged_above=-999 required=5 + tests=[RCVD_IN_DNSWL_MED=-2.3, T_MIME_NO_TEXT=0.01] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id 8Xe1dAM26OhX for ; + Mon, 18 Jun 2012 10:15:07 -0700 (PDT) +Received: from outgoing-mail.its.caltech.edu (outgoing-mail.its.caltech.edu + [131.215.239.19]) + by olra.theworths.org (Postfix) with ESMTP id 2F833431FAE + for ; Mon, 18 Jun 2012 10:15:07 -0700 (PDT) +Received: from fire-doxen.imss.caltech.edu (localhost [127.0.0.1]) + by fire-doxen-postvirus (Postfix) with ESMTP id 75C452E50BE9; + Mon, 18 Jun 2012 10:15:04 -0700 (PDT) +X-Spam-Scanned: at Caltech-IMSS on fire-doxen by amavisd-new +Received: from finestructure.net (unknown [76.89.192.57]) + (Authenticated sender: jrollins) + by fire-doxen-submit (Postfix) with ESMTP id 7B3892E50D6C; + Mon, 18 Jun 2012 10:15:01 -0700 (PDT) +Received: by finestructure.net (Postfix, from userid 1000) + id B793039B; Mon, 18 Jun 2012 10:15:00 -0700 (PDT) +From: Jameson Graef Rollins +To: Mark Walters , notmuch@notmuchmail.org +Subject: Re: Notmuch Pick +In-Reply-To: <87395ump0d.fsf@qmul.ac.uk> +References: <87395ump0d.fsf@qmul.ac.uk> +User-Agent: Notmuch/0.13.2+53~g1567997 (http://notmuchmail.org) Emacs/23.4.1 + (x86_64-pc-linux-gnu) +Date: Mon, 18 Jun 2012 10:14:58 -0700 +Message-ID: <87zk80ilt9.fsf@servo.finestructure.net> +MIME-Version: 1.0 +Content-Type: multipart/signed; boundary="=-=-="; + micalg=pgp-sha256; protocol="application/pgp-signature" +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Mon, 18 Jun 2012 17:15:09 -0000 + +--=-=-= + +On Sat, Jun 16 2012, Mark Walters wrote: +> Since I have had various requests for notmuch pick +> (id:"1329096015-8078-2-git-send-email-markwalters1009@gmail.com") so I +> have started a git repository at +> git://github.com/markwalters1009/notmuch.git +> +> The branch pick-6 is the current version. My intention is to start a new +> branch each time I rebase on to current master but this may change. (I +> suggest that people do not rely on a consistent history for this repository) + +Hey, Mark. I took a look at this and I have a couple of comments: + +726e11aff69e10499a9855e0ac2f15e518985c1f + cli: notmuch-show with framing newlines between threads in JSON. + +This patch introduces a change in the json output format, but there is +no subsequent update of the test suite, so it's causing a lot of test +failures. Obviously this needs to be fixed, but it would probably be +nice to include a couple of other tests for the pick output itself. At +the very least a sanity test to check that it's working at all would be +sufficient initially. + +Would it also be useful to make this same change for the search out, for +consistency? I notice the search output now uses newlines between all +fields, which should help for asynchronous processing, but it might be +nice to put newline separators between the initial and final brackets as +well. + +df97df62b70b884a1cd367360ed6ff7eda0e8af6 + cli: add --headers_only option to notmuch-show.c + +Your comment in this patch is very interesting: + + This is used by notmuch-pick.el (although not needed) because it gives a + speed-up of at least a factor of a two; moreover it reduces the memory + usage in emacs hugely. + +The only difference between the regular show json output and the +--headers-only output, as far as I can tell, is the presence of the +content of text/plain parts if they exist in the message. We previously +had a discussion about the show output not including any part bodies at +all, but we decided that the inclusion of text/plain bodies shouldn't +affect anything, so why not include them. If they actually do, then I +argue we should just move to having show json not include any body parts +at all by default, and just have them be retrieved individually like we +do currently for non-text/plain parts. This would make things cleaner, +and would get rid of the need to have this extra option, which really +doesn't produce a significantly different output. + +jamie. + +--=-=-= +Content-Type: application/pgp-signature + +-----BEGIN PGP SIGNATURE----- +Version: GnuPG v1.4.12 (GNU/Linux) + +iQIcBAEBCAAGBQJP32ISAAoJEO00zqvie6q8JAcP+wYJihHLRGZ4Vd6NrOk2AqxU +6zksedeFhMpZKAONSpIGP68REo/BKT5sh8C4bIX3kLoXfLBIarnfOTYXCHxRi8SH +nc4zAXxMDvR3Wn/2FhD4mvlwo9ywfB+T8uKxfiCyk35UiSADd8MQC1Mun9AGBn9t +a8jlzqLqLIO3L5tXbJPNDUl6/EWJgEBRrkyL3I2lhWcCi4KKLNwBLO4lp3ihvGhC +1qX5fWmvgAJaElmkHGCR3rZlIH5mFHo6Riq56bwI1CdE5a9YxrLqDix48CG30NLV ++YGxNfGQir9e4PSH2659xMvRYvBXsGW8gV8CmhuaAsft2PfquDFH8aglCeq+8sCT ++M3Y6AtmIYfc0qiSTksX8URnwUi+SdZ4s+3RYTzQDndAk/nJM1sSW7NsmBydUSYj +B59eBXl4YFOQLTVk+MjPscU2TRUOSJ76pzUiDk8G+jdw10VFTgoZW92Pkeg4Tsgp +zGMakUREYkC5nm+lLLj154k7YUu3eeXIscCrufS90Ezpy3IBkNHIu4HF1dBFYZ0v +ywdVSwaC3I4D4Pa49nCzCX6S/pwk+1kIZf4Klg7dYmwYPrh2QkCLEZOCmx359v0c +IGx5sqeCDVQEOkrp10m/QfQg8qjD9PqUAQ1CeWV5McZXezyD1UcbGlzLodd//QKe +It3lBMIDPQNvz0QXch5h +=xfcy +-----END PGP SIGNATURE----- +--=-=-=-- -- 2.26.2