From f0e382efac3a539d411d8e218d140680d3e9f59f Mon Sep 17 00:00:00 2001 From: Tomi Ollila Date: Wed, 4 Jul 2012 19:31:57 +0300 Subject: [PATCH] Re: [PATCH 1/8] emacs: Clean up notmuch-search-show-result --- 73/874e858f3ebefb1a657b830259e08bf04bd3a5 | 85 +++++++++++++++++++++++ 1 file changed, 85 insertions(+) create mode 100644 73/874e858f3ebefb1a657b830259e08bf04bd3a5 diff --git a/73/874e858f3ebefb1a657b830259e08bf04bd3a5 b/73/874e858f3ebefb1a657b830259e08bf04bd3a5 new file mode 100644 index 000000000..f34b18374 --- /dev/null +++ b/73/874e858f3ebefb1a657b830259e08bf04bd3a5 @@ -0,0 +1,85 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 1B6A8431FB6 + for ; Wed, 4 Jul 2012 09:31:48 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: 0 +X-Spam-Level: +X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] + autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id xlJIMFzm9tye for ; + Wed, 4 Jul 2012 09:31:47 -0700 (PDT) +Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34]) + by olra.theworths.org (Postfix) with ESMTP id 68AF7431FAE + for ; Wed, 4 Jul 2012 09:31:47 -0700 (PDT) +Received: by guru.guru-group.fi (Postfix, from userid 501) + id 6BBEF100637; Wed, 4 Jul 2012 19:31:57 +0300 (EEST) +From: Tomi Ollila +To: Austin Clements , + Mark Walters +Subject: Re: [PATCH 1/8] emacs: Clean up notmuch-search-show-result +In-Reply-To: <20120704162243.GC21653@mit.edu> +References: <1341354059-29396-1-git-send-email-amdragon@mit.edu> + <1341354059-29396-2-git-send-email-amdragon@mit.edu> + <87lij0gdwt.fsf@qmul.ac.uk> <20120704162243.GC21653@mit.edu> +User-Agent: Notmuch/0.13.2+73~g94db390 (http://notmuchmail.org) Emacs/23.1.1 + (x86_64-redhat-linux-gnu) +X-Face: HhBM'cA~ +MIME-Version: 1.0 +Content-Type: text/plain; charset=us-ascii +Cc: notmuch@notmuchmail.org +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Wed, 04 Jul 2012 16:31:48 -0000 + +On Wed, Jul 04 2012, Austin Clements wrote: + +> Quoth Mark Walters on Jul 04 at 8:53 am: +>> On Tue, 03 Jul 2012, Austin Clements wrote: +>> > This simplifies the code and makes it no longer cubic in the number of +>> > result fields. +>> +>> This looks good to me and all tests pass, and I agree that this patch +>> can be pushed independently of the later patches in the series. +>> +>> My one comment is that I, as a lisp beginner, found the use of "format" +>> as a function and a variable confusing (particularly as I had not come +>> across the dolist macro and that use really makes format look like a +>> function). +> +> I can see how that would be confusing. Unless this version of the +> series is somehow perfect, I'll rename it in the second version. +> Perhaps result-format for the loop variable and spec for the format +> string argument? + +There are 'format' variables elsewhere too -- on those places it could +be renamed as 'format-string' (as used else-elsewhere and the format +documentation refers to STRING). As an analogy to that the 'format' in +this particular dolist usage could be 'format-pair' ? (but anything goes, +even the current 'format'). + +Tomi + +> +>> Best wishes +>> +>> Mark -- 2.26.2