From ef6ccf354af072b71c1b47dabe5d37a922e8f483 Mon Sep 17 00:00:00 2001 From: Jani Nikula Date: Wed, 5 Dec 2012 19:24:54 +0200 Subject: [PATCH] Re: [PATCH 0/3] Use invisibility to toggle display of all parts including multipart --- f7/d4265afe64ebc98bf63595f2bac76c13defb91 | 134 ++++++++++++++++++++++ 1 file changed, 134 insertions(+) create mode 100644 f7/d4265afe64ebc98bf63595f2bac76c13defb91 diff --git a/f7/d4265afe64ebc98bf63595f2bac76c13defb91 b/f7/d4265afe64ebc98bf63595f2bac76c13defb91 new file mode 100644 index 000000000..8afdc3b59 --- /dev/null +++ b/f7/d4265afe64ebc98bf63595f2bac76c13defb91 @@ -0,0 +1,134 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 4A2DC431FB6 + for ; Wed, 5 Dec 2012 09:25:03 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -0.7 +X-Spam-Level: +X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5 + tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id mPKxbhc7EVxw for ; + Wed, 5 Dec 2012 09:25:02 -0800 (PST) +Received: from mail-la0-f53.google.com (mail-la0-f53.google.com + [209.85.215.53]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id 87F90431FAE + for ; Wed, 5 Dec 2012 09:25:02 -0800 (PST) +Received: by mail-la0-f53.google.com with SMTP id w12so4624544lag.26 + for ; Wed, 05 Dec 2012 09:25:00 -0800 (PST) +X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; + d=google.com; s=20120113; + h=from:to:subject:in-reply-to:references:user-agent:date:message-id + :mime-version:content-type:x-gm-message-state; + bh=kkiB34AgzegAGGiGXUCc6NjefwVQ0RGokNXIbCzB9Uk=; + b=b/9IOXRipqcUYAwrwpApqXHqEb2808kbpXgWFV/hNvuai76Gvv0OSi7e8LS3x279n+ + h1zCcwncCg04xzTBfrIQ/E65AYoD1D5TOyYiWLKrcm+2Lw9EEQ54Yg5FJnY0z+B6nwsr + xvBckdywjDS5tsFT8jOglzfQ7VUe4WTdbC0TVXIoYdzf0bY8WEz+03TmaBYN6MKC4iXc + 1bSWKfCF+XxFBm3xKZJLNZnkRP7hTtnkIVDGenyCmVszRZvBUhf+7Q1RaFOTCiNeN1Gp + T9QO6N4wcUjSWUVWWwgyWmR5ubzhyRfz9wlCAGFl2/zYhcvCrn5rZ6nrc3+M/3RV87Mo + 3rmg== +Received: by 10.152.148.197 with SMTP id tu5mr2456004lab.35.1354728298067; + Wed, 05 Dec 2012 09:24:58 -0800 (PST) +Received: from localhost (dsl-hkibrasgw4-fe51df00-27.dhcp.inet.fi. + [80.223.81.27]) + by mx.google.com with ESMTPS id fb1sm2485820lbb.15.2012.12.05.09.24.55 + (version=SSLv3 cipher=OTHER); Wed, 05 Dec 2012 09:24:56 -0800 (PST) +From: Jani Nikula +To: Mark Walters , notmuch@notmuchmail.org +Subject: Re: [PATCH 0/3] Use invisibility to toggle display of all parts + including multipart +In-Reply-To: <1354663662-20524-1-git-send-email-markwalters1009@gmail.com> +References: <1354663662-20524-1-git-send-email-markwalters1009@gmail.com> +User-Agent: Notmuch/0.14+140~gbe5119e (http://notmuchmail.org) Emacs/23.4.1 + (i686-pc-linux-gnu) +Date: Wed, 05 Dec 2012 19:24:54 +0200 +Message-ID: <87r4n4jtsp.fsf@nikula.org> +MIME-Version: 1.0 +Content-Type: text/plain; charset=us-ascii +X-Gm-Message-State: + ALoCoQljsWS/TpT3iqPFxaLMg2X1HQ8V+jN1XAiCFVEocr9xQQFrE1yowZaafYQDH9f43rStodmj +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Wed, 05 Dec 2012 17:25:03 -0000 + + +Hi Mark - + +On Wed, 05 Dec 2012, Mark Walters wrote: +> This patch aims to do the same as +> id:1354496317-24564-1-git-send-email-markwalters1009@gmail.com but +> rather than reloading the buffer it uses invisibility. +> +> Most of the invisibility stuff was taken from notmuch-wash and adapted +> to this situation. +> +> The general interface is that any part can have its visibility +> toggled: in this version by "t" on the part button. In addition "RET" +> on the part button of any "not shown" part will show it. + +I tested the patches (did not look at the code), and with the addition +of your RET patch on top, I think the series is perfect! I very much +like the functionality. Must have. + +> Whilst a main driver was being able to view different parts of a +> multipart/alternative message, this also allows the user to toggle +> images or large inline text attachments (eg text/x-tex) for +> example. Indeed, even multipart part buttons can be toggled which +> remove the whole tree beneath: it is unclear whether this last is useful. + +It's very nice that this is a general solution showing/hiding parts, and +the original multipart/alternative problem is just a special case this +handles. And if there's any more tweaking the special case needs, it +should be done on top of this series, afterwards. + +> The invisibility approach has some advantages over the reloading +> approach. It does not disrupt the rest of the buffer (eg +> collapsed/expanded citations remain), it does not require an extra +> call to the database with the possible addition of messages to the +> buffer, and it fits more naturally with the other hidden/not-hidden +> items. + +Yes, much better than the original (which already was good). + +Thanks for doing this. + +BR, +Jani. + + +> +> Best wishes +> +> Mark +> +> +> Mark Walters (3): +> emacs: show: modify insert-part-header to save the button text +> emacs: show: add overlays for each part +> emacs: show: add invisibility button action +> +> emacs/notmuch-show.el | 117 +++++++++++++++++++++++++++++++++++++++---------- +> 1 files changed, 93 insertions(+), 24 deletions(-) +> +> -- +> 1.7.9.1 +> +> _______________________________________________ +> notmuch mailing list +> notmuch@notmuchmail.org +> http://notmuchmail.org/mailman/listinfo/notmuch -- 2.26.2