From eec3e8a73b2a3a6ed41986e511dd877e83508fe7 Mon Sep 17 00:00:00 2001 From: Tomi Ollila Date: Sat, 20 Oct 2012 13:04:23 +0300 Subject: [PATCH] Re: [PATCH 7/8] lib: add NOTMUCH_EXCLUDE_FLAG to notmuch_exclude_t --- a2/821d12d247426c9c1922eb0e849ac8f4cd7630 | 88 +++++++++++++++++++++++ 1 file changed, 88 insertions(+) create mode 100644 a2/821d12d247426c9c1922eb0e849ac8f4cd7630 diff --git a/a2/821d12d247426c9c1922eb0e849ac8f4cd7630 b/a2/821d12d247426c9c1922eb0e849ac8f4cd7630 new file mode 100644 index 000000000..098e6d7ff --- /dev/null +++ b/a2/821d12d247426c9c1922eb0e849ac8f4cd7630 @@ -0,0 +1,88 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id D3BF3431FB6 + for ; Sat, 20 Oct 2012 03:04:20 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: 0 +X-Spam-Level: +X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] + autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id dHTXeMhI9sBk for ; + Sat, 20 Oct 2012 03:04:20 -0700 (PDT) +Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34]) + by olra.theworths.org (Postfix) with ESMTP id 6372B431FAE + for ; Sat, 20 Oct 2012 03:04:20 -0700 (PDT) +Received: from guru.guru-group.fi (localhost [IPv6:::1]) + by guru.guru-group.fi (Postfix) with ESMTP id 1CB5E1000E5; + Sat, 20 Oct 2012 13:04:23 +0300 (EEST) +From: Tomi Ollila +To: Ethan Glasser-Camp , notmuch@notmuchmail.org +Subject: Re: [PATCH 7/8] lib: add NOTMUCH_EXCLUDE_FLAG to notmuch_exclude_t +In-Reply-To: <87mwzi6tr6.fsf@betacantrips.com> +References: <1340198947-29370-1-git-send-email-novalazy@gmail.com> + <1340198947-29370-8-git-send-email-novalazy@gmail.com> + <87txtr6o0c.fsf@betacantrips.com> <87mwzi6tr6.fsf@betacantrips.com> +User-Agent: Notmuch/0.14+51~g62cd13b (http://notmuchmail.org) Emacs/24.2.1 + (x86_64-unknown-linux-gnu) +X-Face: HhBM'cA~ +MIME-Version: 1.0 +Content-Type: text/plain +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Sat, 20 Oct 2012 10:04:21 -0000 + +On Sat, Oct 20 2012, Ethan Glasser-Camp wrote: + +> Ethan Glasser-Camp writes: +> +>> It looks like you have better wording for patch 4/8 so I'd like to see +>> you resend it. +>> +>> I'm marking patches 3, 4, and 7 as moreinfo. Please resubmit! +> +> It turns out that patch 4 already has a v2 in the thread, but I didn't +> see it due to some kind of selective blindness. It would be nice if +> nmbug had grouped it as part of the same patch series. + +I noticed the same today when I tagged your NEWS patch. + +By looking contrib/nmbug/nmbug-status the reason seems obvious: +it iterates over messages and resets thread when thread id changes +(and message ordering is not based on threads). + +There is 2 ways to "fix" this: + +1) Iterate over threads and then messges over these threads. I looked +the bindings and this didn't seem so easy as one could imagine.. + +2) Iterate over messages like now, but cache the content to an objects +in hash where thread-id is the key. + +If no-one points me an easy way to do (1), I'll attempt (2) (in a distant +future ;) + +> +> I'm marking the old patch 4/8 obsolete. Only patch 3 and 7 remain. +> +> Ethan + +Tomi -- 2.26.2