From ecb866cd042eb0ec921ba2689eee2497ce0743db Mon Sep 17 00:00:00 2001 From: David Bremner Date: Sun, 2 Sep 2012 23:38:09 +2100 Subject: [PATCH] Re: [PATCH] test: make test_expect_equal_file() arguments flexible --- 17/3af4e98a41bd3a91d027cbf272b19878d9e256 | 69 +++++++++++++++++++++++ 1 file changed, 69 insertions(+) create mode 100644 17/3af4e98a41bd3a91d027cbf272b19878d9e256 diff --git a/17/3af4e98a41bd3a91d027cbf272b19878d9e256 b/17/3af4e98a41bd3a91d027cbf272b19878d9e256 new file mode 100644 index 000000000..5af29883b --- /dev/null +++ b/17/3af4e98a41bd3a91d027cbf272b19878d9e256 @@ -0,0 +1,69 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id D6DCA431FB6 + for ; Sat, 1 Sep 2012 19:38:15 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: 0 +X-Spam-Level: +X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] + autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id yCFyi2Poomlf for ; + Sat, 1 Sep 2012 19:38:15 -0700 (PDT) +Received: from tesseract.cs.unb.ca (tesseract.cs.unb.ca [131.202.240.238]) + (using TLSv1 with cipher AES256-SHA (256/256 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id 7BC7E431FAF + for ; Sat, 1 Sep 2012 19:38:15 -0700 (PDT) +Received: from fctnnbsc30w-156034089108.dhcp-dynamic.fibreop.nb.bellaliant.net + ([156.34.89.108] helo=zancas.localnet) + by tesseract.cs.unb.ca with esmtpsa + (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.72) + (envelope-from ) + id 1T804k-0007XT-Pz; Sat, 01 Sep 2012 23:38:14 -0300 +Received: from bremner by zancas.localnet with local (Exim 4.80) + (envelope-from ) + id 1T804f-0003ke-AS; Sat, 01 Sep 2012 23:38:09 -0300 +From: David Bremner +To: Dmitry Kurochkin , notmuch@notmuchmail.org +Subject: Re: [PATCH] test: make test_expect_equal_file() arguments flexible +In-Reply-To: <1328080794-24670-1-git-send-email-dmitry.kurochkin@gmail.com> +References: <1328080794-24670-1-git-send-email-dmitry.kurochkin@gmail.com> +User-Agent: Notmuch/0.14 (http://notmuchmail.org) Emacs/24.1.1 + (x86_64-pc-linux-gnu) +Date: Sat, 01 Sep 2012 23:38:09 -0300 +Message-ID: <87sjb1b14e.fsf@zancas.localnet> +MIME-Version: 1.0 +Content-Type: text/plain +X-Spam_bar: - +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Sun, 02 Sep 2012 02:38:16 -0000 + +Dmitry Kurochkin writes: + +> Before the change, test_expect_equal_file() function treated the first +> argument as "actual output file" and the second argument as "expected +> output file". When the test fails, the files are copied for later +> inspection. The first files was copied to "$testname.output" and the +> second file to "$testname.expected". The argument order for +> test_expect_equal_file() is often wrong which results in confusing +> diff output and incorrectly named files. + +pushed, + +d -- 2.26.2