From eb8ff5604e59db79c2910d6d2f5b81649b225d9b Mon Sep 17 00:00:00 2001 From: Jani Nikula Date: Sat, 5 May 2012 14:57:29 +0300 Subject: [PATCH] Re: [Patch v2 0/3] emacs: allow show to colour based on tags and flags --- 68/b70bcf3a5304ed03a25e3b8cebe0f6b17f5fdd | 142 ++++++++++++++++++++++ 1 file changed, 142 insertions(+) create mode 100644 68/b70bcf3a5304ed03a25e3b8cebe0f6b17f5fdd diff --git a/68/b70bcf3a5304ed03a25e3b8cebe0f6b17f5fdd b/68/b70bcf3a5304ed03a25e3b8cebe0f6b17f5fdd new file mode 100644 index 000000000..5db1427e9 --- /dev/null +++ b/68/b70bcf3a5304ed03a25e3b8cebe0f6b17f5fdd @@ -0,0 +1,142 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 1F334431FB6 + for ; Sat, 5 May 2012 04:57:43 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -0.321 +X-Spam-Level: +X-Spam-Status: No, score=-0.321 tagged_above=-999 required=5 + tests=[NO_DNS_FOR_FROM=0.379, RCVD_IN_DNSWL_LOW=-0.7] + autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id 3O9tiB1dPfbH for ; + Sat, 5 May 2012 04:57:36 -0700 (PDT) +Received: from mail-lpp01m010-f53.google.com (mail-lpp01m010-f53.google.com + [209.85.215.53]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id 424F3431FAE + for ; Sat, 5 May 2012 04:57:36 -0700 (PDT) +Received: by lahc1 with SMTP id c1so2834909lah.26 + for ; Sat, 05 May 2012 04:57:34 -0700 (PDT) +X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; + d=google.com; s=20120113; + h=from:to:cc:subject:in-reply-to:references:user-agent:date + :message-id:mime-version:content-type:x-gm-message-state; + bh=LGFyqXiZbVQ094o5PZVrwNi4GejyuF9VCfi0AIZO690=; + b=ck6iu1lxSL/W7SYRpz1/ezBJ1hGmzeM1S1JpCA4lIj+A20EfKbtUhrc2x9OD8FckMu + ttMlm1MabXBuomRUvC4r+ypXsSmfrE/Zw4zhy5qTRxdh5vQM18guWYURO63xKmMNesxV + a1fySgaGypEzzhCcq1Bf3ZLMpQTdN9PYBOe2ebnIa8wW/uEoonp8oUNZtpE7/DZ6h+T4 + 0hQ3VPDYGIspKVFt/5+Fa3yTeAff7x1XyVDNPBwdOUl8jodoh+o4PcSu1j3334IRZ6fb + ToBEYEqGoWeA6NjRfNRN3DsO6sFkR99d9n8MTag9Lv2sOoF1Ea40gRork8IxI4tlPAfT + PEmQ== +Received: by 10.112.102.136 with SMTP id fo8mr4406388lbb.106.1336219054645; + Sat, 05 May 2012 04:57:34 -0700 (PDT) +Received: from localhost (dsl-hkibrasgw4-fe50dc00-68.dhcp.inet.fi. + [80.220.80.68]) + by mx.google.com with ESMTPS id fx5sm14881446lbb.5.2012.05.05.04.57.31 + (version=SSLv3 cipher=OTHER); Sat, 05 May 2012 04:57:33 -0700 (PDT) +From: Jani Nikula +To: Mark Walters , + Jameson Graef Rollins , + Austin Clements +Subject: Re: [Patch v2 0/3] emacs: allow show to colour based on tags and + flags +In-Reply-To: <87txzw1otb.fsf@qmul.ac.uk> +References: <1335739697-8501-1-git-send-email-markwalters1009@gmail.com> + <20120429230220.GO2704@mit.edu> + <87397jwhjp.fsf@servo.finestructure.net> + <87txzw1otb.fsf@qmul.ac.uk> +User-Agent: Notmuch/0.12+169~g45438b0 (http://notmuchmail.org) Emacs/23.3.1 + (i686-pc-linux-gnu) +Date: Sat, 05 May 2012 14:57:29 +0300 +Message-ID: <878vh6j0wm.fsf@nikula.org> +MIME-Version: 1.0 +Content-Type: text/plain; charset=us-ascii +X-Gm-Message-State: + ALoCoQl7dPlJ5VrphF+KYZONHGQ55lsUFg+e6RnoaXG528amo+WTxbaPUgTuoaZ7hHklFt4jVLgu +Cc: notmuch@notmuchmail.org +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Sat, 05 May 2012 11:57:43 -0000 + +On Fri, 04 May 2012, Mark Walters wrote: +> On Wed, 02 May 2012, Jameson Graef Rollins wrote: +>> On Sun, Apr 29 2012, Austin Clements wrote: +>>> I haven't really looked at this series yet, but I do have a quick +>>> high-level question. Why use separate customization variables for the +>>> colors in search and show mode? Wouldn't it make more sense to set +>>> the colors just once and use them in both modes? +>> +>> I thought about this myself as soon as I read the patch. I think I +>> would always want the colors to match, so it would make sense to me to +>> set them in one place. +> +> Hi +> +> I think both are useful (see my reply to Austin) but having show apply +> the faces from notmuch-search first seems a good idea. +> +> There are a couple of extra reasons why I like the show ones +> separate. One is that I like to colour headerlines of matching messages to +> highlight them, but in search mode that would highlight every +> line. Secondly, I colour some things "negatively" in show mode: for +> example I show excluded messages in grey. This negative colouring does +> not make sense for search mode because I would only want to grey out +> results where all messages were excluded not results where at least one +> message is excluded. Of course we don't show entirely excluded threads +> in search, but similar comments apply to say the "replied" tag: I could +> show those in green (on the basis they are "dealt with") but I would not +> want a thread coloured green just because I have replied to one message +> in it. + +I completely agree with having separate faces for search and show. + +>>> BTW, I like how this clearly distinguishes tags and flags. I wonder +>>> if we could transition to flags for some information that's current +>>> shoe-horned into tags but actually represents immutable information +>>> about a message (attachment, signed, and encrypted or so). +>> +>> Yes! As Austin probably remembers, we've discussed this before. I +>> definitely agree that it makes sense to somehow distinguish "immutable" +>> information that is a fundamental, unchanging/able property of the +>> message, and it might be nice to look ahead to that here. +> +> In essence I agree: my only concern is can the user search for these +> immutable things, and what syntax is used there. + +Making a separation between immutable properties (like "attachment" or +"signed") and tags is a good goal, but AFAICS doing that right requires +changes all the way down to the library. I wouldn't worry about it at +all here. From emacs UI perspective they're all just tags. This is here +now, and works; there's no need to complicate matters when there's +nobody doing anything about the plumbing. Fixing this later is a trivial +matter compared to the plumbing work in cli and lib. + + +BR, +Jani. + + + +> +> Best wishes +> +> Mark +> _______________________________________________ +> notmuch mailing list +> notmuch@notmuchmail.org +> http://notmuchmail.org/mailman/listinfo/notmuch -- 2.26.2