From eb514819ac791875864b7be861eedc68390afbe1 Mon Sep 17 00:00:00 2001 From: Pieter Praet Date: Wed, 1 Feb 2012 14:46:19 +0100 Subject: [PATCH] Re: [PATCH] emacs: globally replace non-branching "(if COND (progn ..." with "(when ..." --- e7/92be12410bf27b3cd9cf7fdb5176e64ddb8f5f | 102 ++++++++++++++++++++++ 1 file changed, 102 insertions(+) create mode 100644 e7/92be12410bf27b3cd9cf7fdb5176e64ddb8f5f diff --git a/e7/92be12410bf27b3cd9cf7fdb5176e64ddb8f5f b/e7/92be12410bf27b3cd9cf7fdb5176e64ddb8f5f new file mode 100644 index 000000000..e538c4a66 --- /dev/null +++ b/e7/92be12410bf27b3cd9cf7fdb5176e64ddb8f5f @@ -0,0 +1,102 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id D9DCE429E5B + for ; Wed, 1 Feb 2012 05:48:24 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -0.7 +X-Spam-Level: +X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5 + tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id uov+nht-Kroi for ; + Wed, 1 Feb 2012 05:48:22 -0800 (PST) +Received: from mail-ww0-f45.google.com (mail-ww0-f45.google.com + [74.125.82.45]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client + certificate requested) by olra.theworths.org (Postfix) with ESMTPS id + 2A8AB431FAF for ; Wed, 1 Feb 2012 05:48:22 -0800 + (PST) +Received: by wgbdt12 with SMTP id dt12so1141819wgb.2 + for ; Wed, 01 Feb 2012 05:48:21 -0800 (PST) +Received: by 10.180.93.132 with SMTP id cu4mr11097687wib.9.1328104100875; + Wed, 01 Feb 2012 05:48:20 -0800 (PST) +Received: from localhost ([109.131.39.11]) + by mx.google.com with ESMTPS id t6sm44901431wid.1.2012.02.01.05.48.19 + (version=TLSv1/SSLv3 cipher=OTHER); + Wed, 01 Feb 2012 05:48:20 -0800 (PST) +From: Pieter Praet +To: David Edmondson , David Bremner , + Jani Nikula +Subject: Re: [PATCH] emacs: globally replace non-branching "(if COND (progn + ..." with "(when ..." +In-Reply-To: +References: <87k44uprvy.fsf@praet.org> + <1326532638-22068-1-git-send-email-pieter@praet.org> + <87y5ssxam7.fsf@zancas.localnet> + + <87ty3fycje.fsf@zancas.localnet> + +User-Agent: Notmuch/0.11+132~ga81001f (http://notmuchmail.org) Emacs/23.3.1 + (x86_64-unknown-linux-gnu) +Date: Wed, 01 Feb 2012 14:46:19 +0100 +Message-ID: <874nva7jkk.fsf@praet.org> +MIME-Version: 1.0 +Content-Type: text/plain; charset=us-ascii +Cc: Notmuch Mail +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Wed, 01 Feb 2012 13:48:25 -0000 + +On Mon, 30 Jan 2012 09:23:40 +0000, David Edmondson wrote: +> On Sat, 28 Jan 2012 13:14:45 -0400, David Bremner wrote: +> > On Sat, 28 Jan 2012 14:55:22 +0200, Jani Nikula wrote: +> > > On Jan 28, 2012 2:41 PM, "David Bremner" wrote: +> > > +> > > Sometimes someone (Dmitry?) sent patches that separated a small functional +> > > change, and the big non-functional indentation change it caused, +> > > separately. Would you prefer (or tolerate ;) that style? +> > +> > Hmm, that might be nicer, I'm not 100% sure. +> > +> > I wouldn't say it's mandatory for a patch like this (and I'd say other +> > peoples views on what's easy to review are at least as important as mine +> > here). +> +> Each patch should be valid in the repository without any following +> patches (preceding are obviously okay). Incorrect indentation would +> disqualify a patch from being 'valid', so it shouldn't be accepted. + ++1. + +Indentation corrections should always be part of the same patch as +the change(s) that invalidated the indentation in the first place. + +Spotting the *actual* (non-indentation) changes is a non-issue +when using `diff-refine-hunk' (or a wrapper thereof [1]). + + +> _______________________________________________ +> notmuch mailing list +> notmuch@notmuchmail.org +> http://notmuchmail.org/mailman/listinfo/notmuch + + +Peace + +-- +Pieter + +[1] id:"8739ax7jts.fsf@praet.org" -- 2.26.2