From e94875aaca0ccd1a6359842c0cccbfc2e5b71795 Mon Sep 17 00:00:00 2001 From: Jameson Graef Rollins Date: Thu, 29 Mar 2012 18:46:02 +1700 Subject: [PATCH] Re: [PATCH] emacs: Fix mis-named argument to notmuch-get-bodypart-internal --- 6d/7fe91069e9051f3ad5a66f11e558f54f4cd983 | 93 +++++++++++++++++++++++ 1 file changed, 93 insertions(+) create mode 100644 6d/7fe91069e9051f3ad5a66f11e558f54f4cd983 diff --git a/6d/7fe91069e9051f3ad5a66f11e558f54f4cd983 b/6d/7fe91069e9051f3ad5a66f11e558f54f4cd983 new file mode 100644 index 000000000..64c9b777b --- /dev/null +++ b/6d/7fe91069e9051f3ad5a66f11e558f54f4cd983 @@ -0,0 +1,93 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 3357F431FAF + for ; Wed, 28 Mar 2012 18:46:11 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -2.29 +X-Spam-Level: +X-Spam-Status: No, score=-2.29 tagged_above=-999 required=5 + tests=[RCVD_IN_DNSWL_MED=-2.3, T_MIME_NO_TEXT=0.01] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id wgw9NnA5MFdh for ; + Wed, 28 Mar 2012 18:46:10 -0700 (PDT) +Received: from outgoing-mail.its.caltech.edu (outgoing-mail.its.caltech.edu + [131.215.239.19]) + by olra.theworths.org (Postfix) with ESMTP id C80BD431FAE + for ; Wed, 28 Mar 2012 18:46:10 -0700 (PDT) +Received: from earth-doxen.imss.caltech.edu (localhost [127.0.0.1]) + by earth-doxen-postvirus (Postfix) with ESMTP id 18B8F66E0186; + Wed, 28 Mar 2012 18:46:10 -0700 (PDT) +X-Spam-Scanned: at Caltech-IMSS on earth-doxen by amavisd-new +Received: from finestructure.net (m17.ligo.caltech.edu [131.215.115.117]) + (Authenticated sender: jrollins) + by earth-doxen-submit (Postfix) with ESMTP id 22C9A66E00F3; + Wed, 28 Mar 2012 18:46:05 -0700 (PDT) +Received: by finestructure.net (Postfix, from userid 1000) + id F3D22E0; Wed, 28 Mar 2012 18:46:04 -0700 (PDT) +From: Jameson Graef Rollins +To: Austin Clements , notmuch@notmuchmail.org +Subject: Re: [PATCH] emacs: Fix mis-named argument to + notmuch-get-bodypart-internal +In-Reply-To: <1332812426-26684-1-git-send-email-amdragon@mit.edu> +References: <1332812426-26684-1-git-send-email-amdragon@mit.edu>User-Agent: + Notmuch/0.12+77~g8e9161b (http://notmuchmail.org) Emacs/23.3.1 + (x86_64-pc-linux-gnu) +Date: Wed, 28 Mar 2012 18:46:02 -0700 +Message-ID: <87ty18kwmd.fsf@servo.finestructure.net> +MIME-Version: 1.0 +Content-Type: multipart/signed; boundary="=-=-="; + micalg=pgp-sha256; protocol="application/pgp-signature" +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Thu, 29 Mar 2012 01:46:11 -0000 + +--=-=-= + +On Mon, Mar 26 2012, Austin Clements wrote: +> Previously, this function took an argument called "message-id", even +> though it was a general query, rather than a message ID. This changes +> it to "query". + +I'm sure the argument was named such because: the function is retrieving +a message part so the query has to match just a single message, and it's +only ever given a message id by anything that calls it. And it's an +unexposed internal function. All of this to say that I think it doesn't +really matter that the argument was named as it was. + +jamie. + +--=-=-= +Content-Type: application/pgp-signature + +-----BEGIN PGP SIGNATURE----- +Version: GnuPG v1.4.12 (GNU/Linux) + +iQIcBAEBCAAGBQJPc77aAAoJEO00zqvie6q8lwcP/0qN6VLJ0hyTs/dEvKxz8kBQ +BieOr7pAn8h6xAMb/6oLjXyHw0ufNF9XLfrcON7vtgR6UkkEyGQ4S3FmrhpXnyyz +oRLBfJACW7g5ZiSCN4jnJSZRrXnwgTwjz5aHi9NUoYWN4U+aTfnYemqV84drIutQ +ukuRmlsbzJJnVUwVh88GW4u2+b4T7Kul4YJO5Wq1TAgKyS89a3/giAmxTVXFlQgB +RspGstzgE8QUXFjJR5XhQS4CG6D5CnSNVP7DTtkidB8BOkOXcppFN60XmCeGXHsf +ol6LiQTdnp7Mt8i7w0P7k4A/bJND5+G/xoh+LcoNzHg0Mt4livMHM23A1bs8/azT +g7UBkh/H4qtPto6+TYgAxLsF9+pTDK/qsJObz5UG7Xn6NiWpRjJTfkY3NksKnrgF +jMEpwr2UlTuZSoP3X7G+8fJrYiVRC62mZWFeqXRomYNttySuSSVSTZrggIFjYdu+ +Mzx33nENWFxuCl1Q79ccqg0bVZk4VdaWBjoXz4Eqpsw5nTRspcHUieHNls2leeER +vZlfV1Vk5wnQOHmiZR/8LSThLn3Oo8XFI8sRCRsYugfe4Q3BHdwHuLo0AEw+dsYi +I2URhTnspqRTwlaIJdZTMQrY1xfy18eK9lEkesX10K6vAdWKObuuPBt7Cc3o+GAY +J2YDBbhG5Pthm1B75Q6M +=mWFS +-----END PGP SIGNATURE----- +--=-=-=-- -- 2.26.2