From e803c03c68e82bb53a96adfa35455a8771dc6461 Mon Sep 17 00:00:00 2001 From: Mark Walters Date: Wed, 18 Jul 2012 22:54:48 +0100 Subject: [PATCH] Re: [PATCH] emacs: Make moving to the previous message move to the previous boundary --- f5/613c17ffdef48a977f5aa5d91e51137f6792ab | 144 ++++++++++++++++++++++ 1 file changed, 144 insertions(+) create mode 100644 f5/613c17ffdef48a977f5aa5d91e51137f6792ab diff --git a/f5/613c17ffdef48a977f5aa5d91e51137f6792ab b/f5/613c17ffdef48a977f5aa5d91e51137f6792ab new file mode 100644 index 000000000..13ea02912 --- /dev/null +++ b/f5/613c17ffdef48a977f5aa5d91e51137f6792ab @@ -0,0 +1,144 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id BF286431FB6 + for ; Wed, 18 Jul 2012 14:54:58 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -1.098 +X-Spam-Level: +X-Spam-Status: No, score=-1.098 tagged_above=-999 required=5 + tests=[DKIM_ADSP_CUSTOM_MED=0.001, FREEMAIL_FROM=0.001, + NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id JpBIvdJ4azrD for ; + Wed, 18 Jul 2012 14:54:58 -0700 (PDT) +Received: from mail2.qmul.ac.uk (mail2.qmul.ac.uk [138.37.6.6]) + (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id 1ABF3431FAF + for ; Wed, 18 Jul 2012 14:54:58 -0700 (PDT) +Received: from smtp.qmul.ac.uk ([138.37.6.40]) + by mail2.qmul.ac.uk with esmtp (Exim 4.71) + (envelope-from ) + id 1SrcCn-00024F-Ea; Wed, 18 Jul 2012 22:54:49 +0100 +Received: from 94-192-233-223.zone6.bethere.co.uk ([94.192.233.223] + helo=localhost) + by smtp.qmul.ac.uk with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.69) + (envelope-from ) + id 1SrcCn-0001bQ-4l; Wed, 18 Jul 2012 22:54:49 +0100 +From: Mark Walters +To: Austin Clements , notmuch@notmuchmail.org +Subject: Re: [PATCH] emacs: Make moving to the previous message move to the + previous boundary +In-Reply-To: <1342237668-2489-1-git-send-email-amdragon@mit.edu> +References: <1342237668-2489-1-git-send-email-amdragon@mit.edu> +User-Agent: Notmuch/0.13.2+90~g84fa1ef (http://notmuchmail.org) Emacs/23.4.1 + (x86_64-pc-linux-gnu) +Date: Wed, 18 Jul 2012 22:54:48 +0100 +Message-ID: <87sjcod9av.fsf@qmul.ac.uk> +MIME-Version: 1.0 +Content-Type: text/plain; charset=us-ascii +X-Sender-Host-Address: 94.192.233.223 +X-QM-SPAM-Info: Sender has good ham record. :) +X-QM-Body-MD5: 4648ca5fd1a1c0bef1bbd607d0bab38e (of first 20000 bytes) +X-SpamAssassin-Score: -1.8 +X-SpamAssassin-SpamBar: - +X-SpamAssassin-Report: The QM spam filters have analysed this message to + determine if it is + spam. We require at least 5.0 points to mark a message as spam. + This message scored -1.8 points. + Summary of the scoring: + * -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at http://www.dnswl.org/, + * medium trust + * [138.37.6.40 listed in list.dnswl.org] + * 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail + provider * (markwalters1009[at]gmail.com) + * -0.0 T_RP_MATCHES_RCVD Envelope sender domain matches handover relay + * domain + * 0.5 AWL AWL: From: address is in the auto white-list +X-QM-Scan-Virus: ClamAV says the message is clean +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Wed, 18 Jul 2012 21:54:58 -0000 + +On Sat, 14 Jul 2012, Austin Clements wrote: +> Previously, notmuch-show-previous-message would move to the beginning +> of the message before the message containing point. This patch makes +> it instead move to the previous message *boundary*. That is, if point +> isn't already at the beginning of the message, it moves to the +> beginning of the current message. This is consistent with +> notmuch-show-next-message, which can be thought of as moving to the +> next message boundary. Several people have expressed a preference for +> this. + +I like this change: the current behaviour has mildly confused/annoyed me +in the past. + +> +> This patch accompanies the series in [0] (though they're independent +> and can be applied in either order). This makes the behavior of 'p' +> and 'P' in show-mode conceptually similar to the new behavior of 'p' +> in search-mode. +> +> [0] 1342140319-19859-1-git-send-email-amdragon@mit.edu +> +> emacs/notmuch-show.el | 10 +++++++--- +> 1 file changed, 7 insertions(+), 3 deletions(-) +> +> diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el +> index 6335d45..02e319f 100644 +> --- a/emacs/notmuch-show.el +> +++ b/emacs/notmuch-show.el +> @@ -1525,9 +1525,11 @@ thread, navigate to the next thread in the parent search buffer." +> (goto-char (point-max))))) +> +> (defun notmuch-show-previous-message () +> - "Show the previous message." +> + "Show the previous message or the start of the current message." +> (interactive) +> - (notmuch-show-goto-message-previous) +> + (if (= (point) (notmuch-show-message-top)) +> + (notmuch-show-goto-message-previous) +> + (notmuch-show-move-to-message-top)) +> (notmuch-show-mark-read) +> (notmuch-show-message-adjust)) +> +> @@ -1587,7 +1589,9 @@ to show, nil otherwise." +> (defun notmuch-show-previous-open-message () +> "Show the previous open message." +> (interactive) +> - (while (and (notmuch-show-goto-message-previous) +> + (while (and (if (= (point) (notmuch-show-message-top)) +> + (notmuch-show-goto-message-previous) +> + (notmuch-show-move-to-message-top)) +> (not (notmuch-show-message-visible-p)))) +> (notmuch-show-mark-read) +> (notmuch-show-message-adjust)) + +I would mildly prefer taking the testing for top of message out of the +loop (I know it's one line longer) as + + (if (= (point) (notmuch-show-message-top)) + (notmuch-show-goto-message-previous) + (notmuch-show-move-to-message-top)) + (while (and (not (notmuch-show-message-visible-p)) + (notmuch-show-goto-message-previous))) + +but its obviously fine as is. + +Best wishes + +Mark -- 2.26.2