From e6d143cd5bd92bede5f5e2ce6ad5bd0376c050e1 Mon Sep 17 00:00:00 2001 From: David Bremner Date: Tue, 19 Feb 2013 21:13:41 +2000 Subject: [PATCH] Re: [PATCH 1/6] lib: Clean up error handling in _notmuch_thread_create --- ca/d703f16ed30d519d410162a83128c1d1b429be | 66 +++++++++++++++++++++++ 1 file changed, 66 insertions(+) create mode 100644 ca/d703f16ed30d519d410162a83128c1d1b429be diff --git a/ca/d703f16ed30d519d410162a83128c1d1b429be b/ca/d703f16ed30d519d410162a83128c1d1b429be new file mode 100644 index 000000000..39626f61f --- /dev/null +++ b/ca/d703f16ed30d519d410162a83128c1d1b429be @@ -0,0 +1,66 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 8361A431FB6 + for ; Mon, 18 Feb 2013 17:13:50 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: 0 +X-Spam-Level: +X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] + autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id aw4SY35i+f-H for ; + Mon, 18 Feb 2013 17:13:49 -0800 (PST) +Received: from tesseract.cs.unb.ca (tesseract.cs.unb.ca [131.202.240.238]) + (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id B207E431FAF + for ; Mon, 18 Feb 2013 17:13:49 -0800 (PST) +Received: from fctnnbsc30w-156034082078.dhcp-dynamic.fibreop.nb.bellaliant.net + ([156.34.82.78] helo=zancas.localnet) + by tesseract.cs.unb.ca with esmtpsa + (TLS1.2:DHE_RSA_AES_128_CBC_SHA1:128) (Exim 4.80) + (envelope-from ) + id 1U7bmG-0005mM-0d; Mon, 18 Feb 2013 21:13:48 -0400 +Received: from bremner by zancas.localnet with local (Exim 4.80) + (envelope-from ) + id 1U7bm9-0003EI-Tn; Mon, 18 Feb 2013 21:13:42 -0400 +From: David Bremner +To: Austin Clements , notmuch@notmuchmail.org +Subject: Re: [PATCH 1/6] lib: Clean up error handling in + _notmuch_thread_create +In-Reply-To: <1353819427-13182-2-git-send-email-amdragon@mit.edu> +References: <1353819427-13182-1-git-send-email-amdragon@mit.edu> + <1353819427-13182-2-git-send-email-amdragon@mit.edu> +User-Agent: Notmuch/0.15.2+32~g16aa65b (http://notmuchmail.org) Emacs/24.2.1 + (x86_64-pc-linux-gnu) +Date: Mon, 18 Feb 2013 21:13:41 -0400 +Message-ID: <87fw0tumuy.fsf@zancas.localnet> +MIME-Version: 1.0 +Content-Type: text/plain +X-Spam_bar: - +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Tue, 19 Feb 2013 01:13:50 -0000 + +Austin Clements writes: + +> Previously, there were various opportunities for memory leaks in the +> error-handling paths of this function. Use a local talloc context and +> some reparenting to make eliminate these leaks, while keeping the +> control flow simple. + +pushed all but the python bindings patch. -- 2.26.2