From e6944110fce689ce67ab6f66a270a3e2319466a3 Mon Sep 17 00:00:00 2001 From: David Bremner Date: Sun, 20 Jan 2013 14:33:25 +2000 Subject: [PATCH] Re: [PATCH 1/1] devel/release-checks.sh: version string problem does not halt execution --- a8/11c650e1aa6e50a03f6be36044166723b4405e | 72 +++++++++++++++++++++++ 1 file changed, 72 insertions(+) create mode 100644 a8/11c650e1aa6e50a03f6be36044166723b4405e diff --git a/a8/11c650e1aa6e50a03f6be36044166723b4405e b/a8/11c650e1aa6e50a03f6be36044166723b4405e new file mode 100644 index 000000000..f51464b5e --- /dev/null +++ b/a8/11c650e1aa6e50a03f6be36044166723b4405e @@ -0,0 +1,72 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 886A1431FCF + for ; Sat, 19 Jan 2013 10:34:03 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: 0 +X-Spam-Level: +X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] + autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id M5e5b+zW-Mmz for ; + Sat, 19 Jan 2013 10:34:03 -0800 (PST) +Received: from tesseract.cs.unb.ca (tesseract.cs.unb.ca [131.202.240.238]) + (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id 30F60431FBF + for ; Sat, 19 Jan 2013 10:34:03 -0800 (PST) +Received: from fctnnbsc30w-156034082078.dhcp-dynamic.fibreop.nb.bellaliant.net + ([156.34.82.78] helo=zancas.localnet) + by tesseract.cs.unb.ca with esmtpsa + (TLS1.2:DHE_RSA_AES_128_CBC_SHA1:128) (Exim 4.80) + (envelope-from ) + id 1TwdEv-00083U-Gu; Sat, 19 Jan 2013 14:34:02 -0400 +Received: from bremner by zancas.localnet with local (Exim 4.80) + (envelope-from ) + id 1TwdEL-0008NI-Rg; Sat, 19 Jan 2013 14:33:25 -0400 +From: David Bremner +To: Tomi Ollila , notmuch@notmuchmail.org +Subject: Re: [PATCH 1/1] devel/release-checks.sh: version string problem does + not halt execution +In-Reply-To: <1358561597-4241-1-git-send-email-tomi.ollila@iki.fi> +References: <1358561597-4241-1-git-send-email-tomi.ollila@iki.fi> +User-Agent: Notmuch/0.15 (http://notmuchmail.org) Emacs/24.2.1 + (x86_64-pc-linux-gnu) +Date: Sat, 19 Jan 2013 14:33:25 -0400 +Message-ID: <87y5fpauq2.fsf@zancas.localnet> +MIME-Version: 1.0 +Content-Type: text/plain +X-Spam_bar: - +Cc: tomi.ollila@iki.fi +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Sat, 19 Jan 2013 18:34:03 -0000 + +Tomi Ollila writes: + +> Version string has strict format requirements in release-check.sh: +> only numbers and periods (in sane order) are accepted. +> Mismatch there used to halt further execution. +> In this case, checking versions like '*~rc1' for (more) problems +> was not possible. +> This 'fatal error' is now changed buffered error message like in +> following tests, and is displayed at the end of execution. + +pushed. That's probably good enough, given the small userbase of this +script. + +d -- 2.26.2