From e472e80fc451c073f1cc7becbb6f9f530d274475 Mon Sep 17 00:00:00 2001 From: Adam Wolfe Gordon Date: Thu, 19 Apr 2012 11:36:36 +1800 Subject: [PATCH] Re: [PATCH v2 0/3] composing patches --- 8c/62f94e6f0bb0aa2ae9f82cb959e5b22703ea58 | 118 ++++++++++++++++++++++ 1 file changed, 118 insertions(+) create mode 100644 8c/62f94e6f0bb0aa2ae9f82cb959e5b22703ea58 diff --git a/8c/62f94e6f0bb0aa2ae9f82cb959e5b22703ea58 b/8c/62f94e6f0bb0aa2ae9f82cb959e5b22703ea58 new file mode 100644 index 000000000..fde777ae6 --- /dev/null +++ b/8c/62f94e6f0bb0aa2ae9f82cb959e5b22703ea58 @@ -0,0 +1,118 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 5194F431FB6 + for ; Wed, 18 Apr 2012 10:36:39 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -0.7 +X-Spam-Level: +X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5 + tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id ikW8f8CctOd4 for ; + Wed, 18 Apr 2012 10:36:38 -0700 (PDT) +Received: from mail-lpp01m010-f53.google.com (mail-lpp01m010-f53.google.com + [209.85.215.53]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id A15C5431FAE + for ; Wed, 18 Apr 2012 10:36:38 -0700 (PDT) +Received: by lahc1 with SMTP id c1so6037950lah.26 + for ; Wed, 18 Apr 2012 10:36:37 -0700 (PDT) +X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; + d=google.com; s=20120113; + h=mime-version:sender:x-originating-ip:in-reply-to:references:date + :x-google-sender-auth:message-id:subject:from:to:cc:content-type + :content-transfer-encoding:x-gm-message-state; + bh=PBLAWRvQ0mlo41cgoo2N7O8+C5lkd/AUJaVkKCAysLg=; + b=LiP70Qb+86OxuV71VJpZggvayBH7ISvQqXlPjaWVZqJkOBexkuFindUlk5Y17IehEu + tU+P2DaadYS/VmAhNYw4jpEPvoo9FWkWTLwpKfEY/bi9bt8nhjZmwzPp6SI9hZLKtAEc + dpl0amHuCItUSOklMs8f5GPPk/grr/Zsokh5z+ZvNnHNTG8630SXpQrjoK9qGIy19fuH + xiQ1SbxOYtxxfhR5e3f1fem7jWIlp3YfEXy6XYI4mcHczgBR/0NMf5glK68hsrmhrVSh + s0BFQm2xs0YPEBsSbH/SNvrsk3z3BeyWZwGmS8QO0Umtx+OlFRy0F41SOeBRRe+nTALM + 01BQ== +MIME-Version: 1.0 +Received: by 10.112.98.70 with SMTP id eg6mr1518119lbb.13.1334770596938; Wed, + 18 Apr 2012 10:36:36 -0700 (PDT) +Sender: awg@xvx.ca +Received: by 10.112.23.39 with HTTP; Wed, 18 Apr 2012 10:36:36 -0700 (PDT) +X-Originating-IP: [128.221.197.57] +In-Reply-To: <1334752753-23970-1-git-send-email-felipe.contreras@gmail.com> +References: <1334752753-23970-1-git-send-email-felipe.contreras@gmail.com> +Date: Wed, 18 Apr 2012 11:36:36 -0600 +X-Google-Sender-Auth: Lai21sVIhadXB4ncuAsYsxGwiA0 +Message-ID: + +Subject: Re: [PATCH v2 0/3] composing patches +From: Adam Wolfe Gordon +To: Felipe Contreras +Content-Type: text/plain; charset=ISO-8859-1 +Content-Transfer-Encoding: quoted-printable +X-Gm-Message-State: + ALoCoQlRAR+aFFGJd+OZJIw9XMwYImIYNFOpPW8x8t+xzfxpdSW5un4vpDgZKTfKCSIBhMmRZs8f +Cc: notmuch@notmuchmail.org +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Wed, 18 Apr 2012 17:36:39 -0000 + +Hi Felipe, + +On Wed, Apr 18, 2012 at 06:39, Felipe Contreras + wrote: +> I don't know how it works in gnus, but at least on the vim mode, the outp= +ut +> generated by 'notmuch reply' is not ready to be sent, at least the Messag= +e-ID +> field is needed, and also is nice to have the User-Agent. + +In the emacs interface, the Message-ID header is generated when the +message is sent, so it never shows up in the reply buffer. The +User-Agent header is created by the emacs reply code. + +> Besides, in order to avoid creating a new message by hand (possibly fetch= +ing +> the info from notmuch config), it's more straightforward to have 'notmuch +> compose' command. +> +> In the future 'notmuch compose' might be used to replace 'notmuch reply' = +and +> possily add a forward option too. It might also be possible to add mail a= +liases +> when composing a message, and these aliases might be used while generatin= +g the +> 'notmuch search' output. + +I can see how this functionality is useful, and I like the idea of +consolidating message creation, forwarding, and reply. However, if +this is intended to replace or share code with reply (and I think it +should), it should support all the existing reply formats: default, +json, and headers-only. + +In fact, I think it might make more sense to make this work an +extension of the existing reply code rather than a rewrite. +notmuch-reply.c could become notmuch-compose.c, and provide the +compose command (with flags for creating a reply), and also the reply +command (which would just be an alias to the compose functionality). + +> =A0Makefile.local =A0 =A0| =A0 =A01 + +> =A0notmuch-client.h =A0| =A0 =A03 ++ +> =A0notmuch-compose.c | =A0111 +++++++++++++++++++++++++++++++++++++++++++= +++++++++++ +> =A0notmuch-reply.c =A0 | =A0 17 ++++++++ +> =A0notmuch.c =A0 =A0 =A0 =A0 | =A0 =A05 +++ + +Such a big new features should definitely have some tests. + +-- Adam -- 2.26.2