From e4529412d6e7559b298c037701a1500f25496b35 Mon Sep 17 00:00:00 2001 From: David Bremner Date: Sun, 19 Aug 2012 16:03:03 +0200 Subject: [PATCH] Re: [PATCH] devel: add release-checks.sh --- 31/ba98831d5170781538be237cda4c4cf1d00611 | 72 +++++++++++++++++++++++ 1 file changed, 72 insertions(+) create mode 100644 31/ba98831d5170781538be237cda4c4cf1d00611 diff --git a/31/ba98831d5170781538be237cda4c4cf1d00611 b/31/ba98831d5170781538be237cda4c4cf1d00611 new file mode 100644 index 000000000..3d1481237 --- /dev/null +++ b/31/ba98831d5170781538be237cda4c4cf1d00611 @@ -0,0 +1,72 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id A673D431FB6 + for ; Mon, 20 Aug 2012 00:18:10 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: 0.804 +X-Spam-Level: +X-Spam-Status: No, score=0.804 tagged_above=-999 required=5 + tests=[DATE_IN_PAST_12_24=0.804] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id a6AbsqZo+zwC for ; + Mon, 20 Aug 2012 00:18:09 -0700 (PDT) +Received: from tesseract.cs.unb.ca (tesseract.cs.unb.ca [131.202.240.238]) + (using TLSv1 with cipher AES256-SHA (256/256 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id DEDE3431FC2 + for ; Mon, 20 Aug 2012 00:18:08 -0700 (PDT) +Received: from remotemail by tesseract.cs.unb.ca with local (Exim 4.72) + (envelope-from ) + id 1T3MFT-0002Ea-DR; Mon, 20 Aug 2012 04:18:07 -0300 +Received: (nullmailer pid 24990 invoked by uid 1000); + Sun, 19 Aug 2012 14:03:03 -0000 +From: David Bremner +To: Tomi Ollila , notmuch@notmuchmail.org +Subject: Re: [PATCH] devel: add release-checks.sh +In-Reply-To: <1344456107-19308-1-git-send-email-tomi.ollila@iki.fi> +References: <1344456107-19308-1-git-send-email-tomi.ollila@iki.fi> +User-Agent: Notmuch/0.13.2+76~gac7b542 (http://notmuchmail.org) Emacs/24.1.1 + (x86_64-pc-linux-gnu) +Date: Sun, 19 Aug 2012 16:03:03 +0200 +Message-ID: <87y5lbkmi0.fsf@maritornes.cs.unb.ca> +MIME-Version: 1.0 +Content-Type: text/plain +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Mon, 20 Aug 2012 07:18:11 -0000 + +Tomi Ollila writes: + +> Currently Makefile.local contains some machine executable release +> checking functionality. This is unnecessarily complex way to do it: + +Hi Tomi; + +Overall this looks good, but there seems to be one minor bug: + +- If there are extra files under man/man1 (e.g. from "make + update-versions"), then the check "Checking that manual page dates and + versions" fails, even if it passes after running "git clean -fx" + +I don't really think this is a blocker, but on the other hand it isn't +urgent to ship the patch either. + +Another piece of Makefile.local that isn't really "make" is +"update-versions". On the other hand, it isn't nearly as long or +complicated as the release checks. + +d -- 2.26.2