From e28ed7302f280af416ab579dd09e663ef111274e Mon Sep 17 00:00:00 2001 From: Charlie Allom Date: Mon, 14 May 2012 13:42:16 +0100 Subject: [PATCH] Re: [PATCH] ruby: extern linkage portability improvement --- 25/0d619b60ccdfa8e959477a1a6ca4941f14cde2 | 79 +++++++++++++++++++++++ 1 file changed, 79 insertions(+) create mode 100644 25/0d619b60ccdfa8e959477a1a6ca4941f14cde2 diff --git a/25/0d619b60ccdfa8e959477a1a6ca4941f14cde2 b/25/0d619b60ccdfa8e959477a1a6ca4941f14cde2 new file mode 100644 index 000000000..ce455e213 --- /dev/null +++ b/25/0d619b60ccdfa8e959477a1a6ca4941f14cde2 @@ -0,0 +1,79 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 4F69E431FBC + for ; Mon, 14 May 2012 06:07:52 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: 0 +X-Spam-Level: +X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] + autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id baRfcSNf1R1a for ; + Mon, 14 May 2012 06:07:51 -0700 (PDT) +Received: from mail.playlouder.com (mail.playlouder.com [94.228.66.7]) + by olra.theworths.org (Postfix) with ESMTP id 75DEB431FAE + for ; Mon, 14 May 2012 06:07:51 -0700 (PDT) +Received: from localhost (localhost.localdomain [127.0.0.1]) + by mail.playlouder.com (Postfix) with ESMTP id 21DC752009; + Mon, 14 May 2012 13:07:48 +0000 (UTC) +X-Virus-Scanned: Debian amavisd-new at mail.playlouder.com +Received: from mail.playlouder.com ([127.0.0.1]) + by localhost (mail.playlouder.com [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id lmKdO0bHy-4h; Mon, 14 May 2012 13:07:47 +0000 (UTC) +Received: from spodder.com (capslock.playlouder.com [94.228.68.132]) + by mail.playlouder.com (Postfix) with ESMTPSA id B8EAB5205A; + Mon, 14 May 2012 12:42:17 +0000 (UTC) +Date: Mon, 14 May 2012 13:42:16 +0100 +From: Charlie Allom +To: Tomi Ollila +Subject: Re: [PATCH] ruby: extern linkage portability improvement +Message-ID: <20120514124213.GA14081@spodder.com> +References: <1336669964-24231-1-git-send-email-tomi.ollila@iki.fi> +MIME-Version: 1.0 +Content-Type: text/plain; charset=us-ascii +Content-Disposition: inline +In-Reply-To: <1336669964-24231-1-git-send-email-tomi.ollila@iki.fi> +User-Agent: Mutt/1.5.21 (2010-09-15) +Cc: notmuch@notmuchmail.org +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Mon, 14 May 2012 13:07:52 -0000 + +On Thu, May 10, 2012 at 08:12:44PM +0300, Tomi Ollila wrote: +> Some C compilers are stricter when it comes to (tentative) definition +> of a variable -- in those compilers introducing variable without 'extern' +> keyword always allocates new 'storage' to the variable and linking all +> these modules fails due to duplicate symbols. +> +> This change uses some macro trickery to avoid writing every variable twice. +> +> This is reimplementation of Charlie Allom's patch: +> id:"1336481467-66356-1-git-send-email-charlie@mediasp.com" +> +> combining information from other change made by Ali Polatel. +> --- +> +> Charlie: could you test whether this patch actually work ? :) + +Hi Tomi, + +This works for me. + + C. +-- + +442077294797 + http://mediasp.com/ -- 2.26.2