From e10b22175fd7d1b2d7f44db1719c64e3e6797861 Mon Sep 17 00:00:00 2001 From: Jani Nikula Date: Sun, 2 Dec 2012 17:44:56 +0200 Subject: [PATCH] Re: v3 of testing for new tagging/dump/restore --- 55/7abdc63030404507b362fb1dbb4016c00e698b | 101 ++++++++++++++++++++++ 1 file changed, 101 insertions(+) create mode 100644 55/7abdc63030404507b362fb1dbb4016c00e698b diff --git a/55/7abdc63030404507b362fb1dbb4016c00e698b b/55/7abdc63030404507b362fb1dbb4016c00e698b new file mode 100644 index 000000000..5b7f7a0de --- /dev/null +++ b/55/7abdc63030404507b362fb1dbb4016c00e698b @@ -0,0 +1,101 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id E1A8A431FAF + for ; Sun, 2 Dec 2012 07:45:02 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -0.7 +X-Spam-Level: +X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5 + tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id ibftsmhU52lf for ; + Sun, 2 Dec 2012 07:45:00 -0800 (PST) +Received: from mail-la0-f53.google.com (mail-la0-f53.google.com + [209.85.215.53]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id A0CE6431FAE + for ; Sun, 2 Dec 2012 07:45:00 -0800 (PST) +Received: by mail-la0-f53.google.com with SMTP id w12so1692887lag.26 + for ; Sun, 02 Dec 2012 07:44:59 -0800 (PST) +X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; + d=google.com; s=20120113; + h=from:to:subject:in-reply-to:references:user-agent:date:message-id + :mime-version:content-type:x-gm-message-state; + bh=rlG74D+RZqQk3qiuW0A491AGYhgS65cUfhqhAbspz8k=; + b=fp5D8x6o+91WE4yb5blH6fm53pHmo5Gk5S9/cLYd7srwewFy7BJBslvJAmI+xBQA6W + Z8LLOo3PPNzRgs7PjPrknearsmc15+pS6Ngqgay+apfh0t7srIWzgY/McuN/yX8RqA5+ + KXrS5SSzLbgY3pePHgtLsnTxifj4NKutlgPUJBpSMyz1QrUnFmP+CQHGlniks7wyqNea + Cx98bBffx33W16w3lYOAtyiai2LneyxvaJ0t31UMk53YeO4P3WjvHsM2k2/raiWPWTgk + BSK6p8PVBBP8Qv6AcjOZbajW/k1MPFKpTA/g5d31FQr7StVGZEW2X3R1nieMQJL467Uy + HJjg== +Received: by 10.152.114.65 with SMTP id je1mr6944740lab.33.1354463099151; + Sun, 02 Dec 2012 07:44:59 -0800 (PST) +Received: from localhost (dsl-hkibrasgw4-fe51df00-27.dhcp.inet.fi. + [80.223.81.27]) + by mx.google.com with ESMTPS id fb1sm4242800lbb.15.2012.12.02.07.44.57 + (version=SSLv3 cipher=OTHER); Sun, 02 Dec 2012 07:44:58 -0800 (PST) +From: Jani Nikula +To: david@tethera.net, notmuch@notmuchmail.org +Subject: Re: v3 of testing for new tagging/dump/restore +In-Reply-To: <1354455204-6908-1-git-send-email-david@tethera.net> +References: <1354455204-6908-1-git-send-email-david@tethera.net> +User-Agent: Notmuch/0.14+124~g3b17402 (http://notmuchmail.org) Emacs/23.4.1 + (i686-pc-linux-gnu) +Date: Sun, 02 Dec 2012 17:44:56 +0200 +Message-ID: <87lidgcvbb.fsf@nikula.org> +MIME-Version: 1.0 +Content-Type: text/plain; charset=us-ascii +X-Gm-Message-State: + ALoCoQmJUWgS1lviQrgewmBAVduXZcaTtOzrV5gbP3fPVGevcWESrvu0XnVK417Z2kEnKUYbUZ9B +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Sun, 02 Dec 2012 15:45:03 -0000 + + +LGTM, +Jani. + +On Sun, 02 Dec 2012, david@tethera.net wrote: +> Here is round 3 of the batch tagging stuff, but just the first six +> patches, which are more or less useful without the remaining one +> (although a bit epic if the only goal is add a single test). +> +> Detailed list of changes follows, the first one is a change to the +> encoding format. Looking forward to maybe doing tricks with maildirs +> and hardlinks, it seems like we might want to encode ':'. The fact +> that it might help MacOS X users we can consider neutral ;). +> +> - hex-escape.c: escape ':' +> - hex-escape.c: simpler buffer size calculations. +> - hex-xcode.c: uncrustify + delete extra blank lines +> - hex-xcode.c: provide inplace mode for test coverage +> - test/hex-escaping, copy tests for --in-place version of test +> - test/database-test.c: only thaw if we froze +> - random-corpus.c: use a table based scheme to favour shorted code points +> - random-corpus.c: uncrustify +> - random-corpus.c: delete blank line, reorder while loop +> - update roundtrip test to avoid need for random-corpus tag. +> - do not add tag "random-corpus" in random-corpus.c +> +> Things that I (knowingly) ignored +> +> - Jani suggested an extra talloc in random-corpus.c +> - I left the argument format of hex-xcode alone +> _______________________________________________ +> notmuch mailing list +> notmuch@notmuchmail.org +> http://notmuchmail.org/mailman/listinfo/notmuch -- 2.26.2