From e0d368eead33221dda621de4003b071ce3f6c3b1 Mon Sep 17 00:00:00 2001 From: Ethan Glasser-Camp Date: Thu, 25 Oct 2012 21:59:16 +2000 Subject: [PATCH] Re: [PATCH] test: Fix HTML rendering test --- de/dacb673bb9121473b1ea419d30f4ea674b4039 | 98 +++++++++++++++++++++++ 1 file changed, 98 insertions(+) create mode 100644 de/dacb673bb9121473b1ea419d30f4ea674b4039 diff --git a/de/dacb673bb9121473b1ea419d30f4ea674b4039 b/de/dacb673bb9121473b1ea419d30f4ea674b4039 new file mode 100644 index 000000000..a4cfc5fd3 --- /dev/null +++ b/de/dacb673bb9121473b1ea419d30f4ea674b4039 @@ -0,0 +1,98 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 02E01431FAF + for ; Wed, 24 Oct 2012 18:59:24 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -0.799 +X-Spam-Level: +X-Spam-Status: No, score=-0.799 tagged_above=-999 required=5 + tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, + FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id wHslWDA5x8fj for ; + Wed, 24 Oct 2012 18:59:23 -0700 (PDT) +Received: from mail-vc0-f181.google.com (mail-vc0-f181.google.com + [209.85.220.181]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id 71ABD431FAE + for ; Wed, 24 Oct 2012 18:59:22 -0700 (PDT) +Received: by mail-vc0-f181.google.com with SMTP id n11so1347890vch.26 + for ; Wed, 24 Oct 2012 18:59:21 -0700 (PDT) +DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; + h=from:to:subject:in-reply-to:references:user-agent:date:message-id + :mime-version:content-type; + bh=7+cyEnxKJXqX4l/3vY/SbPzc0/cDNOfT9ugI75bqGfU=; + b=RmaQN3VDNniHBkUuhRkUVh7CrKwiTBMaJnbXnbNhDuNUr3otYd7DUFpLskwTpUObgI + xbExLDP8yNKzs3eR0obc9GsvezNZYdKMEJgmgA0OEozZ4YdKKMyl9AXbwf/Ur8OX/SVo + owt+xJkG3JjlpRmjsrx5ggkztIaMPFN5hTWX5+Mqi3TKaAB+RTwZI2CGuGERUvs68RR2 + JpDLD1Pdw4B9r6028mrO+ur81bdTbd1RUETpo2bYUmhvRgvIVY0XKC7SGGzVg9UYLEoG + uNrdiK14rM2AspzAMItHY4VVSCTB0J/2uVAI2zFYzWUtZmOP86Vn/0TJrNQagmsODqOF + tGhg== +Received: by 10.52.89.35 with SMTP id bl3mr23976701vdb.87.1351130361712; + Wed, 24 Oct 2012 18:59:21 -0700 (PDT) +Received: from smtp.gmail.com (p70-80.acedsl.com. [66.114.70.80]) + by mx.google.com with ESMTPS id f10sm17803564vdk.5.2012.10.24.18.59.18 + (version=TLSv1/SSLv3 cipher=OTHER); + Wed, 24 Oct 2012 18:59:20 -0700 (PDT) +From: Ethan Glasser-Camp +To: Austin Clements , notmuch@notmuchmail.org +Subject: Re: [PATCH] test: Fix HTML rendering test +In-Reply-To: <1351109160-11105-1-git-send-email-amdragon@mit.edu> +References: <1351109160-11105-1-git-send-email-amdragon@mit.edu> +User-Agent: Notmuch/0.14+45~g6ea9330 (http://notmuchmail.org) Emacs/23.4.1 + (x86_64-pc-linux-gnu) +Date: Wed, 24 Oct 2012 21:59:16 -0400 +Message-ID: <873913joqz.fsf@betacantrips.com> +MIME-Version: 1.0 +Content-Type: text/plain; charset=us-ascii +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Thu, 25 Oct 2012 01:59:25 -0000 + +Austin Clements writes: + +> The test designed to exercise Emacs' rendering of HTML emails +> containing images inadvertently assumed w3m was available under Emacs +> 23. The real point of this test was to exercise Emacs 24's shr +> renderer, so if shr isn't available, we now fall back to html2text, +> which comes with Emacs. + +Hi! I'm eager to apply any patch here that makes this better. But this +one doesn't fix it for me (24.1.1, although it seems to work with +23.4.1). OUTPUT is "*\nsmiley " (no space after the asterisk or before +the word smiley, but after). I see that this sed command is supposed to +normalize things, but at least on my setup, it doesn't. I also see "nil" +written to console, but I have no idea what that's about. + +More generally, I guess I don't understand exactly what this test is +supposed to be exercising. The commit message says "the shr renderer", +but what about it? In +id:"1348941314-8377-4-git-send-email-amdragon@mit.edu" you write that +using shr raised a void-variable error previously, so maybe we're making +sure that error doesn't show up? In that case, even my semi-broken +output is good enough. + +In a perfect world, test probably shouldn't succeed if shr isn't +present, but should note that it wasn't run. Maybe the emacs lisp code +can check for shr, and if it's not present, write "shr not present" to +an output file, and the shell code can grep for that and then call +test_skip if it sees it? + +Still, I'm excited that you're working on this so please let's get it +fixed! + +Ethan -- 2.26.2