From e0a0ee64c2cc7adc740733fb54b28bce95ccab04 Mon Sep 17 00:00:00 2001 From: David Edmondson Date: Mon, 6 Feb 2012 08:56:34 +0000 Subject: [PATCH] Re: [PATCH 2/2 v2] emacs: Prefer '[No Subject]' to blank subjects. --- 06/b57b18d7d30218f2b55a3689b13afc7e93f1e5 | 113 ++++++++++++++++++++++ 1 file changed, 113 insertions(+) create mode 100644 06/b57b18d7d30218f2b55a3689b13afc7e93f1e5 diff --git a/06/b57b18d7d30218f2b55a3689b13afc7e93f1e5 b/06/b57b18d7d30218f2b55a3689b13afc7e93f1e5 new file mode 100644 index 000000000..7997029bd --- /dev/null +++ b/06/b57b18d7d30218f2b55a3689b13afc7e93f1e5 @@ -0,0 +1,113 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 5F457431FAF + for ; Mon, 6 Feb 2012 00:56:43 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -0.7 +X-Spam-Level: +X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5 + tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id UZJ9uOT1HV9K for ; + Mon, 6 Feb 2012 00:56:42 -0800 (PST) +Received: from mail-we0-f181.google.com (mail-we0-f181.google.com + [74.125.82.181]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id A2FF0431FAE + for ; Mon, 6 Feb 2012 00:56:42 -0800 (PST) +Received: by werb10 with SMTP id b10so4948789wer.26 + for ; Mon, 06 Feb 2012 00:56:41 -0800 (PST) +Received: by 10.216.139.97 with SMTP id b75mr2912119wej.0.1328518601272; + Mon, 06 Feb 2012 00:56:41 -0800 (PST) +Received: from hotblack-desiato.hh.sledj.net + (host81-149-164-25.in-addr.btopenworld.com. [81.149.164.25]) + by mx.google.com with ESMTPS id l8sm44445312wiy.5.2012.02.06.00.56.39 + (version=TLSv1/SSLv3 cipher=OTHER); + Mon, 06 Feb 2012 00:56:40 -0800 (PST) +Received: by hotblack-desiato.hh.sledj.net (Postfix, from userid 30000) + id 0DC9FA0484; Mon, 6 Feb 2012 08:56:38 +0000 (GMT) +To: Jameson Graef Rollins , + notmuch@notmuchmail.org +Subject: Re: [PATCH 2/2 v2] emacs: Prefer '[No Subject]' to blank subjects. +In-Reply-To: <87obtcbd29.fsf@servo.finestructure.net> +References: <1327496913-4946-1-git-send-email-dme@dme.org> + <1327918561-16245-1-git-send-email-dme@dme.org> + <1327918561-16245-3-git-send-email-dme@dme.org> + <87sjiobfu1.fsf@servo.finestructure.net> + + <87obtcbd29.fsf@servo.finestructure.net> +User-Agent: Notmuch/0.11.1+152~g2c6710e (http://notmuchmail.org) + Emacs/24.0.92.1 (x86_64-pc-linux-gnu) +From: David Edmondson +Date: Mon, 06 Feb 2012 08:56:34 +0000 +Message-ID: +MIME-Version: 1.0 +Content-Type: multipart/signed; boundary="=-=-="; + micalg=pgp-sha1; protocol="application/pgp-signature" +X-Gm-Message-State: + ALoCoQmUODSIOcRwU6QLgwS2KCpqkvJAu+KOPaCwNdOmTeBpTr5S9K2CyVh6OyVn1vAp0DGNQqap +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Mon, 06 Feb 2012 08:56:43 -0000 + +--=-=-= +Content-Type: text/plain +Content-Transfer-Encoding: quoted-printable + +On Mon, 06 Feb 2012 00:06:54 -0800, Jameson Graef Rollins wrote: +> On Mon, 06 Feb 2012 07:47:38 +0000, David Edmondson wrote: +> > On Sun, 05 Feb 2012 23:07:02 -0800, Jameson Graef Rollins wrote: +> > > Sorry to be so late on this, but I'm not a big fan of this new featur= +e. +> > > I would prefer to always see the subject (or any other field for that +> > > matter) as is. +> >=20 +> > The Emacs UI always replaced blank subjects with '[No Subject]' in +> > buffer names. The printing code also needed something other than a blank +> > subject for buffer renaming. +>=20 +> I don't much care what the buffer name is. That seems to be a +> completely different issue to me. + +I agree that they could be treated differently. + +With blank subjects the printing code generated an error (because +`rename-buffer' doesn't like an empty string as the first argument), so +_some_ change is required. + +> > Updating `notmuch-prettify-subject' to use a user configurable string +> > (that can be set to the empty string) sounds like a good idea. Please +> > ensure that the various other bits of code that require something other +> > than a blank subject still work properly. +>=20 +> I am actually perfectly happy to see this patch reverted. + +Whatever bremner decides. + +--=-=-= +Content-Type: application/pgp-signature + +-----BEGIN PGP SIGNATURE----- +Version: GnuPG v1.4.11 (GNU/Linux) + +iEYEARECAAYFAk8vlcIACgkQaezQq/BJZRaQWACfcu5lV+2cVdj4/Hw1LYIivFI7 +vA4AnArmPyqisnMeCSMLEb+o2HfRedKk +=vWXE +-----END PGP SIGNATURE----- +--=-=-=-- -- 2.26.2