From e043b252d45c49fbcef1196c057b6709b126f1bf Mon Sep 17 00:00:00 2001 From: David Bremner Date: Tue, 22 Jan 2013 08:24:42 +2000 Subject: [PATCH] test suite crash with TERM=dumb --- 02/6d5ccf3451c4117972b83488dbb365c99bd1e2 | 100 ++++++++++++++++++++++ 1 file changed, 100 insertions(+) create mode 100644 02/6d5ccf3451c4117972b83488dbb365c99bd1e2 diff --git a/02/6d5ccf3451c4117972b83488dbb365c99bd1e2 b/02/6d5ccf3451c4117972b83488dbb365c99bd1e2 new file mode 100644 index 000000000..111fc68dc --- /dev/null +++ b/02/6d5ccf3451c4117972b83488dbb365c99bd1e2 @@ -0,0 +1,100 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 9318F431FAF + for ; Mon, 21 Jan 2013 04:26:00 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: 0 +X-Spam-Level: +X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] + autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id 6kyXtqjbbNNS for ; + Mon, 21 Jan 2013 04:25:56 -0800 (PST) +Received: from tesseract.cs.unb.ca (tesseract.cs.unb.ca [131.202.240.238]) + (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id 83449431FBD + for ; Mon, 21 Jan 2013 04:25:56 -0800 (PST) +Received: from fctnnbsc30w-156034082078.dhcp-dynamic.fibreop.nb.bellaliant.net + ([156.34.82.78] helo=zancas.localnet) + by tesseract.cs.unb.ca with esmtpsa + (TLS1.2:DHE_RSA_AES_128_CBC_SHA1:128) (Exim 4.80) + (envelope-from ) + id 1TxGRi-00079i-4X; Mon, 21 Jan 2013 08:25:50 -0400 +Received: from bremner by zancas.localnet with local (Exim 4.80) + (envelope-from ) + id 1TxGQd-00045c-7V; Mon, 21 Jan 2013 08:24:43 -0400 +From: David Bremner +To: "notmuch mailing list" +Subject: test suite crash with TERM=dumb +User-Agent: Notmuch/0.15 (http://notmuchmail.org) Emacs/24.2.1 + (x86_64-pc-linux-gnu) +Date: Mon, 21 Jan 2013 08:24:42 -0400 +Message-ID: <87obgibu5x.fsf@zancas.localnet> +MIME-Version: 1.0 +Content-Type: multipart/signed; boundary="=-=-="; + micalg=pgp-sha1; protocol="application/pgp-signature" +X-Spam_bar: - +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Mon, 21 Jan 2013 12:26:00 -0000 + +--=-=-= +Content-Type: text/plain +Content-Transfer-Encoding: quoted-printable + + +In 0.15 (or current master) try running=20 + + % TERM=3Ddump make test + +At least for me and the Debian build daemons, this causes the run to end +with + + PASS Show message: json, utf-8 + FATAL: Unexpected exit with code 1 + make: *** [test] Error 124 + +This is much worse than a test failure since it causes the build to exit +with non-zero status. + +I have temporarily disabled running the test suite in the debian +packaging, but this is obviously not a good permanent solution. + +Apparently the problem is on the line=20 + + TERM=3D$ORIGINAL_TERM dtach -n "$TEST_TMPDIR/emacs-dtach-socket.$$"=20 + +It would be easy to hardcode the TERM for dtach, but I'm not sure if +there is some advantage to testing with the user's actual term? Also, I +guess we'd have to be careful the chosen terminal type is portable. + +d + +--=-=-= +Content-Type: application/pgp-signature + +-----BEGIN PGP SIGNATURE----- +Version: GnuPG v1.4.12 (GNU/Linux) + +iJwEAQECAAYFAlD9M4oACgkQTiiN/0Um85lJ0AP/Z5U20RNR5ku4fwkoMxOfQhOE +pE0CKjCVMoN0lfs+G9dGijPNBuYH1DYI/0nX3/d/R3c+F1xNtCAPHEEqa3bC7Wsb +9uIvP+pdW2Cj+LnxizWTJbMs0jYKKMyj1DMQen1TwtZ12RlLGSchUa7vGytyt179 +YnotLUcRYX20PyaAzNA= +=/que +-----END PGP SIGNATURE----- +--=-=-=-- -- 2.26.2