From e03d50ced5c099ed2d24c5be15e1313d66baf4b6 Mon Sep 17 00:00:00 2001 From: Mark Walters Date: Wed, 20 Jun 2012 21:08:05 +0100 Subject: [PATCH] Re: [PATCH 4/8] man: clarify search --exclude documentation --- a9/f7a8173aa4c8e0715a880607218e9bec58d475 | 94 +++++++++++++++++++++++ 1 file changed, 94 insertions(+) create mode 100644 a9/f7a8173aa4c8e0715a880607218e9bec58d475 diff --git a/a9/f7a8173aa4c8e0715a880607218e9bec58d475 b/a9/f7a8173aa4c8e0715a880607218e9bec58d475 new file mode 100644 index 000000000..90e06b21c --- /dev/null +++ b/a9/f7a8173aa4c8e0715a880607218e9bec58d475 @@ -0,0 +1,94 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id A0B49431FC0 + for ; Wed, 20 Jun 2012 13:08:13 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -1.098 +X-Spam-Level: +X-Spam-Status: No, score=-1.098 tagged_above=-999 required=5 + tests=[DKIM_ADSP_CUSTOM_MED=0.001, FREEMAIL_FROM=0.001, + NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id IeUkcW7vogcI for ; + Wed, 20 Jun 2012 13:08:12 -0700 (PDT) +Received: from mail2.qmul.ac.uk (mail2.qmul.ac.uk [138.37.6.6]) + (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id B3C75431FBF + for ; Wed, 20 Jun 2012 13:08:12 -0700 (PDT) +Received: from smtp.qmul.ac.uk ([138.37.6.40]) + by mail2.qmul.ac.uk with esmtp (Exim 4.71) + (envelope-from ) + id 1ShRCC-0005ys-Hx; Wed, 20 Jun 2012 21:08:08 +0100 +Received: from 94-192-233-223.zone6.bethere.co.uk ([94.192.233.223] + helo=localhost) + by smtp.qmul.ac.uk with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.69) + (envelope-from ) + id 1ShRCC-0003GS-BX; Wed, 20 Jun 2012 21:08:08 +0100 +From: Mark Walters +To: Peter Wang , notmuch@notmuchmail.org +Subject: Re: [PATCH 4/8] man: clarify search --exclude documentation +In-Reply-To: <1340198947-29370-5-git-send-email-novalazy@gmail.com> +References: <1340198947-29370-1-git-send-email-novalazy@gmail.com> + <1340198947-29370-5-git-send-email-novalazy@gmail.com> +User-Agent: Notmuch/0.13.2+63~g548a9bf (http://notmuchmail.org) Emacs/23.4.1 + (x86_64-pc-linux-gnu) +Date: Wed, 20 Jun 2012 21:08:05 +0100 +Message-ID: <87ehp93fx6.fsf@qmul.ac.uk> +MIME-Version: 1.0 +Content-Type: text/plain; charset=us-ascii +X-Sender-Host-Address: 94.192.233.223 +X-QM-SPAM-Info: Sender has good ham record. :) +X-QM-Body-MD5: 6a3db29cdfd4c9847d6f1458932b103e (of first 20000 bytes) +X-SpamAssassin-Score: -1.8 +X-SpamAssassin-SpamBar: - +X-SpamAssassin-Report: The QM spam filters have analysed this message to + determine if it is + spam. We require at least 5.0 points to mark a message as spam. + This message scored -1.8 points. + Summary of the scoring: + * -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at http://www.dnswl.org/, + * medium trust + * [138.37.6.40 listed in list.dnswl.org] + * 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail + provider * (markwalters1009[at]gmail.com) + * -0.0 T_RP_MATCHES_RCVD Envelope sender domain matches handover relay + * domain + * 0.5 AWL AWL: From: address is in the auto white-list +X-QM-Scan-Virus: ClamAV says the message is clean +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Wed, 20 Jun 2012 20:08:13 -0000 + + +I have reviewed all the new parts of this series (judged as being +patches 3-8) and the changes made to my two patches and they are all +fine (with one small comment below). Patch 1/8 does need a proper review +though as it ended up more intrusive than I would have liked. + +> +Messages matching search.tag_exclude are called "excluded messages". + +My one comment is that this is not quite true if the corresponding tag +is in the query. Since you are defining the term it would be nice to +mention that, but I can't see a clean wording. + +This should not hold up the series as it your wording is clearly an +improvement on the current wording. + +Best wishes + +Mark -- 2.26.2