From dfd2c18396d613b8b07d38635367b3f5fd23dd73 Mon Sep 17 00:00:00 2001 From: Tomi Ollila Date: Thu, 18 Oct 2012 13:05:43 +0300 Subject: [PATCH] Re: [PATCH 1/2] test: add check for filename argument for test_expect_equal_file --- 1e/1ffa17c610886b341529847611efd0fd9ff41b | 94 +++++++++++++++++++++++ 1 file changed, 94 insertions(+) create mode 100644 1e/1ffa17c610886b341529847611efd0fd9ff41b diff --git a/1e/1ffa17c610886b341529847611efd0fd9ff41b b/1e/1ffa17c610886b341529847611efd0fd9ff41b new file mode 100644 index 000000000..97cd0bacb --- /dev/null +++ b/1e/1ffa17c610886b341529847611efd0fd9ff41b @@ -0,0 +1,94 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 989C8431FBD + for ; Thu, 18 Oct 2012 03:05:40 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: 0 +X-Spam-Level: +X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] + autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id 99jr2Ssm7y2I for ; + Thu, 18 Oct 2012 03:05:40 -0700 (PDT) +Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34]) + by olra.theworths.org (Postfix) with ESMTP id 1D3EE431FB6 + for ; Thu, 18 Oct 2012 03:05:40 -0700 (PDT) +Received: from guru.guru-group.fi (localhost [IPv6:::1]) + by guru.guru-group.fi (Postfix) with ESMTP id 130B31000E5; + Thu, 18 Oct 2012 13:05:43 +0300 (EEST) +From: Tomi Ollila +To: Ethan Glasser-Camp , notmuch@notmuchmail.org +Subject: Re: [PATCH 1/2] test: add check for filename argument for + test_expect_equal_file +In-Reply-To: <87vcefa8ov.fsf@betacantrips.com> +References: <1328141050-30356-1-git-send-email-dmitry.kurochkin@gmail.com> + <1328141050-30356-2-git-send-email-dmitry.kurochkin@gmail.com> + <87zkd1p12c.fsf@servo.finestructure.net> + <87sjishv3e.fsf@gmail.com> <87vcefa8ov.fsf@betacantrips.com> +User-Agent: Notmuch/0.14+51~g62cd13b (http://notmuchmail.org) Emacs/24.2.1 + (x86_64-unknown-linux-gnu) +X-Face: HhBM'cA~ +MIME-Version: 1.0 +Content-Type: text/plain +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Thu, 18 Oct 2012 10:05:40 -0000 + +On Fri, Oct 12 2012, Ethan Glasser-Camp wrote: + +> Dmitry Kurochkin writes: +> +>> Actually, we can do both: check file name for consistent diff order +>> (from expected to actual) and use file names that the caller provides. +> +> Hi! Reviewing the patch queue a little bit here. It seems like this +> patch ended up getting dropped because the other approach (using the +> filenames that the caller provided) won out and was even pushed. I'm +> therefore marking this series notmuch::obsolete (and also +> notmuch::stale since it doesn't apply cleanly). + +I think stale is unnecessary and inconvenient when patch is marked +obsolete + +1) it is easier to look for stale patches by just searching stale tag +2) most obsolete patch goes stale at later time + +If no-one resists I'll execute + +notmuch tag -notmuch::stale tag:notmuch::obsolete + +in near future (I take silence as an approval :D). + +Currently: + +notmuch search --output=messages tag:notmuch::stale and tag:notmuch::obsolete + +id:1334077496-9172-3-git-send-email-markwalters1009@gmail.com +id:1334077496-9172-2-git-send-email-markwalters1009@gmail.com +id:1331402091-15663-1-git-send-email-tom.prince@ualberta.net +id:1328141050-30356-2-git-send-email-dmitry.kurochkin@gmail.com +id:1327985666-29191-3-git-send-email-dmitry.kurochkin@gmail.com +id:1327961195-4204-2-git-send-email-dmitry.kurochkin@gmail.com +id:1327926286-16680-2-git-send-email-dmitry.kurochkin@gmail.com +id:1325986015-22510-5-git-send-email-jrollins@finestructure.net + + +Tomi -- 2.26.2