From de98c05cf7520ab72a60fef630746b61abc38aa0 Mon Sep 17 00:00:00 2001 From: Jameson Graef Rollins Date: Sun, 3 Jun 2012 11:16:01 +1700 Subject: [PATCH] [PATCH] config: add quoting to fix IFS bug --- d8/37bd1e646961516b905e18dfb1e5ab298a9d73 | 76 +++++++++++++++++++++++ 1 file changed, 76 insertions(+) create mode 100644 d8/37bd1e646961516b905e18dfb1e5ab298a9d73 diff --git a/d8/37bd1e646961516b905e18dfb1e5ab298a9d73 b/d8/37bd1e646961516b905e18dfb1e5ab298a9d73 new file mode 100644 index 000000000..414ae0088 --- /dev/null +++ b/d8/37bd1e646961516b905e18dfb1e5ab298a9d73 @@ -0,0 +1,76 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 154A0431FB6 + for ; Sat, 2 Jun 2012 11:16:07 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -2.3 +X-Spam-Level: +X-Spam-Status: No, score=-2.3 tagged_above=-999 required=5 + tests=[RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id gYv6-jAggg0v for ; + Sat, 2 Jun 2012 11:16:05 -0700 (PDT) +Received: from outgoing-mail.its.caltech.edu (outgoing-mail.its.caltech.edu + [131.215.239.19]) + by olra.theworths.org (Postfix) with ESMTP id 86929431FAF + for ; Sat, 2 Jun 2012 11:16:05 -0700 (PDT) +Received: from earth-doxen.imss.caltech.edu (localhost [127.0.0.1]) + by earth-doxen-postvirus (Postfix) with ESMTP id 0717966E0131 + for ; Sat, 2 Jun 2012 11:16:05 -0700 (PDT) +X-Spam-Scanned: at Caltech-IMSS on earth-doxen by amavisd-new +Received: from finestructure.net (unknown [76.89.192.57]) + (Authenticated sender: jrollins) + by earth-doxen-submit (Postfix) with ESMTP id 42F6B66E00ED + for ; Sat, 2 Jun 2012 11:16:03 -0700 (PDT) +Received: by finestructure.net (Postfix, from userid 1000) + id EA8E03A7; Sat, 2 Jun 2012 11:16:01 -0700 (PDT) +From: Jameson Graef Rollins +To: Notmuch Mail +Subject: [PATCH] config: add quoting to fix IFS bug +Date: Sat, 2 Jun 2012 11:16:01 -0700 +Message-Id: <1338660961-13760-1-git-send-email-jrollins@finestructure.net> +X-Mailer: git-send-email 1.7.10 +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Sat, 02 Jun 2012 18:16:07 -0000 + +Without proper quoting the DEFAULT_IFS was getting set incorrectly, +which was causing problems with the storage of some variables later in +the script. Quoting fixes the problem. +--- +Thanks to Tomi for the inspiration for this fix. I don't know how I +missed such a simple solution initially. + + configure | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +diff --git a/configure b/configure +index 5602be2..3fad424 100755 +--- a/configure ++++ b/configure +@@ -1,7 +1,7 @@ + #! /bin/sh + + # Store original IFS value so it can be changed (and restored) in many places. +-readonly DEFAULT_IFS=$IFS ++readonly DEFAULT_IFS="$IFS" + + srcdir=$(dirname "$0") + +-- +1.7.10 + -- 2.26.2