From db77ee89fe7f60421931ccbbb276c7954357a3bb Mon Sep 17 00:00:00 2001 From: Daniel Schoepe Date: Mon, 5 Mar 2012 22:08:39 +0100 Subject: [PATCH] Re: [PATCH v2] emacs: Pass a copy to notmuch-saved-search-sort-function --- 84/1953ac42633b9a0996cffd2e307bf02f16b76f | 145 ++++++++++++++++++++++ 1 file changed, 145 insertions(+) create mode 100644 84/1953ac42633b9a0996cffd2e307bf02f16b76f diff --git a/84/1953ac42633b9a0996cffd2e307bf02f16b76f b/84/1953ac42633b9a0996cffd2e307bf02f16b76f new file mode 100644 index 000000000..34986532e --- /dev/null +++ b/84/1953ac42633b9a0996cffd2e307bf02f16b76f @@ -0,0 +1,145 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 421FF431FAF + for ; Mon, 5 Mar 2012 13:08:52 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -0.8 +X-Spam-Level: +X-Spam-Status: No, score=-0.8 tagged_above=-999 required=5 + tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, + RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id QCKuWVwyAJIN for ; + Mon, 5 Mar 2012 13:08:50 -0800 (PST) +Received: from mail-ey0-f181.google.com (mail-ey0-f181.google.com + [209.85.215.181]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id 01296431FAE + for ; Mon, 5 Mar 2012 13:08:49 -0800 (PST) +Received: by eaa1 with SMTP id 1so2249775eaa.26 + for ; Mon, 05 Mar 2012 13:08:47 -0800 (PST) +Received-SPF: pass (google.com: domain of daniel@schoepe.org designates + 10.213.9.198 as permitted sender) client-ip=10.213.9.198; +Authentication-Results: mr.google.com; + spf=pass (google.com: domain of daniel@schoepe.org + designates 10.213.9.198 as permitted sender) + smtp.mail=daniel@schoepe.org; + dkim=pass header.i=daniel@schoepe.org +Received: from mr.google.com ([10.213.9.198]) + by 10.213.9.198 with SMTP id m6mr157107ebm.65.1330981727494 (num_hops = + 1); Mon, 05 Mar 2012 13:08:47 -0800 (PST) +DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=schoepe.org; s=google; + h=from:to:cc:subject:in-reply-to:references:user-agent:date + :message-id:mime-version:content-type; + bh=Ij5Q6NPTzI7csWOPGKNjabx4rGNey44uKo+LxRdCcoE=; + b=W8mk7Mz/sR12A3bGlFh6rjwMUT++AeL9ceqB8t/e7SsubRXKMcxAaXf6ZuLtdfPIX3 + bLHDOi/o54df3EjRY4kmSHtyKfiKq3vjTtnMJBVwChUDfVkTVP0DLfGr1md5AD2B4zAz + /FYFwUe6gS4NkL9lGTN+f2LuFogS1HJL+Q56Y= +X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; + d=google.com; s=20120113; + h=from:to:cc:subject:in-reply-to:references:user-agent:date + :message-id:mime-version:content-type:x-gm-message-state; + bh=Ij5Q6NPTzI7csWOPGKNjabx4rGNey44uKo+LxRdCcoE=; + b=OtYe3oISTB7mwMMZbsM0krmml7rZXZUx5Ie6FJzFDA4qJ0edh5Cje2ExaYTB/ges3C + 1A0QSWfa5KLz/xtbXHabvICOIltjqg80U8nMKtgflVbjPGBnRQ1RilMl8xgHzfHOTIOW + DOGFjG4ioXCc7+DJdtd0hE1rj8T/ppGeqZlZFjBnCq5/1WiESZtwqNcDw3OpZDskIvTZ + nThi3A866/U202F7fBiTtQc7y203dH7oaKMAKSfyH9x3ncIxdq4XkAtQJa+dIQk5uFFY + oRbh2U/u3h0AtT2fKyRYrqdp5WWy7Ejw8JLPjr/aFL0KPz56zxnmRYS2aUIJ601fPAhs + sosg== +Received: by 10.213.9.198 with SMTP id m6mr122947ebm.65.1330981727273; + Mon, 05 Mar 2012 13:08:47 -0800 (PST) +Received: from localhost (dslb-088-069-139-015.pools.arcor-ip.net. + [88.69.139.15]) + by mx.google.com with ESMTPS id v51sm65689844eef.2.2012.03.05.13.08.45 + (version=TLSv1/SSLv3 cipher=OTHER); + Mon, 05 Mar 2012 13:08:46 -0800 (PST) +From: Daniel Schoepe +To: Jani Nikula , + Dmitry Kurochkin +Subject: Re: [PATCH v2] emacs: Pass a copy to + notmuch-saved-search-sort-function +In-Reply-To: + +References: <1330613059-5130-1-git-send-email-daniel@schoepe.org> + <1330613059-5130-2-git-send-email-daniel@schoepe.org> + +User-Agent: Notmuch/0.11.1+308~g28fc8d0 (http://notmuchmail.org) + Emacs/24.0.93.1 (x86_64-pc-linux-gnu) +Date: Mon, 05 Mar 2012 22:08:39 +0100 +Message-ID: <87y5rekb6w.fsf@schoepe.localhost> +MIME-Version: 1.0 +Content-Type: multipart/signed; boundary="=-=-="; + micalg=pgp-sha1; protocol="application/pgp-signature" +X-Gm-Message-State: + ALoCoQnT8WrUpHuIGZlKKBaS8pXayywHnvCsqygouDDUgq6jm3anrROkIUA6vPEc1+NIRuyQYt/k +Cc: notmuch@notmuchmail.org +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Mon, 05 Mar 2012 21:08:52 -0000 + +--=-=-= +Content-Type: text/plain +Content-Transfer-Encoding: quoted-printable + +On Mar 5, 2012 5:43 PM, "Dmitry Kurochkin" +> I do not buy the argument that we should help users who implement their +> own sorting functions but do not read documentation for functions they +> use. Apparently, those who implemented the `sort' function had similar +> ideas. And I do not think it is our job to add workarounds for it. + +Yeah that also sounds a bit more consistent, I guess my perception was +colored by my surprise at learning that sort has side effects in elisp. :) + +On Mon, 5 Mar 2012 22:55:54 +0200, Jani Nikula wrote: +> Providing the customization of the sort function is more powerful than the +> compare function. In the case of saved searches I can imagine people might +> want to partially use the original order while sort the rest (e.g. +> important ones first in predefined order, others sorted). In fact this al= +so +> allows dropping out some elements. And renaming. And changing the queries= +... +>=20 +> (I had something like that in mind originally but then settled with just +> capitalizing the important ones to show them first.) + +I have the same objections to only providing a customization option for +comparing. + +Cheers, +Daniel + +--=-=-= +Content-Type: application/pgp-signature + +-----BEGIN PGP SIGNATURE----- +Version: GnuPG v1.4.12 (GNU/Linux) + +iQIcBAEBAgAGBQJPVStXAAoJEIaTAtce+Z+JbyEP+gPwAZBTknluKBrDDws7z+m2 +Pd3Pe3XNYCLzTnTsD0fJgAhkM5P0P0BiwMZI3D+2ct2sTNYIJuQ35+NN/gz1eNOa +E7ooLocpX2ufQSnSyxzVU8VVEQ7VqZ/AA6PFKuCBe8WJnR0Q3c48ti2N8htWuB6U +RJv+YIXqmMhgBBKDkpuEb3XZAqbntnQRYX13IG6/iJ8kBDqGDp57f7XEsFRfepV2 +CuoCILilu7t7yhQ5HCDGYC897QlTBBrhnJk3wXv7lW4B1q9Q6Q0M8TvRs5Wpl6Dz +F/ppyxC4AjLp7Es2W0rWY4V2cc47qJyXH1fsGaHOq1eEc/vYIPXvQAOKtez4FmjD +mRvtmMYSFJmoSUcLBcke/NkHQfGaxFYFiY85cwII81Wq7AATx3wvxuiADe3ZS+7+ +V4Umn2ukSHfft76nfffmYVxxwCu8wpJuvekLwQeqnVNcmd5RG5V3iIYWUQpoxEuB +ZFhVV8VXMwNOGpihagWiNkx3OGHlgVL42HPso14By8YcmmSgBVzbii2b/X3Byu45 +fGVLKoY5fuAYu+x9rk6AlpNKmYN+i9BhjNI1t3ygZLF0To989dvcO5Ty5yTTNoXa +L1wJomJh3/EtU+WvwjGxKutugwRs4g/uPi95AzFSOhBr3PKCZrYYMAM+hZaxhQFg +k4aH6ZiMxyF1ZjKgWx6V +=pDYB +-----END PGP SIGNATURE----- +--=-=-=-- -- 2.26.2