From d62bc0333a6a00f6d3ca81079748832d5b1c0556 Mon Sep 17 00:00:00 2001 From: Jani Nikula Date: Tue, 22 Jan 2013 22:05:15 +0200 Subject: [PATCH] Re: [PATCH v3 00/20] insert command --- 65/efdd1058b84a5797af45c4b7771086574564ad | 160 ++++++++++++++++++++++ 1 file changed, 160 insertions(+) create mode 100644 65/efdd1058b84a5797af45c4b7771086574564ad diff --git a/65/efdd1058b84a5797af45c4b7771086574564ad b/65/efdd1058b84a5797af45c4b7771086574564ad new file mode 100644 index 000000000..a68f24f5f --- /dev/null +++ b/65/efdd1058b84a5797af45c4b7771086574564ad @@ -0,0 +1,160 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 0A2EB431FAF + for ; Tue, 22 Jan 2013 12:05:20 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -0.7 +X-Spam-Level: +X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5 + tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id wM3yW1+qhuh1 for ; + Tue, 22 Jan 2013 12:05:19 -0800 (PST) +Received: from mail-lb0-f178.google.com (mail-lb0-f178.google.com + [209.85.217.178]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id 2680B431FAE + for ; Tue, 22 Jan 2013 12:05:19 -0800 (PST) +Received: by mail-lb0-f178.google.com with SMTP id n1so3104434lba.23 + for ; Tue, 22 Jan 2013 12:05:16 -0800 (PST) +X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; + d=google.com; s=20120113; + h=x-received:from:to:subject:in-reply-to:references:user-agent:date + :message-id:mime-version:content-type:x-gm-message-state; + bh=Ly/rtQouJk5D/J3PT7W/8PdqNdFYTdbAu6XHhb7Jseo=; + b=X5mLXYHzjBKC3t/mk+kJELvnjJQ5YPE495ysXEdNFJ42QIj9ara8snb6z/hfwtsW6Y + aP2myNEDWPxZKyK2l3lAVwwqK2NJNVRENhs0KVFq1Ag4Cp5+wtCPE6Jb+IKU4eC2vmUA + XnmXm2dCUEbwHHeHdMqpeSiQnTGfocO6ZoPQmUz/7rrGqZX7ncd51qiTPPA0jgK0evTM + cxFaWi8yhXKo1oys3jbqA8dPze70gB78WX/UfOrRbr2gFjNshlKRVwhpCyzFSyALX50W + RRhg07mcsn/1CGrvLLw5FMBnRYWtiOtGp0C+3D99yV3zZbfglFRuoKnir0LH8Ht1hGva + jZVA== +X-Received: by 10.112.82.202 with SMTP id k10mr9881137lby.22.1358885116256; + Tue, 22 Jan 2013 12:05:16 -0800 (PST) +Received: from localhost (dsl-hkibrasgw4-50df51-27.dhcp.inet.fi. + [80.223.81.27]) + by mx.google.com with ESMTPS id hc20sm7441096lab.11.2013.01.22.12.05.14 + (version=TLSv1.2 cipher=RC4-SHA bits=128/128); + Tue, 22 Jan 2013 12:05:15 -0800 (PST) +From: Jani Nikula +To: Peter Wang , notmuch@notmuchmail.org +Subject: Re: [PATCH v3 00/20] insert command +In-Reply-To: <1358643004-14522-1-git-send-email-novalazy@gmail.com> +References: <1358643004-14522-1-git-send-email-novalazy@gmail.com> +User-Agent: Notmuch/0.14+255~gff3cc55 (http://notmuchmail.org) Emacs/24.2.1 + (x86_64-pc-linux-gnu) +Date: Tue, 22 Jan 2013 22:05:15 +0200 +Message-ID: <87zk01htl0.fsf@nikula.org> +MIME-Version: 1.0 +Content-Type: text/plain +X-Gm-Message-State: + ALoCoQlD3lFI8b0vG66zA/9T1/QLU73qrqSP7WBQUUR7ejDZKg0v7nuifgNkXJuds2fUl/v4WJmU +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Tue, 22 Jan 2013 20:05:20 -0000 + +On Sun, 20 Jan 2013, Peter Wang wrote: +> This mainly addresses review comments from v2 +> and rebases on top of tag-util.c. + +Hi Peter, I have some interest in seeing this get merged. To get that +done in a timely manner, my suggestion is to do this in two steps. Drop +the --folder and --create-folder options and the related code for now, +and submit them as another series once the first part has been +merged. It will be faster to iterate the first part, and we can dodge +some of the issues in the --folder and --create-folder options for now. + +This is just my personal opinion, and it's up to you whether you do this +or not. Let's just call it a hunch saying it'll be faster this way. ;) + +The patches would be rearranged as follows: + +> Peter Wang (20): +> tag-util: do not reset list in parse_tag_command_line +> tag-util: move out 'tag' command-line checks + +Keep the above separate, and make them the first preparatory patches. + +> cli: add stub for insert command +> insert: open Maildir tmp file +> insert: copy stdin to Maildir tmp file +> insert: move file from Maildir tmp to new +> insert: add new message to database +> insert: apply default tags to new message +> insert: parse and apply command-line tag operations +> insert: fsync after writing tmp file +> insert: trap SIGINT and clean up +> insert: add copyright line from notmuch-deliver + +Squash all of the above together into one patch. I will send a review of +these based on this version of the series. + +> insert: support --folder option +> insert: prevent writes outside Maildir hierarchy +> insert: add --create-folder option +> insert: fsync new directory after rename +> insert: fsync parent directory after mkdir + +Drop these for now. + +> man: document 'insert' command +> man: reference notmuch-insert.1 +> test: add tests for insert + +Keep these separate as they are, but update to reflect the above. + +Thoughts? + + +BR, +Jani. + +> +> Makefile.local | 1 + +> man/Makefile.local | 1 + +> man/man1/notmuch-config.1 | 4 +- +> man/man1/notmuch-count.1 | 4 +- +> man/man1/notmuch-dump.1 | 4 +- +> man/man1/notmuch-insert.1 | 59 +++++ +> man/man1/notmuch-new.1 | 4 +- +> man/man1/notmuch-reply.1 | 3 +- +> man/man1/notmuch-restore.1 | 3 +- +> man/man1/notmuch-search.1 | 3 +- +> man/man1/notmuch-show.1 | 3 +- +> man/man1/notmuch-tag.1 | 3 +- +> man/man1/notmuch.1 | 3 +- +> man/man5/notmuch-hooks.5 | 4 +- +> man/man7/notmuch-search-terms.7 | 3 +- +> notmuch-client.h | 3 + +> notmuch-insert.c | 482 ++++++++++++++++++++++++++++++++++++++++ +> notmuch-tag.c | 10 + +> notmuch.c | 3 + +> tag-util.c | 12 - +> tag-util.h | 2 + +> test/insert | 106 +++++++++ +> test/notmuch-test | 1 + +> 23 files changed, 692 insertions(+), 29 deletions(-) +> create mode 100644 man/man1/notmuch-insert.1 +> create mode 100644 notmuch-insert.c +> create mode 100755 test/insert +> +> -- +> 1.7.12.1 +> +> _______________________________________________ +> notmuch mailing list +> notmuch@notmuchmail.org +> http://notmuchmail.org/mailman/listinfo/notmuch -- 2.26.2